From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91150A0C44; Mon, 12 Apr 2021 15:54:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 56ECF1411F0; Mon, 12 Apr 2021 15:54:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id B63D71411EF for ; Mon, 12 Apr 2021 15:54:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618235671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3uvoOL/N8haDM/ryH9Diu5UCimJ4Wbm7x7OBR01zbg0=; b=SvhfAwR6jOiiMKFU4r/PUChh0+MhbHxSP5QTPWoBlRSGskf8+61E8fI8VIsqVXnVViqL6z RXGZCD4qlSB8HKbCj8hKVo0sqU7cfnHV0+f8ZkJ/7TPYN0RukxaHGv7zKq4EN9XgtUiPN1 8Vq1o6KorZ2kfTd69WwV1d8wRqNNevs= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-371-VyDJtzNNNO-c44ARgR-QRw-1; Mon, 12 Apr 2021 09:54:28 -0400 X-MC-Unique: VyDJtzNNNO-c44ARgR-QRw-1 Received: by mail-vk1-f200.google.com with SMTP id s194so3319814vkh.8 for ; Mon, 12 Apr 2021 06:54:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3uvoOL/N8haDM/ryH9Diu5UCimJ4Wbm7x7OBR01zbg0=; b=qvzo4/mYHFW041khEVXYYs0QrCRwhcs23yTFlAMtxJfosnrGq/gJo5b5RGu9opMLVT YyWO1Pf6C1zaJHokSw1iN+nauCQmE042vAHuIGVBv5O30PR/QWLxaDRGF8zUwETEZfyn rBlHH90bYx1+8QkMborPw3Ws9qc57DI8a1VwPYAMD/e1jBNkqBSja3Ym/3daQpGIrpIP oq64li5KoaDxWjr2Nd3QmheXBjjISXWv9ipg86ZwRHRSR8y0tePfSzCPKI1FaBA/cb14 k9DBoIIfNaTBDpvPcnGwm48XaO9okR485TlITg/BEglIIg8HhekVcPcwUmp/QueWz9Ug qbxA== X-Gm-Message-State: AOAM533zYKKHsnbkfKHTGZkS87Io16M8o/A0gmVKx87RTYOykfpxgAzm zMu4HXYICv69sIl0rNAs+QjzFW4CY5ecYDEqJMjvaKJ9zC3boBe+Lvpm8VUz54Xe/GFIcfoZEIe /Gs4p1vzp3Quega4MAbU= X-Received: by 2002:a1f:2a09:: with SMTP id q9mr3672145vkq.17.1618235667773; Mon, 12 Apr 2021 06:54:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/Zrekdp8ImU/T+KvsAIY62vdZ4oj0Rz2q2lf90UCh31zYDRs5UHQUEU2iVfhizgd5pCj8ZnNPJVoCaUAXihc= X-Received: by 2002:a1f:2a09:: with SMTP id q9mr3672133vkq.17.1618235667532; Mon, 12 Apr 2021 06:54:27 -0700 (PDT) MIME-Version: 1.0 References: <20210411122136.2560-1-talshn@nvidia.com> <3237657.no5xmyL5GM@thomas> <63ee5eb4-0388-87a5-683f-007d47180bb5@intel.com> In-Reply-To: <63ee5eb4-0388-87a5-683f-007d47180bb5@intel.com> From: David Marchand Date: Mon, 12 Apr 2021 15:54:16 +0200 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , Raslan Darawsheh , Tal Shnaiderman , "dev@dpdk.org" , Matan Azrad , Asaf Penso , Wisam Monther , "stable@dpdk.org" , Bruce Richardson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] common/mlx5: fix missing __rte_internal tags in exported functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 12, 2021 at 3:35 PM Ferruh Yigit wrote: > > On 4/12/2021 2:06 PM, Thomas Monjalon wrote: > > 12/04/2021 14:59, Ferruh Yigit: > >> On 4/12/2021 12:25 PM, Raslan Darawsheh wrote: > >>> Hi, > >>> > >>> From: Tal Shnaiderman > >>>> > >>> Removed __ from the commit title to fix wrong headline format issue. > >>> > >>>> Several functions introduced in the addition of the Windows support to > >>>> mlx5 were missing the __rte_internal tag although being exported. > >>>> > >>>> Fixes: 1552fb287166 ("common/mlx5: add alloc/dealloc PD on Windows") > >>>> Fixes: 1969ee424405 ("common/mlx5: add UMEM reg/dereg functions on > >>>> Windows") > >>>> Fixes: ba420719823c ("common/mlx5: add reg/dereg MR on Windows") > >>>> Cc: stable@dpdk.org > >>>> > >>>> Signed-off-by: Tal Shnaiderman > >>> > >>> Patch applied to next-net-mlx, > >>> > >> > >> Can we merge this directly to main repo? > >> Since debug build is broken without it. > > > > Which debug option? > > It is broken since when? > > > > > > "meson --buildtype=debug build && ninja -C build" is broken [1], I thought that > is why this patch is done at first place. > Some checks are done now only in the debug mode, since checks are reduced to > developer mode [2]. I don't think [2] has something to do with it. The symbols fixed here are inlined. In release (and debugoptimized) modes, I can see no trace of them in the .o $ nm build/drivers/librte_common_mlx5.a |grep umem_reg U mlx5dv_devx_umem_reg 0000000000000410 t mlx5_glue_devx_umem_reg While in debug mode: $ nm build.debug/drivers/librte_common_mlx5.a |grep umem_reg 00000000000000b9 t mlx5_os_umem_reg ^^^^^^^^^^^^^^^^^^ U mlx5dv_devx_umem_reg 0000000000001578 t mlx5_glue_devx_umem_reg The symbol check then catches mlx5_os_umem_reg wrt the version.map and complains mlx5_os_umem_reg is not tagged internal. -- David Marchand