From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4D243A0471 for ; Thu, 20 Jun 2019 13:03:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 320E71D389; Thu, 20 Jun 2019 13:03:56 +0200 (CEST) Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id B8A761D37F for ; Thu, 20 Jun 2019 13:03:54 +0200 (CEST) Received: by mail-vs1-f66.google.com with SMTP id j26so1264873vsn.10 for ; Thu, 20 Jun 2019 04:03:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7uzxJ5QJUwTglozJfHoraYM1U7wl9jIDnm/RCMbHBJQ=; b=Vjb0Ao52Xad4uPCuViBncC1iUImneYRwcF8qRxmgvcFqj1mYlbmIgApmiHApJAQtB1 bqCBF8nLc0AEJcjI0LLX1fzZNobvPYjYaeOqHUbdhyu4hiNWRUoRhXim6DGdnTydor2s f9j/k56kOb/e4wiNJVnUPJPf7rgK5Qz7BRSFCF3jUxZ30ac4fyziXkJjyyQwufycU7fc r5xeQW3U1DuvfHIe9yonDDb3lwmC+t8SN5lOltTk3afOzCr65bowHyHqOIl6UK18xLR+ OnK25pvvVD6jFGSFbfaCuTtVXzA3Zr2OPbIuFM7zp769h5JyfkkGQcxtW+kqpys/BaAH +sSA== X-Gm-Message-State: APjAAAXISRoX3RBMoVu7ZHfXDbhiMftCiEB9RTRZ9japCcJFeIT9eHAL RWuG924f2iTpE9LoQOFojM98rjUJCSBOGM4OFpBLGQ== X-Google-Smtp-Source: APXvYqzquxsbBmA0By/pOCZEPWrebPjcuz5WEboATz6X70y5G3lJrKgUmgjzdMgoxlyrT9g3ATARekOSVmzHpCTpRC8= X-Received: by 2002:a67:f998:: with SMTP id b24mr59644925vsq.180.1561028633745; Thu, 20 Jun 2019 04:03:53 -0700 (PDT) MIME-Version: 1.0 References: <20190619192215.25923-1-stephen@networkplumber.org> In-Reply-To: <20190619192215.25923-1-stephen@networkplumber.org> From: David Marchand Date: Thu, 20 Jun 2019 13:03:42 +0200 Message-ID: To: Stephen Hemminger Cc: dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4] eal: rename state values in rte_lcore_state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 19, 2019 at 9:24 PM Stephen Hemminger < stephen@networkplumber.org> wrote: > C language does not really treat enum's as first class symbols. > The values in an enum live in a global namespace. That means if > DPDK defines "RUNNING" it can't be used by another enum in an > application using DPDK. > > To solve this add a prefix "RTE_LCORE_" to the enum values, and > make them grammatically consistent. > > Also, simplify the inline thread_is_running() which is copied > in softnic and ip_pipeline. > > Signed-off-by: Stephen Hemminger > --- > v4 - rebase (after lcore changes),fix FreeBSD typo > > Did an extra pass, you missed the windows eal and the api descriptions: https://github.com/david-marchand/dpdk/commit/0084114455a82f90b783bdf1659a4af6f76c89f2 My only objection to this patch is that we are breaking a public API by removing those enums. We need to maintain those and send a deprecation notice for their future removal. -- David Marchand