From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2549042C01; Thu, 1 Jun 2023 11:23:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A50ED406B3; Thu, 1 Jun 2023 11:23:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 0D5A5406A2 for <dev@dpdk.org>; Thu, 1 Jun 2023 11:23:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685611407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WbonLf+Tkvcjz3qCr/thfOPltGsRiS27ddtf5iMYokE=; b=bTV99l0es8tYCqjIDuYEKASeoUHnHoxMVEvlJaAoSRISrgnbn6EO+suW9tGawheOUGFt+W +4zM1v5mWGMAi68pxLpsrjv8PokmOxx2woa0/8vsi0NDC5e1Bfxhv+YjZDRl5VHSR/7Ldn dcQxKIdTZ+9VlV0P4zfO7mMDVqPI1OU= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-117-v_zoVkEFNZa_hLHk7SBIfw-1; Thu, 01 Jun 2023 05:23:25 -0400 X-MC-Unique: v_zoVkEFNZa_hLHk7SBIfw-1 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-1afba64045aso13218365ad.0 for <dev@dpdk.org>; Thu, 01 Jun 2023 02:23:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685611404; x=1688203404; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WbonLf+Tkvcjz3qCr/thfOPltGsRiS27ddtf5iMYokE=; b=W5faw1Xf05g6FKNSnuyuHNtY/M6IgFRDbTV8OHyrvbf10rb+YXOIOPO7V9YKvfMbTY hxysOFpf0Hv169fAYsNEYXO2ua1IGdeLV1Pyx0eDXBKtb1s3jF+QjgSi+iKIwQ1+1Urs ix96F2hmvqGzYRiNT3Is6slz0MmnVsxw0Fv+pk8Tt4AVGll38FnFOUtA4Sqv33llglBk WEuosJ7pffKnddL5wgj94xzxXl5BAZwu1stk7jbhTvopWEbgGZEIZTjEOuLZZLvK4Cil hMhrY8uapdMboqq7Pe9mcmO7rC+BmmAwQGYggjFXcC+ysNt78ZGl8pf4/InEIyTsE5IZ KyBA== X-Gm-Message-State: AC+VfDxeF0674NAjVU+jdVjH2R9ybcg/+Ut+d0Mijb7sQ8eFcDxrggYi X7hMqzWTLIUYgGi/9tQbON67lm4LKmXO4fdId/YgEZklLOrcnD4wm5lZwYYj3vC1qXkCqJ7Ktw1 W15tZM1EqVknLZMFLiUg= X-Received: by 2002:a17:902:f686:b0:1ac:85b0:1bd8 with SMTP id l6-20020a170902f68600b001ac85b01bd8mr1133456plg.34.1685611404330; Thu, 01 Jun 2023 02:23:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6u11x8BCBDLpsTw0H+DvVwWzmSfa79f+71qUq38OfrHYmIp7K3AG0Tjx9lYvmCV8wC6qre1Es5FC6UrQGEFmU= X-Received: by 2002:a17:902:f686:b0:1ac:85b0:1bd8 with SMTP id l6-20020a170902f68600b001ac85b01bd8mr1133439plg.34.1685611403995; Thu, 01 Jun 2023 02:23:23 -0700 (PDT) MIME-Version: 1.0 References: <20230417043136.470110-1-sivaprasad.tummala@amd.com> <20230418082529.544777-1-sivaprasad.tummala@amd.com> <20230418082529.544777-2-sivaprasad.tummala@amd.com> <c4a70b5a-4929-3136-2eb5-25aaba1771af@amd.com> <ZD5hUHt/0YitpQQH@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <ZD5hUHt/0YitpQQH@bricha3-MOBL.ger.corp.intel.com> From: David Marchand <david.marchand@redhat.com> Date: Thu, 1 Jun 2023 11:23:12 +0200 Message-ID: <CAJFAV8ypVLCTUYoq_uDo32_TnWvUrWkCJ2y6f7wiaX+RE9BCrw@mail.gmail.com> Subject: Re: [PATCH v4 1/4] doc: announce new cpu flag added to rte_cpu_flag_t To: Bruce Richardson <bruce.richardson@intel.com>, Ferruh Yigit <ferruh.yigit@amd.com>, Sivaprasad Tummala <sivaprasad.tummala@amd.com> Cc: david.hunt@intel.com, dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On Tue, Apr 18, 2023 at 11:22=E2=80=AFAM Bruce Richardson <bruce.richardson@intel.com> wrote: > > On Tue, Apr 18, 2023 at 09:52:49AM +0100, Ferruh Yigit wrote: > > On 4/18/2023 9:25 AM, Sivaprasad Tummala wrote: > > > A new flag RTE_CPUFLAG_MONITORX is added to rte_cpu_flag_t in > > > DPDK 23.07 release to support monitorx instruction on EPYC processors= . > > > This results in ABI breakage for legacy apps. > > > > > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com> > > > --- > > > doc/guides/rel_notes/deprecation.rst | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_no= tes/deprecation.rst > > > index dcc1ca1696..831713983f 100644 > > > --- a/doc/guides/rel_notes/deprecation.rst > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > @@ -163,3 +163,6 @@ Deprecation Notices > > > The new port library API (functions rte_swx_port_*) > > > will gradually transition from experimental to stable status > > > starting with DPDK 23.07 release. > > > + > > > +* eal/x86: The enum ``rte_cpu_flag_t`` will be extended with a new c= pu flag > > > + ``RTE_CPUFLAG_MONITORX`` to support monitorx instruction on EPYC p= rocessors. There is no need for announcing an addition. The problem is moving/removing other elements of an enum. > > > > > > OK to add new CPU flag, > > Acked-by: Ferruh Yigit <ferruh.yigit@amd.com> > > > > > > But @David, @Bruce, is it OK to break ABI whenever a new CPU flag is > > added, should we hide CPU flags better? > > > > Or other option can be drop the 'RTE_CPUFLAG_NUMFLAGS' and allow > > appending new flags to the end although this may lead enum become more > > messy by time. > > +1 top drop the NUMFLAGS value. We should not break ABI each time we need= a > new flag. +1. So in 23.07 we need an announce for this removal to happen in 23.11. --=20 David Marchand