From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3491AA04DB; Fri, 16 Oct 2020 13:50:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C0BC11EBE8; Fri, 16 Oct 2020 13:50:37 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id C3B131EBE3 for ; Fri, 16 Oct 2020 13:50:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602849034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KwiF6ltaQSTG9qvs3r6zIef5v88BFcqP+uj60b44iNs=; b=JRACazRs41rq2gqx+xgHVIB6PxILm3upssBuaopHjGNo1WYZr/fNBEwn6Xms7+NR9B3Xmw Jsgk8Acng92k9dIrNMof0HRFujvo/p9KPveD6owK2JkOvfNw441N8uqSQ8EMLe3aPVO6SP lVPuArbKFu9YE6v/asYde1SzxsVqXtE= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-457-9-1aoc9kN3uec1g7AhozOg-1; Fri, 16 Oct 2020 07:50:30 -0400 X-MC-Unique: 9-1aoc9kN3uec1g7AhozOg-1 Received: by mail-vs1-f71.google.com with SMTP id z190so258112vsz.22 for ; Fri, 16 Oct 2020 04:50:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KwiF6ltaQSTG9qvs3r6zIef5v88BFcqP+uj60b44iNs=; b=JLr/d7hG81Hdo4u6U2vhKZMkZRmLueHBeibuwMru8HIjNCHosmrS2XBtApDJiUN9bl cJaR3KSCB8zA0664ZQu5Vf8QLVUml47HW1IUWfeDXBIp2rHErClnC7FwvpoO687+DC3y OSOkzEstIZyHd17fEaaUX73Fh/gxxNethZPs10DXeSuNZPLvqDAnDv2tVqaWzwGSEOEu IHjs2Jg2oti9js5psOVGA9MtlLnpWAxfE9A3jAxWjxotht7YVNe4mzI1xrTajlF56/Bu oazMTBIXdqJxv3y0ezKPw/tsepRoJG4p+3rUbJqBgfTHNGlPGkVvBS17qW4O+Flyhul2 MoMw== X-Gm-Message-State: AOAM53090ycOcCaCtP+qLNy+TZcCdYjUXypRDbocXf/GD93pCSttquO1 Q0X0dqwh4BBAx6x4dO+o101gTMonqgb9cnLa1BZsN0yz1iD3m/3rK0LACDmUYCdXBLhLzbsVwrs 8/hkCN8ie6rbYSqxh/bc= X-Received: by 2002:a67:e2d5:: with SMTP id i21mr1656672vsm.18.1602849029765; Fri, 16 Oct 2020 04:50:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJ2FKVoRkelSKYjpsv7wpFJk0RDtcN9hNn3PQsa+48nbWJV2s9GFK2NzGWAFAGFMzuv4NcAvPevu0jXII8Cu4= X-Received: by 2002:a67:e2d5:: with SMTP id i21mr1656659vsm.18.1602849029538; Fri, 16 Oct 2020 04:50:29 -0700 (PDT) MIME-Version: 1.0 References: <20201016090804.1242907-1-kevin.laatz@intel.com> In-Reply-To: <20201016090804.1242907-1-kevin.laatz@intel.com> From: David Marchand Date: Fri, 16 Oct 2020 13:50:18 +0200 Message-ID: To: Kevin Laatz , Van Haaren Harry Cc: dev , Lukasz Wojciechowski , Honnappa Nagarahalli , Phil Yang , Aaron Conole Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] test/service: fix race condition on stopping lcore X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 16, 2020 at 11:13 AM Kevin Laatz wrote: > > There is a potential race condition in 'service_attr_get' which will cause > test failures since the service core thread is still running while the > values are being retrieved/reset. > > This patch fixes the race condition by waiting for the service core thread > to stop before continuing with the unit test checks. We won't backport it, since we need a new API, but I would flag it for info as: Fixes: 4d55194d76a4 ("service: add attribute get function") Ok for you? -- David Marchand