From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 786C5A00C5; Mon, 11 May 2020 13:21:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 56B371C137; Mon, 11 May 2020 13:21:52 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 6D53A1C125 for ; Mon, 11 May 2020 13:21:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589196111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gnTos1Xyc/0jGT5UXiE0D0hymCxidvY98bO3ULk8J2c=; b=SY5xJunYwNDZVDSyrPONWchi1Q0uWpCMjksSckB3uURUPAZ3NXHOFYzo2ehq+2/mr1aPLP 2w0YjKmXs9sS6wrxZ9/MJhhya5wNR3rz51gaqwaH8+7rz150chPP0s2c6X5CsSJC/TUvFM RX6cKoTKwohMBtLr1nfb6Tb16Q94gDU= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-92-WYr6xJG2PLCb-Y3E9O1nfQ-1; Mon, 11 May 2020 07:21:49 -0400 X-MC-Unique: WYr6xJG2PLCb-Y3E9O1nfQ-1 Received: by mail-ua1-f69.google.com with SMTP id n5so4254887uaa.2 for ; Mon, 11 May 2020 04:21:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gnTos1Xyc/0jGT5UXiE0D0hymCxidvY98bO3ULk8J2c=; b=i5NvGD4JEihE9FgYTNThIYIx/L+5bTl94vuRqOqrTvYITBGpfIqJgGf6f1e6CBtPx4 YwEpc3U3bVhhgejb6BWgq0/uwPXiSG0gIxYCVeEyUBF1xC9UIyZlTt4dXyQSiW0GaS8I 7BTsQBSxTLAD1bEyOgIi3j14qqh74dsuVpr21t4hh5Z+VunQ/nNlHk32bC9NwKkiJTFg nxEOYL1Gt887a1KjzKnmA7vVE/rdXqnbAzZzpYmmQPZTje6rnsjQA7v9tUHDWPop33bV 4+cC0ALhA/JRNDFA+HOUUoth8fdF0rspKemKR1m6UA2uT6/x7NYvShQ+vHUOXNWbeDkT V3wg== X-Gm-Message-State: AGi0PuYq/s6fG3srdgf8I0bbtoFCA/Z9q5sbMeBVbsFeRPbZrXmvktPY cFAK21ej29CvRaSjg5MBgRygu3XKZWMMKIZSe6zpQgOu04VVBLIxYI/E8an5d6UtDkI1mxpd993 zNJyolivgcVwEE7Uypk0= X-Received: by 2002:a67:680e:: with SMTP id d14mr11233603vsc.180.1589196108578; Mon, 11 May 2020 04:21:48 -0700 (PDT) X-Google-Smtp-Source: APiQypLh5PKtEDcKJ0j2V3ZIYOfPlztu+9DjhdiMoXzgXd+s8xcbAdkiJFaFgSe50oDyQX9UKa/65KjE2RlVMRgRd/s= X-Received: by 2002:a67:680e:: with SMTP id d14mr11233592vsc.180.1589196108373; Mon, 11 May 2020 04:21:48 -0700 (PDT) MIME-Version: 1.0 References: <1588760683-11027-1-git-send-email-phil.yang@arm.com> <1588778884-13047-1-git-send-email-phil.yang@arm.com> In-Reply-To: <1588778884-13047-1-git-send-email-phil.yang@arm.com> From: David Marchand Date: Mon, 11 May 2020 13:21:37 +0200 Message-ID: To: Phil Yang Cc: dev , Van Haaren Harry , Thomas Monjalon , "Ananyev, Konstantin" , Jerin Jacob Kollanukkaran , Hemant Agrawal , Gage Eads , Bruce Richardson , Honnappa Nagarahalli , nd X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 0/6] use c11 atomics for service core lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 6, 2020 at 5:28 PM Phil Yang wrote: > > The rte_atomic ops and rte_smp barriers enforce DMB barriers on aarch64. > Using c11 atomics with explicit memory ordering instead of the rte_atomic > ops and rte_smp barriers for inter-threads synchronization can uplift the > performance on aarch64 and no performance loss on x86. > > This patchset contains: > 1) fix race condition for MT unsafe service. > 2) clean up redundant code. > 3) use c11 atomics for service core lib to avoid unnecessary barriers. Series applied, thanks for the cleanup and fixes. -- David Marchand