From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C71AF45D10; Mon, 25 Nov 2024 17:26:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F51140265; Mon, 25 Nov 2024 17:26:06 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 35DDB4021F for ; Mon, 25 Nov 2024 17:26:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732551964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sfRiYqiWiq8SmK+x/Op7BawYb408W1a99DNrORkaYgc=; b=esJPl2rlV/ShbTPAm+OTyLFdU21qMsEHMCqJpLFO6lR2KQHfHOOD1JD0EwJ4LI18CQwx4S y+JNJ9szECdQqyvrv9CSpjxr/PFkKDZ6ogmJ78nIWI4FmTAvtZxF54yd7HB2k+WkQdTuuq vKY5aAnYY2dscIJNmZD/1JD3yibkhcc= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-WkpCYWBsOkGaqGbuLxFG3g-1; Mon, 25 Nov 2024 11:26:02 -0500 X-MC-Unique: WkpCYWBsOkGaqGbuLxFG3g-1 X-Mimecast-MFC-AGG-ID: WkpCYWBsOkGaqGbuLxFG3g Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2ffcb81c223so3607281fa.2 for ; Mon, 25 Nov 2024 08:26:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732551961; x=1733156761; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sfRiYqiWiq8SmK+x/Op7BawYb408W1a99DNrORkaYgc=; b=P6vBx3ECm6tJEWxuqfXpvhCIeaAiLherDKbrOoJcHMqFKxIiV0DNFkkDscmb3h8fds RUItfLGJV58GM+i7bUImjiTD7B9QDpanuokOxmadgy/dcSoMcgsLAC3jPD+CDTwNRbXM PHN7CuCY3MZ4uXRZHWOY51ahA0iBmDx5Jz9wUdfUA+scSbtr/LyMylNUQb5IgzL23OMV bUmfGXtGAsHHCgedEwc5kR9bQYGuNsvS/tHQeVL89iMtbN/NRQ/daK5uT/daNwIgEo1s NW02iZU25EHAntt1ZyrY37uqI7kRae8l9q1CmuB4AlMLWH8fbA45pcQ3yQkz10C0G2uk ZyDg== X-Gm-Message-State: AOJu0YwZ7f3/8YeFQoGNrbIHAwpoFGmal9OxYnb3elXiFreJxUeVXbV/ tRYn9n6qcWreWfojwROqB1uhyTTMOUm6xNPmAZ9hrRiuEsw4fNBxyiTC1u2m//ImGBM09VPl182 O2n7KYSU9gz+0ahCXGIPj2Wr11AAJoPY6WcQz5iKjhPLObqlEfxgKxyRK+0NYxmblyJwycCPR3f YvHtxGlwl/IwgIQQ8= X-Gm-Gg: ASbGncugtelBw0f4UAc3hMCmwKEaZcBVB2AJYN4Qp1EteP0HVWzndx4Vfj/6ohgEsCg LlRIpwFRKm3fiCBp07piOyJeSIG+4TBPYRw== X-Received: by 2002:a05:6512:b8c:b0:53d:e615:7a2 with SMTP id 2adb3069b0e04-53de61509c3mr2318175e87.53.1732551960740; Mon, 25 Nov 2024 08:26:00 -0800 (PST) X-Google-Smtp-Source: AGHT+IFoONVpd7Ml1cHOEUXvfCtLc5qRJtlHGHVlXQiQ6F4EtsHGV7jKKq1MGgKutBcbPrAVJeTE1eXm6KTf1Qku3IA= X-Received: by 2002:a05:6512:b8c:b0:53d:e615:7a2 with SMTP id 2adb3069b0e04-53de61509c3mr2318154e87.53.1732551960409; Mon, 25 Nov 2024 08:26:00 -0800 (PST) MIME-Version: 1.0 References: <20241122125418.2857301-1-bruce.richardson@intel.com> In-Reply-To: <20241122125418.2857301-1-bruce.richardson@intel.com> From: David Marchand Date: Mon, 25 Nov 2024 17:25:47 +0100 Message-ID: Subject: Re: [RFC PATCH 00/21] Reduce code duplication across Intel NIC drivers To: Bruce Richardson Cc: dev@dpdk.org, Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2cCeJjwgA5cnYdN_Y_seYIiVlsCsSPbsVV4nviHuDVo_1732551961 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Bruce, On Fri, Nov 22, 2024 at 1:54=E2=80=AFPM Bruce Richardson wrote: > > This RFC attempts to reduce the amount of code duplication across a > number of Intel NIC drivers, specifically: ixgbe, i40e, iavf, and ice. Thanks for starting this effort! > > The first patch extract a function from the Rx side, otherwise the > majority of the changes are on the Tx side, leading to a converged Tx > queue structure across the 4 drivers, and a large number of common > functions. > > Open question: > * How should common code across drivers within a single device class be > managed? > - For now, I've created an "intel_eth" folder within the "common" > driver directory, thinking about it after, it implies to me that > it is common across driver classes. > - Would it be better to create an "intel_common" directory within the > "net" folder? common/ drivers currently host code that is device class agnostic, like providing helpers to talk with hw. No common/ driver has a dependency on some device class library. This series adds code that is not built into a library so there is no need to express dependencies in meson. But if the need arises, could it become a problem? (adding a dependency to lib/ethdev to some drivers/common/xx/). For now, I prefer the second proposition and have this code hosted in drivers/net/. --=20 David Marchand