Re: [PATCH v2 0/9] drivers/raw: introduce cnxk rvu lf device driver

[David Marchand <david.marchand@redhat.com>]

On Tue, Oct 8, 2024 at 12:54 PM Akhil Goyal <gakhil@marvell.com> wrote:
>
> CNXK product families can have a use case to allow PF and VF
> applications to communicate using mailboxes and also get notified
> of any interrupt that may occur on the device.
> Hence, a new raw device driver is added for such RVU LF devices.
> These devices can map to a PF or a VF which can send mailboxes to
> each other.
> The RVU LF device implements following features in the rawdev API:
>
> - Register mailbox callbacks for the other side to process mailboxes.
> - Register interrupt handler callbacks.
> - Process mailbox.
> - Set range of message IDs allowed for communication.
>
> Depends-on: https://patches.dpdk.org/project/dpdk/patch/20241008074000.3745855-1-gakhil@marvell.com/
>
> Changes in v2:
> - removed library patch from series
> - removed PMD logs from external PMD header.
> - updated doc/api/doxy-api-index.md
> - Added release notes

I see changes in wrong patches and the pmd API ending up in
cnxk_rvu_lf.h instead of rte_pmd_cnxk_rvu_lf.h (which I think was the
intention).

I am a bit skeptical about the pmd API that gives back a PCI bar
address to an application.
It looks more like the pmd specific API is unfinished and you are
leaving a door open for some guy who has the hw datasheet...


Thanks.

-- 
David Marchand