From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B39A45ADE; Tue, 8 Oct 2024 13:52:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6B1140650; Tue, 8 Oct 2024 13:52:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 120D64026F for ; Tue, 8 Oct 2024 13:52:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728388352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vS7eU/waOtZbCaNEyGS98C+qvZqmvvvns4b1OSsKZD0=; b=J7fACTNTAY4ues/9K0gYYDqLXtMbQHYyXSbZlfRybcq/I3V80RBdo7IOAlJS+bXvXmqxuX EJSfyVKrQ7czT6hmx7RQIcBIjLXE1w6wk06KziL9gcmabYm+IYU49J1Bh2/b7EeTMb6NKJ DWYLInpAvXpjkAIV9sp7MDQMYav1nWE= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-403-5NtsMc4wPiWZ5N76MdXOSQ-1; Tue, 08 Oct 2024 07:52:31 -0400 X-MC-Unique: 5NtsMc4wPiWZ5N76MdXOSQ-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2faea3961a3so39588921fa.2 for ; Tue, 08 Oct 2024 04:52:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728388350; x=1728993150; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vS7eU/waOtZbCaNEyGS98C+qvZqmvvvns4b1OSsKZD0=; b=nlho/TmT6RCYv8SF9F3UBKRzUQLkb3MPP6nvWI00TeuUV2U9yY2745MldGiGas7RYD +yRugKZihmU+iGj6ZrdFa2eEowsOtHYwZQBLqH7u+lYjKSCduXw/RCd6KJdsA424Avi3 horJr3I1Qx535XNCCu0lOs1CABnqHSFBDETPeBNVhwedWjMZjMU+xBOZ+3ajK0WMaWeA ciimnN+k3J9nYqbbr84kdfc1K/CVMvS5wXPZZXJeplRid+6MGobufcV8hxbsW+MzQ+mc pOa/jjPJJjCRNb6IXvcxRGqiqttnzfWgCy5GDmGxOmirX52t0Ow52AFpGd7UNeXqraRP te0A== X-Gm-Message-State: AOJu0YzUw3g3wLIeKO181EvxG2BXLrD1QFtwCKnk5YDLpjJz1/7Kmyaj pUzdK4x5ShjyBy6bpovpF49hCSAPFRPuzkJT9iKSpChOGTPN47sapNSPyKV9RJ41jIplp/oRjja sjCH1pnHODhpU0Q3MHWk9CVrmg+9pcNJACD/f//0HkAwryviNvwv7unNcrGIJRX4KZhZi+DAf1Q ILF45iSno3INjB04E= X-Received: by 2002:a2e:8e98:0:b0:2fa:de13:5c2a with SMTP id 38308e7fff4ca-2faf3c535d4mr52623511fa.25.1728388349918; Tue, 08 Oct 2024 04:52:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHMYEWyvAM3XQMwauHY1wnCR8yscL6Ny0fPIlRfPu3Zzp4mPQ+/hn8ZP1zlsk0TcST8hk4IPzcRnEmK5yg+EzQ= X-Received: by 2002:a2e:8e98:0:b0:2fa:de13:5c2a with SMTP id 38308e7fff4ca-2faf3c535d4mr52623331fa.25.1728388349486; Tue, 08 Oct 2024 04:52:29 -0700 (PDT) MIME-Version: 1.0 References: <20240907193311.1342310-3-gakhil@marvell.com> <20241008105415.1026962-1-gakhil@marvell.com> In-Reply-To: <20241008105415.1026962-1-gakhil@marvell.com> From: David Marchand Date: Tue, 8 Oct 2024 13:52:18 +0200 Message-ID: Subject: Re: [PATCH v2 0/9] drivers/raw: introduce cnxk rvu lf device driver To: Akhil Goyal Cc: dev@dpdk.org, thomas@monjalon.net, hemant.agrawal@nxp.com, jerinj@marvell.com, hkalra@marvell.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 8, 2024 at 12:54=E2=80=AFPM Akhil Goyal wr= ote: > > CNXK product families can have a use case to allow PF and VF > applications to communicate using mailboxes and also get notified > of any interrupt that may occur on the device. > Hence, a new raw device driver is added for such RVU LF devices. > These devices can map to a PF or a VF which can send mailboxes to > each other. > The RVU LF device implements following features in the rawdev API: > > - Register mailbox callbacks for the other side to process mailboxes. > - Register interrupt handler callbacks. > - Process mailbox. > - Set range of message IDs allowed for communication. > > Depends-on: https://patches.dpdk.org/project/dpdk/patch/20241008074000.37= 45855-1-gakhil@marvell.com/ > > Changes in v2: > - removed library patch from series > - removed PMD logs from external PMD header. > - updated doc/api/doxy-api-index.md > - Added release notes I see changes in wrong patches and the pmd API ending up in cnxk_rvu_lf.h instead of rte_pmd_cnxk_rvu_lf.h (which I think was the intention). I am a bit skeptical about the pmd API that gives back a PCI bar address to an application. It looks more like the pmd specific API is unfinished and you are leaving a door open for some guy who has the hw datasheet... Thanks. --=20 David Marchand