From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 867A5A0032; Fri, 1 Oct 2021 11:56:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 186244067E; Fri, 1 Oct 2021 11:56:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BB0BB4067A for ; Fri, 1 Oct 2021 11:56:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633082162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4WcK9fytaXlrencSWtExM4Mry2tSPY5cXJTV6Vt6ho0=; b=BS46KAXsQ6I/DBqemGlDjLGyja+87witSc35Bksmr/UwEWP+nnBKlc6VlEc4iZIGAKaxD5 Kq+2F1fxCe7oiHb9tib+qLff6sbQY2pF1R6bfDWL6JqA0awXVoXPROdzx0SJtZaT8UZP3t WVntyCVQ2BymKbUsKadqQ28IK+94f/4= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-96-1kTpTJxTMnu-TKJtXQMYgg-1; Fri, 01 Oct 2021 05:56:01 -0400 X-MC-Unique: 1kTpTJxTMnu-TKJtXQMYgg-1 Received: by mail-lf1-f71.google.com with SMTP id bp11-20020a056512158b00b003fc7d722819so8484304lfb.7 for ; Fri, 01 Oct 2021 02:56:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4WcK9fytaXlrencSWtExM4Mry2tSPY5cXJTV6Vt6ho0=; b=j/Ab+sr0kB58yqEI+m13JWSJacLOyOQsi7mQatJcPPGDpcIG9OK1OVqb4sKdWZzsP5 QiqkGjWvaVGtjIx2TDStCOgmKe8OqceKFarUWd5ZneOLCxzTCUiOSdKpiHZQHJj8ZFuQ ANhaen+sGG84i/a5CZ+9nae9JWHbtYDAbntmcYO742oa2mLQehPPzZRPKDLkPrUiSSLu 1vtb7fvxTdMwtejsbj+wjOugPAiN/xWAlF0ebmMDrPli6xhfyj4/tXa2GnbLAVdXBX0z zo2hEA0Fo/4egAMoDDw2cKzQ4CB0VaxZs0fOAUIME4vOxewcq6hyeQntqZz8807pR/KL c0Lw== X-Gm-Message-State: AOAM533t4B829T4vitpldCfx/vxpaMwRWY3B2LfjH18/2gPvCMnjgE7s Sb1uvQdgVDSlUnv7CzmaHWT3yn/h2TYfMOFgzXB6Kv5MeNoJh27DdbwWUyPoP6xJc/enXPh0S9K L+bwmzz8QVh3SDxECUkM= X-Received: by 2002:a2e:b707:: with SMTP id j7mr10324651ljo.297.1633082159444; Fri, 01 Oct 2021 02:55:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxiJqa/8sHe+40NJ1gTdrOfENtuHmWpq+N6RRjNjd3d6/J/6Ilm3XPFT9P5iT/45119Df6V8FQ/3K5xUYPkYSg= X-Received: by 2002:a2e:b707:: with SMTP id j7mr10324633ljo.297.1633082159214; Fri, 01 Oct 2021 02:55:59 -0700 (PDT) MIME-Version: 1.0 References: <20210823130343.87247-1-u9012063@gmail.com> <20210824162103.32783-1-u9012063@gmail.com> <20210920201111.GA7448@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <20211001123605.00fa6402@sovereign> <20211001125117.28f546b2@sovereign> In-Reply-To: <20211001125117.28f546b2@sovereign> From: David Marchand Date: Fri, 1 Oct 2021 11:55:47 +0200 Message-ID: To: William Tu , Dmitry Kozlyuk , Bruce Richardson Cc: Narcisa Ana Maria Vasile , Thomas Monjalon , dpdk-dev , Nick Connolly , Omar Cardona , Pallavi Kadam Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 1, 2021 at 11:51 AM Dmitry Kozlyuk wrote: > > 2021-10-01 12:36 (UTC+0300), Dmitry Kozlyuk: > > 2021-10-01 09:27 (UTC+0200), David Marchand: > > > [...] > > > I just have a concern that headers get broken again if we have no check. > > > Could buildtools/chkincs do the job (if we make this check work on Windows)? > > > > It's a valid caoncern and yes, chkincs would be a solution. Talked with Thomas, in any case, we can proceed with this patch. The check is something to add/make work the sooner the better. > > > > I discovered that the real issue with chkincs was a space after shebang in > > gen_c_file_for_header.py. If it is removed, find_program() is able to parse > > the line and call the script with Python interpreter. However, spaces > > *are* allowed after shebangs. Would you like me to submit a patch with a fix > > just chkincs or shall I *instead* work with meson developers (I'll do that > > anyway)? I'm asking because we have other files with extra spaces, so there's > > a question if we should fix them, add a rule for the space, etc. > > Just re-checked with meson 0.57.0 (as recommended in Windows GSG) and hit no > issue even with a space after "#!". Maybe it was a meson 0.47 issue on > Windows at the time you disabled chkins there? Maybe, I am not sure, Bruce had put this limitation. -- David Marchand