From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA783A04DB; Fri, 16 Oct 2020 13:55:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6C2D81C210; Fri, 16 Oct 2020 13:55:15 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 2C7961C1F0 for ; Fri, 16 Oct 2020 13:55:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602849311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QuxMNyvDqp8qI/HqyszsTe408qgAs4H2Vzbmx+HZrqQ=; b=b8ubwHolxc1jWthhzYG2F+B0uhZvE1eN5yz9vq6/irZ5HocA2phJRCNydM7QegRwqByYqO ODQAAU9E9XFZeKIl/ORDMe41EVBRD7FNq+3bwNvhqiZ3LbH2lg31jFPgOr1Tqfk+AEltoa d5caMg17Myl55TCdG1N5MmwtOCHqmxM= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-52KD5JThOz-glhr2xN9tiQ-1; Fri, 16 Oct 2020 07:55:10 -0400 X-MC-Unique: 52KD5JThOz-glhr2xN9tiQ-1 Received: by mail-vk1-f198.google.com with SMTP id t77so818521vkt.18 for ; Fri, 16 Oct 2020 04:55:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QuxMNyvDqp8qI/HqyszsTe408qgAs4H2Vzbmx+HZrqQ=; b=FIp5jwAN7DqFMtBHPuq2AfbQ/u82dg4SSWs8BqiNIFBa5Is/SVK0IOck5Sx5HIoFJ1 4dPw9XKcfRnd0vUTOQBSbnvL0v+ox6rDj2t3Ji2nEMJYrYo+mlzlM5HTT227XYxwh1uI oFbVDdr8d5y8B0joPe9MA4naxBhZapFOkx9nbSjxCEMj1rCxPH30mCe3l1D6pNECBtXy 2ztTJaKRSUgT6XombuPZiHcUjCDrcL6zxqa/wwj6mF8jyiV5XhOIPvBoanNrhntHXqbl 9XCAu/xvpdBwMCppvmT3DK0XwlISN4ulwNMnuJOI/9J5gFD3vts2eAv4Krt8ITPCDajT JTXg== X-Gm-Message-State: AOAM5313uAcNrjFvuQIPGJ03AKia9AE1SNrtJ/BafSDesqsPpRBNIPOA AQObZVd2c0rVhaij8nTjt8CRnQJPhcO++SBWgSSRN8eepmi7shHcioBoB27E1KndOUrvA841sgz B9+3emQeBXrTgNmwb0OQ= X-Received: by 2002:ab0:7313:: with SMTP id v19mr1355310uao.87.1602849309519; Fri, 16 Oct 2020 04:55:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjpo0P1jewqQQLtjksybW61MzFaSmKvUp0P8o/K4AEZQ2WBMTnnTjBELJ8Q6scKbNn3TPgUMcKq0Ik14kW1wg= X-Received: by 2002:ab0:7313:: with SMTP id v19mr1355296uao.87.1602849309320; Fri, 16 Oct 2020 04:55:09 -0700 (PDT) MIME-Version: 1.0 References: <20201016090804.1242907-1-kevin.laatz@intel.com> In-Reply-To: From: David Marchand Date: Fri, 16 Oct 2020 13:54:58 +0200 Message-ID: To: "Van Haaren, Harry" , "Laatz, Kevin" Cc: "dev@dpdk.org" , "l.wojciechow@partner.samsung.com" , "Honnappa.Nagarahalli@arm.com" , "phil.yang@arm.com" , "aconole@redhat.com" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] test/service: fix race condition on stopping lcore X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 16, 2020 at 11:18 AM Van Haaren, Harry wrote: > > Subject: [PATCH] test/service: fix race condition on stopping lcore > > > > There is a potential race condition in 'service_attr_get' which will cause > > test failures since the service core thread is still running while the > > values are being retrieved/reset. > > > > This patch fixes the race condition by waiting for the service core thread > > to stop before continuing with the unit test checks. Fixes: 4d55194d76a4 ("service: add attribute get function") > > Signed-off-by: Kevin Laatz > Acked-by: Harry van Haaren Thanks Kevin, Harry, applied. -- David Marchand