Re: [dpdk-dev] [PATCH 00/10] fix global variable multiple definitions

[David Marchand <david.marchand@redhat.com>]

On Thu, Sep 5, 2019 at 4:53 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> Issue has been detected by '-fno-common' gcc flag. By default compiler
> still can figure out that multiple definition are the same variable and
> use same storage for all definitions but this is implementation specific
> behaviour and better to fix it.
>
> Many of the cases below it is nice to have to use 'extern' keyword but
> there are some defects in 'virtio, ''dpaa2_sec' & 'test' that multiple
> components share same global variable unintentionally.
>
> Ferruh Yigit (10):
>   bus/fslmc: fix global variable multiple definitions
>   net/igb: fix global variable multiple definitions
>   crypto/null: fix global variable multiple definitions
>   crypto/octeontx: fix global variable multiple definitions

Dropped this patch, in favor of:
98c7b9c97e32 ("crypto/octeontx: fix global log variable definition")

>   crypto/dpaa2_sec: fix global variable multiple definitions

Hit a build issue (sent a separate mail), dropped this patch.

>   crypto/virtio: fix global variable multiple definitions
>   compress/octeontx: fix global variable multiple definitions
>   app/testpmd: fix global variable multiple definitions
>   app/test-pipeline: fix global variable multiple definitions

And as discussed, dropped this patch on test-pipeline as well.

>   test: fix global variable multiple definitions

My tests on master are ok, so going for it.


Applied, thanks.


--
David Marchand