From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E109FA046B for ; Tue, 23 Jul 2019 20:53:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A2ECB1C0BC; Tue, 23 Jul 2019 20:53:14 +0200 (CEST) Received: from mail-vs1-f65.google.com (mail-vs1-f65.google.com [209.85.217.65]) by dpdk.org (Postfix) with ESMTP id 40E281B9C9 for ; Tue, 23 Jul 2019 20:53:13 +0200 (CEST) Received: by mail-vs1-f65.google.com with SMTP id m23so29619618vso.1 for ; Tue, 23 Jul 2019 11:53:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=deb2IIN95gUzP9X0QOxqlgfeUT+INeNQjomvet7Glsk=; b=Qf9rqNpJeWNpApifl7Bd5d6kzHRyx0dGFGRLNW45V8G3Rj1psseOveMpXA5NV81zJ1 4+b2sVy31t70AL/3Ka7+1SYmnK1/lQSyp9JIp4JGp+sb+WInpSM31EN6hp1IaD0HVUEn g/mYsRXmxjCBKYvVcLk3f4NiCE6ATncclV036NcJBkh/n8zifvu1achKUGi96XmRRyrn B2+kpVEIvlZUJjsHdzyNHOOeHiEGEfMQxf2iKVkcHv9jn+Tb0ubqMH2TQ08NhxEKMyDF 860m2wKIjszw7RXRSmdwr3FO0ffui38XZ14KWxsAkxZqZL9oIpemQJJb0bTmrG4/AqBW 2C/A== X-Gm-Message-State: APjAAAUYTsxwdgkDIoKPbBoFd0bA4939+hQVISThSrX0J17pfmlc/UKe 5Mb9jmmg4j00tQDh8GAJgKStHsxhnpakTQ+t9jheBg== X-Google-Smtp-Source: APXvYqx4nkv7Tg0yp03ehiraFV51jc9fOMdeByCmLQysOaCB9kZQF21Kn9cb6Gup8Mn01e6bP6I2tm7Jt/MZyytMHIc= X-Received: by 2002:a67:2ec8:: with SMTP id u191mr51603276vsu.39.1563907992702; Tue, 23 Jul 2019 11:53:12 -0700 (PDT) MIME-Version: 1.0 References: <20190723162648.15217-1-bruce.richardson@intel.com> In-Reply-To: <20190723162648.15217-1-bruce.richardson@intel.com> From: David Marchand Date: Tue, 23 Jul 2019 20:53:01 +0200 Message-ID: To: Bruce Richardson Cc: dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix compiler warning for incorrect include X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 23, 2019 at 6:27 PM Bruce Richardson wrote: > > Some builds with clang report an error because '<>' rather than '""' were > used for including the ioat spec header file. > > Target: x86_64-native-bsdapp-clang > 22:10: error: 'rte_ioat_spec.h' file not found with include; use "quotes" instead > #include > ^~~~~~~~~~~~~~~~~ > "rte_ioat_spec.h" > 1 error generated. > > Since this file should always be in the same directory as the main header, > we can safely change the include line to fix this error. > > Fixes: abff4333ec20 ("raw/ioat: create device on probe and destroy on release") > > Signed-off-by: Bruce Richardson Still a bit skeptical at why we did not see this on linux.. But this can't hurt and hopefully it fixes the issue :-) Reviewed-by: David Marchand -- David Marchand