From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59469A0560; Mon, 17 Oct 2022 15:22:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 387D94021D; Mon, 17 Oct 2022 15:22:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 73AB740143 for ; Mon, 17 Oct 2022 15:22:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666012941; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GJxINYQI6zLDiN79moM/YBpbI+si4eJzuPwJsMY8ZZo=; b=RaSj01Cp7Bgs3Plop6QStDAqFFY7PcyRa4dehP+y0GQvle6xJF3YDk9Rh727f0yCE8eYIP YC+j191+UlRm+tG2ojjX8dA4OIvr16rfmF/szmatCPW6H151lTjH5wEXaqFEKKG4X70iR/ xJppyYwe//7/nQ6+cfSr1JB2i03tUHg= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-646-i6P8G8xjPziyRgRYcrzJrw-1; Mon, 17 Oct 2022 09:22:19 -0400 X-MC-Unique: i6P8G8xjPziyRgRYcrzJrw-1 Received: by mail-pf1-f198.google.com with SMTP id cw4-20020a056a00450400b00561ec04e77aso6109369pfb.12 for ; Mon, 17 Oct 2022 06:22:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GJxINYQI6zLDiN79moM/YBpbI+si4eJzuPwJsMY8ZZo=; b=zlsx5R4V6GUMeE5yxJqN4uTPQVRtQ6fxpBllPRZYf9sCyIkb78AHwMjxD5JKS9LFsK O26E+wypn5jeqIvGmw5y1+4bBLr3fboy6L/eU0AXLeCmcsZmI4NRnd4s4Ync+OECJep9 gFK8RCkSZMffzhs2qAhY29T2ceAauBn8QHW60gWg1HrklCaITjWB3o0Rln+kJLLXjF44 kh2V3H1InIYRcpWyZxbAoL0mM0rxQ5Sv/eBlPczMEeZqwGf9IqI5680vM05OVGWuyxiq TA9atZYQVUeTGXAy3G6z0zomdedYiZkiR4T8L9xRZLHHv7PsODqhH/nUZG/hQpS8QuNw yA1Q== X-Gm-Message-State: ACrzQf0ot3mFhTitEIrwjIAfkXmiepzFPQqXV+nX4nSBpinYyq+4+IaP QoE0g8Y2FL4uumIa/RqkG2sjqZwwLZqwBPAX1kzkRkD+OgumnZ4lGx4Fwrl4FLOS+AXAGKUe3J9 CoE0ji3m1Gpq8c/No+qQ= X-Received: by 2002:a17:903:2307:b0:181:e618:b4c5 with SMTP id d7-20020a170903230700b00181e618b4c5mr11687724plh.172.1666012938723; Mon, 17 Oct 2022 06:22:18 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Ia026xB4Eyugp/HNBepHTN/tHLM7t/2xxjxVc9yz9mSvp+BxdkIar/GUkEDGwm9SrTzhGIi8nehP59gYqQMM= X-Received: by 2002:a17:903:2307:b0:181:e618:b4c5 with SMTP id d7-20020a170903230700b00181e618b4c5mr11687704plh.172.1666012938437; Mon, 17 Oct 2022 06:22:18 -0700 (PDT) MIME-Version: 1.0 References: <20221010153751.58951-1-maxime.coquelin@redhat.com> In-Reply-To: <20221010153751.58951-1-maxime.coquelin@redhat.com> From: David Marchand Date: Mon, 17 Oct 2022 15:22:07 +0200 Message-ID: Subject: Re: [PATCH] vhost: promote per-queue stats API to stable To: Maxime Coquelin Cc: dev@dpdk.org, chenbo.xia@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Oct 10, 2022 at 5:37 PM Maxime Coquelin wrote: > > This patch promotes the per-queue stats API to stable. > The API has been used by the Vhost PMD since v22.07, and > David Marchand posted a patch to make use of it in next > OVS release[0]. > > [0]: http://patchwork.ozlabs.org/project/openvswitch/patch/20221007111613.1695524-4-david.marchand@redhat.com/ > > Signed-off-by: Maxime Coquelin > --- > doc/guides/rel_notes/release_22_11.rst | 4 ++++ > lib/vhost/rte_vhost.h | 3 --- > lib/vhost/version.map | 6 +++--- > 3 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst > index 37bd392f34..d5d3eeae24 100644 > --- a/doc/guides/rel_notes/release_22_11.rst > +++ b/doc/guides/rel_notes/release_22_11.rst > @@ -443,6 +443,10 @@ API Changes > > * raw/ifgpa: The function ``rte_pmd_ifpga_get_pci_bus`` has been removed. > Nit: in the RN, vhost library updates go earlier. > +* vhost: Promoted ``rte_vhost_vring_stats_get()``, > + ``rte_vhost_vring_stats_get_names()`` and ``rte_vhost_vring_stats_reset()`` > + from experimental to stable. > + > > ABI Changes > ----------- > diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h > index bb7d86a432..59c98a0afb 100644 > --- a/lib/vhost/rte_vhost.h > +++ b/lib/vhost/rte_vhost.h > @@ -1075,7 +1075,6 @@ rte_vhost_slave_config_change(int vid, bool need_reply); > * - Failure if lower than 0. The device ID or queue ID is invalid or > + statistics collection is not enabled. > */ > -__rte_experimental > int > rte_vhost_vring_stats_get_names(int vid, uint16_t queue_id, > struct rte_vhost_stat_name *name, unsigned int size); > @@ -1103,7 +1102,6 @@ rte_vhost_vring_stats_get_names(int vid, uint16_t queue_id, > * - Failure if lower than 0. The device ID or queue ID is invalid, or > * statistics collection is not enabled. > */ > -__rte_experimental > int > rte_vhost_vring_stats_get(int vid, uint16_t queue_id, > struct rte_vhost_stat *stats, unsigned int n); > @@ -1120,7 +1118,6 @@ rte_vhost_vring_stats_get(int vid, uint16_t queue_id, > * - Failure if lower than 0. The device ID or queue ID is invalid, or > * statistics collection is not enabled. > */ > -__rte_experimental > int > rte_vhost_vring_stats_reset(int vid, uint16_t queue_id); > > diff --git a/lib/vhost/version.map b/lib/vhost/version.map > index 7a00b65740..8c5e8aa8d3 100644 > --- a/lib/vhost/version.map > +++ b/lib/vhost/version.map > @@ -57,6 +57,9 @@ DPDK_23 { > rte_vhost_set_vring_base; > rte_vhost_va_from_guest_pa; > rte_vhost_vring_call; > + rte_vhost_vring_stats_get; > + rte_vhost_vring_stats_get_names; > + rte_vhost_vring_stats_reset; > > local: *; > }; > @@ -88,9 +91,6 @@ EXPERIMENTAL { > > # added in 22.07 > rte_vhost_async_get_inflight_thread_unsafe; > - rte_vhost_vring_stats_get_names; > - rte_vhost_vring_stats_get; > - rte_vhost_vring_stats_reset; > rte_vhost_async_try_dequeue_burst; > rte_vhost_driver_get_vdpa_dev_type; > rte_vhost_clear_queue; > -- > 2.37.3 > Acked-by: David Marchand -- David Marchand