From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92A20A052B; Wed, 29 Jul 2020 10:54:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5B2ED10A3; Wed, 29 Jul 2020 10:54:55 +0200 (CEST) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by dpdk.org (Postfix) with ESMTP id 5F608F04 for ; Wed, 29 Jul 2020 10:54:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596012893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aRYNwrmWYLJenXJ4N0owoV3McV0vw0oqAEJ6AC4+QWQ=; b=fw3hkisONLqkPJurHETq0rOEbYbYlVelR0WMAWb4y1hKbV2Aknq7amMtuf3yjtWi3Bll/k rmnxwOROHbrCkuqaSoYabnt9BbsC0Z9ZxdtOjNy3epSB8TooCh05oEupoOwGjkyFMVF4MT 7RY3mMmNkMFSLAWEkUgU1javsCoxd8Q= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-300-4ZpFV3h7Ot-XrXZUSCkJAw-1; Wed, 29 Jul 2020 04:54:52 -0400 X-MC-Unique: 4ZpFV3h7Ot-XrXZUSCkJAw-1 Received: by mail-vs1-f72.google.com with SMTP id i11so2927287vsk.0 for ; Wed, 29 Jul 2020 01:54:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aRYNwrmWYLJenXJ4N0owoV3McV0vw0oqAEJ6AC4+QWQ=; b=GPqJ1cIObZMPXtfJIeDVVrQtHaw36gY6YKtsGbHyEgb+iBhys6huKm3n14EAcBjBO9 dEVJLnalTy3kqCDv51NKuKUQ3/Gge6ThbXTl57zqndjeRuayeg9gje+ToFDY5GFkfuAF XgPNK5hVXxn/uwgoboaXBG3Ayp/5KdFS6GTU98U84EPnBmpPd7ay9DXcaVAUul1J7LRw DFnFQ71ok4Zu8b5VSqfFF54czsjQh0RUfs8J66PhlGYUieP8OVqqOaW1Pf+B4Jq6adJK 6bkyJQtXzhp+paPv0yEvZbRTLDeBSu7cMjj82BcQAnDDVNcrS6+bh0UvVk5RQmOlJGDE 7X1A== X-Gm-Message-State: AOAM531S+6Sd6xIsJHqM/BHFSg8iXeRQTNGyPyww3t7la8tZrmas9FIc KWh61QxtfC0zdfYTssN46W8cggCNrcwbAX7/uHg/1Q77JkdfudOzgjgHNgOt9K0JP6Xtfrt61dg Mxfy5XBd3LQs/zl/LAIk= X-Received: by 2002:a67:e43:: with SMTP id 64mr8620526vso.198.1596012891484; Wed, 29 Jul 2020 01:54:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8NK//rrj99oIRPCXsg5sCMPfcqGRdxRCUmfFMz+sbg2zzW8OxVne8tmPGRsTxRRMPdFNik2gfzwoV6jnm3qc= X-Received: by 2002:a67:e43:: with SMTP id 64mr8620519vso.198.1596012891243; Wed, 29 Jul 2020 01:54:51 -0700 (PDT) MIME-Version: 1.0 References: <20200728085531.204296-1-yuying.zhang@intel.com> <20200728170950.208532-1-yuying.zhang@intel.com> In-Reply-To: <20200728170950.208532-1-yuying.zhang@intel.com> From: David Marchand Date: Wed, 29 Jul 2020 10:54:40 +0200 Message-ID: To: Yuying Zhang Cc: dev , Olivier Matz , Qi Zhang , Qiming Yang , "Yigit, Ferruh" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/1] net: fix TSO packets checksum incorrect X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 28, 2020 at 7:11 PM Yuying Zhang wrote: > > The ol_flags check lacks of flag for IPv6 which causes checksum > flag configuration error while IPv6/TCP TSO packet is sent. > This patch fixes the issue by adding PKT_TX_TCP_SEG flag. > > Fixes: 520059a41aa9 ("net: check fragmented headers in non-debug as well") > > Signed-off-by: Yuying Zhang > --- > lib/librte_net/rte_net.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_net/rte_net.h b/lib/librte_net/rte_net.h > index 1edc283a4..94b06d9ee 100644 > --- a/lib/librte_net/rte_net.h > +++ b/lib/librte_net/rte_net.h > @@ -125,7 +125,7 @@ rte_net_intel_cksum_flags_prepare(struct rte_mbuf *m, uint64_t ol_flags) > * Mainly it is required to avoid fragmented headers check if > * no offloads are requested. > */ > - if (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK))) > + if (!(ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_L4_MASK | PKT_TX_TCP_SEG))) > return 0; > > if (ol_flags & (PKT_TX_OUTER_IPV4 | PKT_TX_OUTER_IPV6)) > -- > 2.25.1 > Reviewed-by: David Marchand Olivier suggestion on the commitlog/title looks fine to me. -- David Marchand