From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0746A04E7; Mon, 2 Nov 2020 10:56:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 60E10BE41; Mon, 2 Nov 2020 10:56:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id EE894BBBA for ; Mon, 2 Nov 2020 10:56:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604311001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=40c5MsUmFuAjZOLIXeMQ7cG7t5yQMVLri1TKEvWLCi8=; b=Ydg/4JdXDrmn5v34vd+lo15dlRSOtkM5iJcSptaAstjqPMuMy/6jWEdz5tlWfLLmL+CwZe hQUHR/mVeKf6KXdKLfSTeX0klw+yl3m3x08s3O203H27/vI8UWtfuOBGX9PBuBBA9BIoru oPyw9w2D0smcdR1P5nAJK8TPNUmBToA= Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-552-cFFOM2woM96mEMYv-QIHJg-1; Mon, 02 Nov 2020 04:56:39 -0500 X-MC-Unique: cFFOM2woM96mEMYv-QIHJg-1 Received: by mail-vs1-f69.google.com with SMTP id g5so4729777vsg.14 for ; Mon, 02 Nov 2020 01:56:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=40c5MsUmFuAjZOLIXeMQ7cG7t5yQMVLri1TKEvWLCi8=; b=nAy4dmma4rkz4DRLggCd3uEYf2nHtQTbRCbR1884pzxIIpp9H4w2E7wU3T3YWm0Sdy XutT9+mWO323JMVEZiEoVXYt0mhLsDzi/AIydiADqUGYphpq7qZCe0a9w2VgoVx4EzL6 tBNapFwTLNOCvipKSzisAj0KIOkK2ADaSFyx45Pyqt1fWv+lFwnAIl8KMOrBPdguCIDQ 5lDD6E5vlrDUDkSKCm5pXdiVk/nTu1W/lNELDZW97HidE2gmwOWCie5l+QFBaXgIcQZS aaa4HTitPj3tBTy5u3yLcCBf/W/SOW1mNo9erWTMNkblR6Fm63uWRROsc6QoI9QewQtY kgxw== X-Gm-Message-State: AOAM533iYKiKoSVySzx2GFnPpjxQTvTHr9EiyaS1QENsUxf86hhoMLhl uvAuBY1uAIgHV5758kEeRmKAwb9lmaYNAoNCULes4zzCEtjCc7R+X5wyARQSA9sVQ3abnI1xbXc 1UvKh0LpiZ3nkMUWZORc= X-Received: by 2002:a67:2fca:: with SMTP id v193mr14486116vsv.18.1604310998559; Mon, 02 Nov 2020 01:56:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJwaMZwEx7GitnXKryBeJhUOu3HHq7uXHajJNnBox+kwcV5Vpg3XETITwRnDHhXugWaJNsGyVbUlTRQOGVqRHUA= X-Received: by 2002:a67:2fca:: with SMTP id v193mr14486112vsv.18.1604310998311; Mon, 02 Nov 2020 01:56:38 -0800 (PST) MIME-Version: 1.0 References: <20200612212434.6852-2-timothy.mcdaniel@intel.com> <1604258796-19966-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: From: David Marchand Date: Mon, 2 Nov 2020 10:56:27 +0100 Message-ID: To: "McDaniel, Timothy" Cc: dev , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , Jerin Jacob Kollanukkaran , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v15 00/23] Add DLB PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Nov 1, 2020 at 10:26 PM McDaniel, Timothy wrote: > > + I did not look too much at the PCI code in this file, but I suspect > > we could factor some of it with librte_pci. > > > > Can we look at possibly doing that post rc2 merge? Please try to look at dpdk existing API before adding code. Ok for a followup cleanup. > > > > > > - fix missing "~" in dlb documentation > > > - delay introduction of _delayed token pop functions to > > > token pop commit (fixes 8 or so unused function errors) > > > - all patches build incrementally (gcc), and checkpatches reports > > > success > > > > There is a valid warning on patch 6: > > http://mails.dpdk.org/archives/test-report/2020-November/164347.html > > > > WARNING:REPEATED_WORD: Possible repeated word: 'of' > > #1493: FILE: drivers/event/dlb/pf/base/dlb_osdep_bitmap.h:364: > > + * Returns the bitmap's longest contiguous range of of set bits upon success, > > > > I will address with the next patch-set. Odd that I did not see the error/warning when I > ran devtools/checkpatches.sh You need a fairly recent checkpatch.pl. -- David Marchand