From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61313A00C5; Thu, 27 Oct 2022 14:04:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF5DE42670; Thu, 27 Oct 2022 14:04:33 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4139141153 for ; Thu, 27 Oct 2022 14:04:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666872271; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6Nm7oXsiS3qsFHkWlycI9BMkTRBEspkFoG6nGa0q0UY=; b=X7m92DiqgCn2xus8duujGaBwvjf2hOOURR1dnXlygAgrMdwDefCgynkqsLbJ/RfHLb1Z11 IbKUzMguNaWpVLK9t964uetZJvxh2TGD9QNM/E7x18ds/gq1PhoqYr1ssOJf+q1LL+f7cS m0w6D1oP8D12Y8b9twS48wdqTEuAYw0= Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-529-TIcwCf0fP5avC3yz87KejQ-1; Thu, 27 Oct 2022 08:04:30 -0400 X-MC-Unique: TIcwCf0fP5avC3yz87KejQ-1 Received: by mail-pf1-f200.google.com with SMTP id n23-20020aa78a57000000b0056cb9492fcaso62728pfa.23 for ; Thu, 27 Oct 2022 05:04:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6Nm7oXsiS3qsFHkWlycI9BMkTRBEspkFoG6nGa0q0UY=; b=sv12dj3IIZmF6hUSksLo750ODh5tlXHQU7AFUms1O4ecOPmAzQIRXAPWpzbbF3WZ5B 1x+5PnezEMNGaYlrT12nefkGtwOyzzpMeGnAlisDAJzWz1yOaoed4D7DHwMdbsfgkKOU 5duHOIm8drnNvyb/qqH8UYGxO/ZMZpsSuyEAc5K5pZiPiXXpx5FcJs5HtI8RuLjSDzP6 dCB8NGpP+0N+S/UHjFvJ9p/i/WzgxGD7A9AHMdAZBN3ioohVhqm75XJkxH2QJwwYZNdV rrCiAbSqm5T485G71l9gJ+zQgRG/iEed47mpGZaYFBGb95BGsIBYt7/tGoc+BOP4TvGY MiGQ== X-Gm-Message-State: ACrzQf182SrSx/itfM0x64Q2pwrHcI6aWEpRO4qeI56BIBg662OxCA5V wiVr62xkO7z1W5ZYQr3IS6e9N0GYR7hgvN1UFgJDmf9geaUPAuNDlqK+wQqqmfbnZHNegwnpGLz THtIN6xXebKR7NAQvv74= X-Received: by 2002:a63:5b58:0:b0:452:2ba4:f86b with SMTP id l24-20020a635b58000000b004522ba4f86bmr40600171pgm.223.1666872269551; Thu, 27 Oct 2022 05:04:29 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6kd5CeCRbIyH2nBcLxaapg9Gs695uKe9diKFWoVAofMH8VtYxrod3yxO9U+aPJFVqyJ15yLajo05RQuwNV8qo= X-Received: by 2002:a63:5b58:0:b0:452:2ba4:f86b with SMTP id l24-20020a635b58000000b004522ba4f86bmr40600151pgm.223.1666872269286; Thu, 27 Oct 2022 05:04:29 -0700 (PDT) MIME-Version: 1.0 References: <20221012120525.11509-1-markus.theil@tu-ilmenau.de> In-Reply-To: <20221012120525.11509-1-markus.theil@tu-ilmenau.de> From: David Marchand Date: Thu, 27 Oct 2022 14:04:17 +0200 Message-ID: Subject: Re: [PATCH] telemetry: make usable from C++ To: Markus Theil Cc: dev@dpdk.org, Ciara Power , Markus Theil X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 12, 2022 at 2:05 PM Markus Theil wrote: > > From: Markus Theil > > Add missing include in order to make C++ compilers > happy. > We have build checks for headers (-Dcheck_includes meson option), like for C++: $ cat $BUILDDIR/buildtools/chkincs/chkincs-cpp.p/rte_telemetry.cpp #include "/home/dmarchan/dpdk/lib/telemetry/rte_telemetry.h" [917/1289] ccache c++ -Ibuildtools/chkincs/chkincs-cpp.p -Ibuildtools/chkincs -I../../../dpdk/buildtools/chkincs -Iexamples/vmdq_dcb -I../../../dpdk/examples/vmdq_dcb -I../../../dpdk/examples/common -Idrivers/bus/vdev -I../../../dpdk/drivers/bus/vdev -I. -I../../../dpdk -Iconfig -I../../../dpdk/config -Ilib/eal/include -I../../../dpdk/lib/eal/include -Ilib/eal/linux/include -I../../../dpdk/lib/eal/linux/include -Ilib/eal/x86/include -I../../../dpdk/lib/eal/x86/include -Ilib/eal/common -I../../../dpdk/lib/eal/common -Ilib/eal -I../../../dpdk/lib/eal -Ilib/kvargs -I../../../dpdk/lib/kvargs -Ilib/metrics -I../../../dpdk/lib/metrics -Ilib/telemetry -I../../../dpdk/lib/telemetry -Idrivers/bus/pci -I../../../dpdk/drivers/bus/pci -I../../../dpdk/drivers/bus/pci/linux -Ilib/pci -I../../../dpdk/lib/pci -Ilib/ring -I../../../dpdk/lib/ring -Ilib/rcu -I../../../dpdk/lib/rcu -Ilib/mempool -I../../../dpdk/lib/mempool -Ilib/mbuf -I../../../dpdk/lib/mbuf -Ilib/net -I../../../dpdk/lib/net -Ilib/meter -I../../../dpdk/lib/meter -Ilib/ethdev -I../../../dpdk/lib/ethdev -Ilib/cmdline -I../../../dpdk/lib/cmdline -Ilib/hash -I../../../dpdk/lib/hash -Ilib/timer -I../../../dpdk/lib/timer -Ilib/acl -I../../../dpdk/lib/acl -Ilib/bbdev -I../../../dpdk/lib/bbdev -Ilib/bitratestats -I../../../dpdk/lib/bitratestats -Ilib/bpf -I../../../dpdk/lib/bpf -Ilib/cfgfile -I../../../dpdk/lib/cfgfile -Ilib/compressdev -I../../../dpdk/lib/compressdev -Ilib/cryptodev -I../../../dpdk/lib/cryptodev -Ilib/distributor -I../../../dpdk/lib/distributor -Ilib/efd -I../../../dpdk/lib/efd -Ilib/eventdev -I../../../dpdk/lib/eventdev -Ilib/gpudev -I../../../dpdk/lib/gpudev -Ilib/gro -I../../../dpdk/lib/gro -Ilib/gso -I../../../dpdk/lib/gso -Ilib/ip_frag -I../../../dpdk/lib/ip_frag -Ilib/jobstats -I../../../dpdk/lib/jobstats -Ilib/kni -I../../../dpdk/lib/kni -Ilib/latencystats -I../../../dpdk/lib/latencystats -Ilib/lpm -I../../../dpdk/lib/lpm -Ilib/member -I../../../dpdk/lib/member -Ilib/pcapng -I../../../dpdk/lib/pcapng -Ilib/power -I../../../dpdk/lib/power -Ilib/rawdev -I../../../dpdk/lib/rawdev -Ilib/regexdev -I../../../dpdk/lib/regexdev -Ilib/dmadev -I../../../dpdk/lib/dmadev -Ilib/rib -I../../../dpdk/lib/rib -Ilib/reorder -I../../../dpdk/lib/reorder -Ilib/sched -I../../../dpdk/lib/sched -Ilib/security -I../../../dpdk/lib/security -Ilib/stack -I../../../dpdk/lib/stack -Ilib/vhost -I../../../dpdk/lib/vhost -Ilib/ipsec -I../../../dpdk/lib/ipsec -Ilib/fib -I../../../dpdk/lib/fib -Ilib/port -I../../../dpdk/lib/port -Ilib/pdump -I../../../dpdk/lib/pdump -Ilib/table -I../../../dpdk/lib/table -Ilib/pipeline -I../../../dpdk/lib/pipeline -Ilib/flow_classify -I../../../dpdk/lib/flow_classify -Ilib/graph -I../../../dpdk/lib/graph -Ilib/node -I../../../dpdk/lib/node -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Werror -O2 -g -include rte_config.h -march=nehalem -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -MD -MQ buildtools/chkincs/chkincs-cpp.p/meson-generated_rte_telemetry.cpp.o -MF buildtools/chkincs/chkincs-cpp.p/meson-generated_rte_telemetry.cpp.o.d -o buildtools/chkincs/chkincs-cpp.p/meson-generated_rte_telemetry.cpp.o -c buildtools/chkincs/chkincs-cpp.p/rte_telemetry.cpp Besides, I fail to see the need for stddef.h. In which setup / case, did you get a compilation issue? -- David Marchand