From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B62814591C; Fri, 6 Sep 2024 11:48:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 406D842E12; Fri, 6 Sep 2024 11:48:29 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AE5034029E for ; Fri, 6 Sep 2024 11:48:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725616107; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2dOR2KW01MTjUXo6fQTElsodLv/FajDuiZrvM5ocWJE=; b=Xf+EmZgzWIPoVhXl6fmFoUCc+4t4EzK1d94mThMtUniJ7OK0SYfr1wuQZGMhyi7NMiXlAH jlw8Gc9/oYkjGTfxQ+zPMwp5NrYJZz95CV8JVuJrWMJyJrwwRnIqLTCiLBUuDVqCPdKsyV jGcdBmCvHfBzJN06+2xuGw0vfGQeH64= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-jbUt993vMpaJs7Rcvp-1ww-1; Fri, 06 Sep 2024 05:48:24 -0400 X-MC-Unique: jbUt993vMpaJs7Rcvp-1ww-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2f3fc9d8c00so18976621fa.3 for ; Fri, 06 Sep 2024 02:48:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725616102; x=1726220902; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2dOR2KW01MTjUXo6fQTElsodLv/FajDuiZrvM5ocWJE=; b=bxVsfFQUVf45AAmGYFFZQaw65e37RcOTvSXLAy/aqj5dEsVfBZ3Daw/azmOEKTS+Jx jYUt7Oe3h+SOv9BaZbottga5BmQhEigxVQCh3pzLIRRou+Sgj3Xb+zHactfqLzt3I1Rt R3bC22RA2vRCc5kBX/+0dGEfUAgAei3a80G6Pxe+ccviCLgV26tjwBJlSEMstEWqGc4D xDPiBePQxpJaWjsOpfPVD0Hp36E8nYpe3Zl5bQkSZYtxoN6kY0XO/MRo3FcZvUyNWIZh DFIyi+CKI8v3Uy6cOUw0RTwHc96ubTWvSzDIfZ8eUbBBXoB6sP5DqTrDufEJfpz7s1i1 lmcA== X-Forwarded-Encrypted: i=1; AJvYcCWBLVCWVj2+UjgD5wKGpexVyZuHhNxAeoqo96CZBdx0C6ydYqqpAlNUDjgD1ZRR464tSfA=@dpdk.org X-Gm-Message-State: AOJu0YzLoixxwickZaCGoNxPJB48kMOY6g1Hz0zZFjmR1vHkx/QKPsh7 4UW/6HfEwSgV+2HfL7JlTdOeLpxV0mtYmYYfIXZqb1eQ7mHUyQO/hyDrWWZoNf8Vl6S0kv7ihpM VJfS/hSFhZz7YMTFYrh+SYrA1ueLj7jha1+sTbUjzE+gqADQfm8eZrYeGj6xS2604rtX8dKaf8T IhVhkOxJNVXBNhjVw= X-Received: by 2002:a05:6512:3c98:b0:530:abec:9a1b with SMTP id 2adb3069b0e04-536587aabdcmr1392858e87.13.1725616102463; Fri, 06 Sep 2024 02:48:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZu7YpMWGR7dVXeuWwUTr3AB5WH6Ji2YpaUeEUW8jF6zEhwwV0gL/KDDkXO7FtxGTJCXfYkAOT8TZ4XgoWXio= X-Received: by 2002:a05:6512:3c98:b0:530:abec:9a1b with SMTP id 2adb3069b0e04-536587aabdcmr1392843e87.13.1725616101949; Fri, 06 Sep 2024 02:48:21 -0700 (PDT) MIME-Version: 1.0 References: <20240904180954.104473-1-stephen@networkplumber.org> <3e4ee7bf-842a-4f05-9c96-6ed19ed908c0@amd.com> In-Reply-To: <3e4ee7bf-842a-4f05-9c96-6ed19ed908c0@amd.com> From: David Marchand Date: Fri, 6 Sep 2024 11:48:10 +0200 Message-ID: Subject: Re: [PATCH 0/3] eal: mark API's as stable To: Ferruh Yigit Cc: Stephen Hemminger , dev@dpdk.org, Jerin Jacob Kollanukkaran , Thomas Monjalon , =?UTF-8?Q?Morten_Br=C3=B8rup?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 6, 2024 at 11:34=E2=80=AFAM Ferruh Yigit = wrote: > > On the trace API itself it should be ok. > > The problem is with the tracepoint variables themselves, and I don't > > think we should mark them stable. > > > > We cleaned tracepoint variables from ethdev map file, why they exist for > 'eal'? > > I can see .map file has bunch of "__rte_eal_trace_generic_*", I think > they exists to support 'rte_eal_trace_generic_*()' APIs which can be > called from other libraries. > > Do we really need them? > Why not whoever calls them directly call 'rte_trace_point_emit_*' instead= ? > As these rte_eal_trace_generic_*()' not used at all, I assume this is > what done already. > > @Jerin, > what do think to remove 'rte_eal_trace_generic_*()' APIs, so trace > always keeps local to library, and don't bloat the eal .map file? IIRC, we still need to export them for inline helpers. --=20 David Marchand