[dpdk-dev] [PATCH] eal: promote rte_mcfg_get_single_file_segment to stable ABI

[dpdk-dev] [PATCH] eal: promote rte_mcfg_get_single_file_segment to stable ABI

[Jakub Grajciar -X (jgrajcia - PANTHEON TECH SRO at Cisco)]

Signed-off-by: Jakub Grajciar jgrajcia@cisco.com<mailto:jgrajcia@cisco.com>
---
 doc/guides/rel_notes/release_21_11.rst | 3 +++
 lib/eal/include/rte_eal_memconfig.h    | 4 ----
 lib/eal/version.map                    | 4 +---
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst
index 675b573834..1611562f6a 100644
--- a/doc/guides/rel_notes/release_21_11.rst
+++ b/doc/guides/rel_notes/release_21_11.rst
@@ -107,6 +107,9 @@ ABI Changes
    Also, make sure to start the actual text at the margin.
    =======================================================

+* The experimental function ``rte_mcfg_get_single_file_segments`` has been
+  promoted to stable ABI.
+

 Known Issues
 ------------
diff --git a/lib/eal/include/rte_eal_memconfig.h b/lib/eal/include/rte_eal_memconfig.h
index dede2ee324..d61023d80a 100644
--- a/lib/eal/include/rte_eal_memconfig.h
+++ b/lib/eal/include/rte_eal_memconfig.h
@@ -112,13 +112,9 @@ void
 rte_mcfg_timer_unlock(void);

 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * If true, pages are put in single files (per memseg list),
  * as opposed to creating a file per page.
  */
-__rte_experimental
 bool
 rte_mcfg_get_single_file_segments(void);

diff --git a/lib/eal/version.map b/lib/eal/version.map
index beeb986adc..0cb757a1cf 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -121,6 +121,7 @@ DPDK_22 {
    rte_malloc_socket;
    rte_malloc_validate;
    rte_malloc_virt2iova;
+   rte_mcfg_get_single_file_segments;
    rte_mcfg_mem_read_lock;
    rte_mcfg_mem_read_unlock;
    rte_mcfg_mem_write_lock;
@@ -328,9 +329,6 @@ EXPERIMENTAL {
    rte_mcfg_timer_unlock;
    rte_rand_max; # WINDOWS_NO_EXPORT

-   # added in 19.11
-   rte_mcfg_get_single_file_segments;
-
    # added in 20.02
    rte_thread_is_intr;

--
2.25.1

Re: [dpdk-dev] [PATCH] eal: promote rte_mcfg_get_single_file_segment to stable ABI

[David Marchand]

Hello Jakub,

On Mon, Sep 13, 2021 at 10:44 AM Jakub Grajciar -X (jgrajcia -
PANTHEON TECH SRO at Cisco) <jgrajcia@cisco.com> wrote:
>
> Signed-off-by: Jakub Grajciar jgrajcia@cisco.com<mailto:jgrajcia@cisco.com>

Anatoly already sent a patch for this symbol:
https://patchwork.dpdk.org/project/dpdk/patch/37d174136f8f8dcaa47f875e196bf2d9ec7d5228.1631277001.git.anatoly.burakov@intel.com/

I marked your patch as rejected and I'll merge Anatoly series.
Thanks.


-- 
David Marchand