Re: [PATCH] build: remove obsolete compiler checks

[David Marchand <david.marchand@redhat.com>]

On Fri, Jul 18, 2025 at 2:14 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> DPDK now recommends compiler versions GCC 8+, and Clang 7+, so remove
> checks and workarounds for versions old than these.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  config/meson.build                  |  5 ----
>  drivers/event/meson.build           |  5 +---
>  drivers/meson.build                 |  2 +-
>  drivers/net/virtio/meson.build      |  2 +-
>  lib/eal/arm/include/rte_memcpy_64.h |  8 -------
>  lib/eal/arm/include/rte_vect.h      | 37 ++---------------------------
>  lib/eal/ppc/include/rte_altivec.h   |  1 -
>  lib/meson.build                     |  2 +-
>  lib/vhost/meson.build               |  4 ++--
>  lib/vhost/vhost.c                   | 16 -------------
>  10 files changed, 8 insertions(+), 74 deletions(-)

Two nits:

[snip]

> diff --git a/drivers/event/meson.build b/drivers/event/meson.build
> index d6706b57f7..b0bc3f40f1 100644
> --- a/drivers/event/meson.build
> +++ b/drivers/event/meson.build
> @@ -14,9 +14,6 @@ drivers = [
>          'opdl',
>          'skeleton',
>          'sw',
> +        'octeontx',
>  ]

Sort alphabetically?


> -if not (toolchain == 'gcc' and cc.version().version_compare('<4.8.6') and
> -        dpdk_conf.has('RTE_ARCH_ARM64'))
> -    drivers += 'octeontx'
> -endif
>  std_deps = ['eventdev', 'kvargs']

[snip]

> diff --git a/lib/eal/arm/include/rte_memcpy_64.h b/lib/eal/arm/include/rte_memcpy_64.h
> index 90039039be..57fe24eb10 100644
> --- a/lib/eal/arm/include/rte_memcpy_64.h
> +++ b/lib/eal/arm/include/rte_memcpy_64.h
> @@ -89,14 +89,6 @@ n <= (size_t)RTE_ARM64_MEMCPY_UNALIGNED_THRESHOLD)
>   **************************************/
>
>
> -#if RTE_CC_IS_GNU && !defined RTE_ARM64_MEMCPY_SKIP_GCC_VER_CHECK
> -#if (GCC_VERSION < 50400)
> -#warning "The GCC version is quite old, which may result in sub-optimal \
> -performance of the compiled code. It is suggested that at least GCC 5.4.0 \
> -be used."
> -#endif
> -#endif
> -

This flag can be removed from meson too.
config/arm/meson.build:        #
['RTE_ARM64_MEMCPY_SKIP_GCC_VER_CHECK', false],


>  static __rte_always_inline
>  void rte_mov16(uint8_t *dst, const uint8_t *src)
>  {


-- 
David Marchand