Re: [PATCH v1 00/42] Merge Intel IGC and E1000 drivers, and update E1000 base code

[David Marchand <david.marchand@redhat.com>]

On Fri, Jan 31, 2025 at 2:12 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Fri, Jan 31, 2025 at 12:58:13PM +0000, Anatoly Burakov wrote:
> > Intel IGC and E1000 drivers are distinct, but they are actually generated
> > from the same base code. This patchset will merge together all e1000-derived
> > drivers into one common base, with three different ethdev driver
> > frontends (EM, IGB, and IGC).
> >
> > After the merge is done, base code is also updated to latest snapshot.
> >
> <snip>
> >  drivers/net/intel/e1000/base/README           |    8 +-
> >  .../net/intel/e1000/base/e1000_80003es2lan.c  |   10 +-
> >  drivers/net/intel/e1000/base/e1000_82571.c    |    4 +-
> <snip>
> >  drivers/net/intel/igc/base/igc_phy.c          | 4420 -----------------
> >  drivers/net/intel/igc/base/igc_phy.h          |  337 --
> >  drivers/net/intel/igc/base/igc_regs.h         |  732 ---
> >  drivers/net/intel/igc/base/meson.build        |   19 -
> >  drivers/net/intel/igc/igc_logs.h              |   43 -
> >  drivers/net/intel/igc/meson.build             |   21 -
> >  drivers/net/meson.build                       |    1 -
> >  64 files changed, 3300 insertions(+), 18218 deletions(-)
>
> And I thought my deduplication patchset was good, cutting the codebase down
> by 1000 lines! Shame you couldn't quite get it to a 15000 line even
> reduction - 14,918 lines just doesn't have that same ring about it! :-)

Now, the question is how many bugs sneaked in respectively those two
cleanups ;-).


-- 
David Marchand