From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC26AA0C4E; Sat, 23 Oct 2021 12:20:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E4E14069D; Sat, 23 Oct 2021 12:20:59 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 92C0040041 for ; Sat, 23 Oct 2021 12:20:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634984457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GxF38Rau8TG659m98Y5EhRgXr7BeILS/puk2Ia8h5vs=; b=IrFyouBU92zrbl8/DrDkPIvVXuqFjnlE4+d2eYmqXqxx4XsNe1NQ/spQos8KITtmG/1qdH vC3r8HjSYZLtbYU2uGSKadHebm1YZJN/+9pg99cSHEb2xN8JtPcvIRKFPLuGc6iDfn3lDU a+JItfsD8CvM2dspH+7dLCoJF9eYSbM= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-594-5AsrxC0_PqOjMSxwVOCPxQ-1; Sat, 23 Oct 2021 06:20:54 -0400 X-MC-Unique: 5AsrxC0_PqOjMSxwVOCPxQ-1 Received: by mail-lf1-f72.google.com with SMTP id z29-20020a195e5d000000b003fd437f0e07so3029056lfi.20 for ; Sat, 23 Oct 2021 03:20:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GxF38Rau8TG659m98Y5EhRgXr7BeILS/puk2Ia8h5vs=; b=VZn0hmm9mGtcI7TBW3kZktWFDadOKUuK1ttpbR+9QAra/88gNNHf6HwalcFGlIY83V KHzNG4hyPMg2iF00qomrofHB+IEIfAaa/fvZYmUVsWRXQmKN0UX5Ld/RZnmXEke3TGBd fEmJJc41guZ5bCdI68vrsrqkB1wbW0qSn0NKGxiNlzVnhf+/Lr//hlWzloUZ7XQLSDI4 R3dUgSXMSlB1uWKdNL6eQ2Fk8ia+J53XG1B9XbU8geYPO09cx12vxybbv7V1zmgYgDw6 zgl7+mjAMx3s77c+2Qd5YN5C7jLnV90MHrFnZSZUALScB7tLodzRQ7S7Fen3Lw7Hqs6e ou7w== X-Gm-Message-State: AOAM531NjD9Rrn+KZv8FFS2LWiJqLw2A2aS3ESufrSmwJ8HmvtaJjOqM r3JZ3vRTGm5ed523NW1uMRgk3ibK9HtUxVPklJpuIKp59yJOoKmhf+gvtrr/ftY/D70Lj1u4NpA z2aLn6hFzuKO+qt8aO2k= X-Received: by 2002:a2e:8e34:: with SMTP id r20mr5592533ljk.333.1634984453410; Sat, 23 Oct 2021 03:20:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzmXk6f79RmfCzdO1M2JdnwdcHfn9GDikviVW8cc44zeGcjq2nzwIjt0NVkLP9TFsyeyLHOsVF2Xc86X7AEkd0= X-Received: by 2002:a2e:8e34:: with SMTP id r20mr5592507ljk.333.1634984453231; Sat, 23 Oct 2021 03:20:53 -0700 (PDT) MIME-Version: 1.0 References: <20211023065558.818-1-david.marchand@redhat.com> <20211023113757.728b2e32@sovereign> In-Reply-To: <20211023113757.728b2e32@sovereign> From: David Marchand Date: Sat, 23 Oct 2021 12:20:42 +0200 Message-ID: To: Dmitry Kozlyuk Cc: dev , Thomas Monjalon , Bruce Richardson , Kevin Laatz , Chengwen Feng , Conor Walsh Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] dma/idxd: fix build on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Oct 23, 2021 at 10:38 AM Dmitry Kozlyuk wrote: > > 2021-10-23 08:55 (UTC+0200), David Marchand: > > Windows compilation gives us a splat: > > In file included from ../drivers/dma/idxd/idxd_pci.c:10: > > In file included from ..\drivers\dma\idxd/idxd_internal.h:11: > > ..\drivers\dma\idxd/idxd_hw_defs.h:46:21: error: expected member name or > > ';' after declaration specifiers > > uint16_t __reserved[13]; > > ~~~~~~~~ ^ > > 1 error generated. > > > > Ironically, __reserved is probably a reserved token. > > Yes, and it's used in system headers for static analyzer annotations: > https://docs.microsoft.com/en-us/windows/win32/winprog/header-annotations#advanced-annotations Thanks for confirming. -- David Marchand