From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8FAA43006; Tue, 8 Aug 2023 09:43:42 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C7E643247; Tue, 8 Aug 2023 09:43:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8FE7240A87 for ; Tue, 8 Aug 2023 09:43:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691480620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ruehSpxLpHnV1HvUFQpXcDFYLw4co/k3ftnFZDk9gGw=; b=PI0sJLZSUn91F6AYVeasv9p+Uxd21tATWVHPwvVGBzE9KzFoHB3XaUAqfFey3PSbWbSi6R kZFt16F7PON0RxUAaa1T5Wl30pBPS/84sLpXMKNYX16NS61j5TiDza2gt1JkQQ0hKPPdr0 3xcMQd2Z3ms7BEIZ//G21zCKyDpRRj4= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-7hOFlGhrPw6TSG3J-_6txg-1; Tue, 08 Aug 2023 03:43:38 -0400 X-MC-Unique: 7hOFlGhrPw6TSG3J-_6txg-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-4fe08579d93so5139325e87.1 for ; Tue, 08 Aug 2023 00:43:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691480617; x=1692085417; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ruehSpxLpHnV1HvUFQpXcDFYLw4co/k3ftnFZDk9gGw=; b=AAhh6277+piBNLga9p/PnxpDnrJpfinAfHz5BebrQe+zqoprkxpvssPbo58u2UU/cK aKbipUvmUzqrDU2rcnMm5ToW7IMdQ80JX5DVmpYTTcu9ZJn4AiWHgGF/lYp15Vr4tce2 2vvUgfjXXZnojxpkQsQSI1ay0v5c4ivYIN/SDdQDyEQKeOqdTMGsKWcNJav7mQTHe3mk bjndrY91wYyICBRgho2Q38kl+iZU3h+UNSbZ1npHWsVshzUUW1S9Z1Yi0A74u4/GPqr5 pX6Kd3b3q9uC45GE8cS1Rowxo/9zEwC3WUUzGpWrPanFwvC5lXQpCqVma927cn/toxda 4POg== X-Gm-Message-State: AOJu0YyRuxbBpyRgZRquRqzwv/kqnxIrFovJe5CBX2iCUDAIjZ6M8P3/ VwoC3yblHnzQlqCJw615UHwsQJKXM9Rr6bq9VL/ihk11xZRAUZ3nXuN3bFIst9LgSucK7+Bk9Ns aGWqcxt+x2Yx3aST1HcM= X-Received: by 2002:a05:6512:3e29:b0:4fe:4e2c:8e52 with SMTP id i41-20020a0565123e2900b004fe4e2c8e52mr4184001lfv.42.1691480617427; Tue, 08 Aug 2023 00:43:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGFNJcj804Qaby8Uiiph0BSAwIHq+v36aFEMCqSvrOLoFc/Wrja0W7g93K/NMPQ4EYhIRJ0gy1TOwZNL8NsfKs= X-Received: by 2002:a05:6512:3e29:b0:4fe:4e2c:8e52 with SMTP id i41-20020a0565123e2900b004fe4e2c8e52mr4183990lfv.42.1691480617120; Tue, 08 Aug 2023 00:43:37 -0700 (PDT) MIME-Version: 1.0 References: <20230801085253.2447095-1-david.marchand@redhat.com> <20230801134133.2860104-1-david.marchand@redhat.com> In-Reply-To: <20230801134133.2860104-1-david.marchand@redhat.com> From: David Marchand Date: Tue, 8 Aug 2023 09:43:25 +0200 Message-ID: Subject: Re: [PATCH v2] build: check drivers class dependencies early To: David Marchand , bruce.richardson@intel.com Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Tyler Retzlaff X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Aug 1, 2023 at 3:41=E2=80=AFPM David Marchand wrote: > > Drivers implementing a class of devices (for example, drivers/event) > depend on the associated abstraction library (lib/eventdev). > This dependency is expressed in the top level meson.build for this class > (drivers/event/meson.build). > > As we are making more libraries optional, custom constructs referencing > the class dependencies in some drivers meson.build (event/dlb2) may break= . > > It would be possible to add more checks in those drivers meson.build but > it is more straightforward to not even consider a driver meson.build when > the class dependencies are not met. > > Signed-off-by: David Marchand > Acked-by: Morten Br=C3=B8rup Acked-by: Bruce Richardson Acked-by: Tyler Retzlaff Applied, thanks. Bruce, could you rebase your series marking more libraries optional? There is some conflicts after removal of kni/flow_classify, and adding a unit test (perf reasm). --=20 David Marchand