From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by dpdk.org (Postfix) with ESMTP id 3CD695B16 for ; Wed, 20 Mar 2019 13:44:51 +0100 (CET) Received: by mail-vs1-f53.google.com with SMTP id e1so1380801vsp.2 for ; Wed, 20 Mar 2019 05:44:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZjFBoc7I6yEdNQLv8RtM/SmeJv8VmbH2bdGkU3HW010=; b=bIl+wXh2E9tNatltJrbiQSx6BCuRoaX9NLGtpKW7zzdDRUWqBTpVua5gpRSTMLn/Wc NvAHcCGxYNbuEM55BRPuq2EvFcZ3LJGanXLvb6gPze51lIki/Vd+eJkb+KMzxbXJKgUl oy4geZADLlAzWFsRqSudIaTcvbZZxjCx4tXS2lWyZCEAKaHO/5beJfNyJcQp6OGbLdAI CMX0lOvbJH7G0DM524yHEQidOVrp/oOJefacvfdPXFpFKEk7qTU9QwV7983C930uacbq GPpNjH8+0WvhCRVpOVHWTtWAmJLnLMPq38oX8xjVV3ZuOuHIY5ZFpf+oAHzACqyV6ktu Q3UA== X-Gm-Message-State: APjAAAUepz+krvLOLZfWpMjiDwz3FzraYAzJgQmb4irK7ItGK2wSq/uF Fm5w9R8ARLhAH3NcrpY4CgpKophlFbcXbevPXL9UYg== X-Google-Smtp-Source: APXvYqwCFO+SmKAhLlE8d3VoaAnXdj66Ddd95yXhs+gey4xu+MOxk/tXkPxdefQYy9l3LlYSU0oe04QQYXBXjXJNFsE= X-Received: by 2002:a67:f69a:: with SMTP id n26mr4764523vso.105.1553085890603; Wed, 20 Mar 2019 05:44:50 -0700 (PDT) MIME-Version: 1.0 References: <1552318522-18777-1-git-send-email-david.marchand@redhat.com> <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553076154-3907-5-git-send-email-david.marchand@redhat.com> <48cc01e4-08fe-40b2-cbe6-86db8bc9110e@intel.com> In-Reply-To: <48cc01e4-08fe-40b2-cbe6-86db8bc9110e@intel.com> From: David Marchand Date: Wed, 20 Mar 2019 13:44:39 +0100 Message-ID: To: Ferruh Yigit Cc: dev , Wenzhuo Lu , Jingjing Wu , "Iremonger, Bernard" , Rami Rosen , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: display/clear forwarding stats on demand X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2019 12:44:51 -0000 On Wed, Mar 20, 2019 at 1:25 PM Ferruh Yigit wrote: > On 3/20/2019 10:02 AM, David Marchand wrote: > > Add a new "show/clear fwd stats all" command to display fwd and port > > statistics on the fly. > > Won't this be duplicating existing commands: > "show port stats all|" > "clear port stats all|" > > What benefit "show/clear fwd stats all" adds against existing ones? > Forwarding engines like "iofwd" maintain software statistics like "fwd_dropped" which gives you how much of the packets to be transmitted could not make it to the "wire". "show port stats" won't give you those stats. You could stop/start the forwarding to get them, but when debugging you most likely do not want to stop the forwarding. I have been using this while tracking drops in a PVP setup. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 65AD5A00E6 for ; Wed, 20 Mar 2019 13:44:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 703495B2A; Wed, 20 Mar 2019 13:44:53 +0100 (CET) Received: from mail-vs1-f53.google.com (mail-vs1-f53.google.com [209.85.217.53]) by dpdk.org (Postfix) with ESMTP id 3CD695B16 for ; Wed, 20 Mar 2019 13:44:51 +0100 (CET) Received: by mail-vs1-f53.google.com with SMTP id e1so1380801vsp.2 for ; Wed, 20 Mar 2019 05:44:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZjFBoc7I6yEdNQLv8RtM/SmeJv8VmbH2bdGkU3HW010=; b=bIl+wXh2E9tNatltJrbiQSx6BCuRoaX9NLGtpKW7zzdDRUWqBTpVua5gpRSTMLn/Wc NvAHcCGxYNbuEM55BRPuq2EvFcZ3LJGanXLvb6gPze51lIki/Vd+eJkb+KMzxbXJKgUl oy4geZADLlAzWFsRqSudIaTcvbZZxjCx4tXS2lWyZCEAKaHO/5beJfNyJcQp6OGbLdAI CMX0lOvbJH7G0DM524yHEQidOVrp/oOJefacvfdPXFpFKEk7qTU9QwV7983C930uacbq GPpNjH8+0WvhCRVpOVHWTtWAmJLnLMPq38oX8xjVV3ZuOuHIY5ZFpf+oAHzACqyV6ktu Q3UA== X-Gm-Message-State: APjAAAUepz+krvLOLZfWpMjiDwz3FzraYAzJgQmb4irK7ItGK2wSq/uF Fm5w9R8ARLhAH3NcrpY4CgpKophlFbcXbevPXL9UYg== X-Google-Smtp-Source: APXvYqwCFO+SmKAhLlE8d3VoaAnXdj66Ddd95yXhs+gey4xu+MOxk/tXkPxdefQYy9l3LlYSU0oe04QQYXBXjXJNFsE= X-Received: by 2002:a67:f69a:: with SMTP id n26mr4764523vso.105.1553085890603; Wed, 20 Mar 2019 05:44:50 -0700 (PDT) MIME-Version: 1.0 References: <1552318522-18777-1-git-send-email-david.marchand@redhat.com> <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553076154-3907-5-git-send-email-david.marchand@redhat.com> <48cc01e4-08fe-40b2-cbe6-86db8bc9110e@intel.com> In-Reply-To: <48cc01e4-08fe-40b2-cbe6-86db8bc9110e@intel.com> From: David Marchand Date: Wed, 20 Mar 2019 13:44:39 +0100 Message-ID: To: Ferruh Yigit Cc: dev , Wenzhuo Lu , Jingjing Wu , "Iremonger, Bernard" , Rami Rosen , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 4/4] app/testpmd: display/clear forwarding stats on demand X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190320124439.L4Ltj1G4xeu69gc6hV9l-Rhy9xuf6bIAxKWIFuLC3Qo@z> On Wed, Mar 20, 2019 at 1:25 PM Ferruh Yigit wrote: > On 3/20/2019 10:02 AM, David Marchand wrote: > > Add a new "show/clear fwd stats all" command to display fwd and port > > statistics on the fly. > > Won't this be duplicating existing commands: > "show port stats all|" > "clear port stats all|" > > What benefit "show/clear fwd stats all" adds against existing ones? > Forwarding engines like "iofwd" maintain software statistics like "fwd_dropped" which gives you how much of the packets to be transmitted could not make it to the "wire". "show port stats" won't give you those stats. You could stop/start the forwarding to get them, but when debugging you most likely do not want to stop the forwarding. I have been using this while tracking drops in a PVP setup. -- David Marchand