From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A3BA45CA0; Thu, 7 Nov 2024 14:01:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4879D4060A; Thu, 7 Nov 2024 14:01:02 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3274B402AC for ; Thu, 7 Nov 2024 14:01:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730984460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TWbvMB/GmyMKm8J0jrspWxi25dMdxi8JQkvySpzyXFQ=; b=WqOzuD3tVBkA1O0Xbw1W8lv3/QBNA8YCXwUz7Wqfhd7fzsCizXr4t5FwPKqdAV8zLDlpPU 5GxLd3d7kGP/sJlr6z3O4veV/JFoD1wPHWaHTZNUqkemp2pQq4KTK5WdepqU+G1xrQ2F7L Z6hIOvIu6UENrTQV4liFJB2v+jO4lYA= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-mXBjzqHHMzC5bDmbRK-tyw-1; Thu, 07 Nov 2024 08:00:54 -0500 X-MC-Unique: mXBjzqHHMzC5bDmbRK-tyw-1 X-Mimecast-MFC-AGG-ID: mXBjzqHHMzC5bDmbRK-tyw Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2fb51681ac6so5372631fa.1 for ; Thu, 07 Nov 2024 05:00:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730984453; x=1731589253; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TWbvMB/GmyMKm8J0jrspWxi25dMdxi8JQkvySpzyXFQ=; b=ao3bp251cdSLYOs4rgn7frACIkYKmC/dUQkiur4VDFWMSHz/JYCxCA1CWGO4ABFHLh hFh7Z1mJfz0YfCfsrPYf0i+6LpEzd5PJ4hwX7ulkXNQq39mQMFtTgp74VS8KSjqUSuwP AZzFfO44puvTpL6Sc0LA4kJzicxsrtVaReeuxCE/nQgq3c6dY069wqC76Xukr9nQsFse fYoeFmQUlTkSaVy5NRVUsC/FSCeB5cHiIc4JqLA323ezznIM4cbJ+craYBP9/CZkTxT9 VXP6TZ5CdXqXYJ83pDDQg9m/HQ4WCGqXtQJeFsZpogZlfP6wzA6PpIQYtEFSuK2+KFX/ ktyA== X-Gm-Message-State: AOJu0Yz6daSiWwhrQy/280iCEkMrIMYSPTxK4i9VHmL4OsweBAZMdF0i obZ1oRdDIEErT5BnqiAZwBjp7QkdoovMUEowJII8WZG/xJT8+ZDn+i9r4xpT5ywen+TgdIT3b+J dYhvKkk18Ue4J9SFZSXfDEtnTjrgJPQ7w2Oxf+SZ02USQr/qUSFI2mAeTLzn6F/+PKvVMC8K24d qjh8dhWVNwfbJlTE8= X-Received: by 2002:a2e:be88:0:b0:2fb:510c:7203 with SMTP id 38308e7fff4ca-2ff1b855bbemr4474071fa.3.1730984452904; Thu, 07 Nov 2024 05:00:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IEFmFSGQasIsxJ0BiW33rOJyF2S+P7RWFa25nagyqhMWkoWKz7Ax4V2klNPHBBT+kOZeV7vR2RV0yluXHs0Wxk= X-Received: by 2002:a2e:be88:0:b0:2fb:510c:7203 with SMTP id 38308e7fff4ca-2ff1b855bbemr4473361fa.3.1730984451212; Thu, 07 Nov 2024 05:00:51 -0800 (PST) MIME-Version: 1.0 References: <20241016184209.802449-1-vladimir.medvedkin@intel.com> In-Reply-To: <20241016184209.802449-1-vladimir.medvedkin@intel.com> From: David Marchand Date: Thu, 7 Nov 2024 14:00:40 +0100 Message-ID: Subject: Re: [PATCH] test/fib: clarify FIB RCU negative tests To: Vladimir Medvedkin Cc: dev@dpdk.org, stephen@networkplumber.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nGp2Q0ekdCXGkgsxHN43jvs6P4IoTVXGwYeATwXYXeE_1730984453 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 16, 2024 at 8:42=E2=80=AFPM Vladimir Medvedkin wrote: > @@ -445,7 +454,7 @@ test_invalid_rcu(void) > rcu_cfg.v =3D qsv2; > rcu_cfg.mode =3D RTE_FIB_QSBR_MODE_SYNC; > status =3D rte_fib_rcu_qsbr_add(fib, &rcu_cfg); > - RTE_TEST_ASSERT(status !=3D 0, "Secondary RCU was mistakenly atta= ched\n"); > + RTE_TEST_ASSERT(status =3D -EEXIST, "Secondary RCU was mistakenly= attached\n"); My eyes stopped on this. Should be =3D=3D right? > > rte_fib_free(fib); > rte_free(qsv); --=20 David Marchand