* [dpdk-dev] [PATCH] app/testpmd: remove warning on flex flow flush
@ 2021-11-02 18:38 David Marchand
2021-11-02 19:39 ` Gregory Etelson
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2021-11-02 18:38 UTC (permalink / raw)
To: dev; +Cc: getelson, ferruh.yigit, thomas, Xiaoyun Li, Viacheslav Ovsiienko
Building DPDK without JSON, warnings get displayed when stopping testpmd
without entering any flex flow rule.
Fixes: 59f3a8acbcdb ("app/testpmd: add flex item commands")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
app/test-pmd/cmd_flex_item.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/app/test-pmd/cmd_flex_item.c b/app/test-pmd/cmd_flex_item.c
index 45103e45a8..337dcdd565 100644
--- a/app/test-pmd/cmd_flex_item.c
+++ b/app/test-pmd/cmd_flex_item.c
@@ -415,6 +415,8 @@ port_flex_item_flush(portid_t port_id)
uint16_t i;
for (i = 0; i < FLEX_MAX_PARSERS_NUM; i++) {
+ if (flex_items[port_id][i] == NULL)
+ continue;
flex_item_destroy(port_id, i);
flex_items[port_id][i] = NULL;
}
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: remove warning on flex flow flush
2021-11-02 18:38 [dpdk-dev] [PATCH] app/testpmd: remove warning on flex flow flush David Marchand
@ 2021-11-02 19:39 ` Gregory Etelson
2021-11-02 19:44 ` David Marchand
0 siblings, 1 reply; 3+ messages in thread
From: Gregory Etelson @ 2021-11-02 19:39 UTC (permalink / raw)
To: David Marchand, dev
Cc: ferruh.yigit, NBU-Contact-Thomas Monjalon, Xiaoyun Li, Slava Ovsiienko
Hello,
I posted a patch for that issue in
https://patchwork.dpdk.org/project/dpdk/patch/20211026152000.11665-1-getelson@nvidia.com/
Regards,
Gregory
> -----Original Message-----
> From: David Marchand
> <david.marchand@redhat.com>
> Sent: Tuesday, November 2, 2021 20:39
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>;
> ferruh.yigit@intel.com; NBU-Contact-Thomas
> Monjalon <thomas@monjalon.net>; Xiaoyun Li
> <xiaoyun.li@intel.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Subject: [PATCH] app/testpmd: remove warning
> on flex flow flush
>
> External email: Use caution opening links or
> attachments
>
>
> Building DPDK without JSON, warnings get
> displayed when stopping testpmd
> without entering any flex flow rule.
>
> Fixes: 59f3a8acbcdb ("app/testpmd: add flex
> item commands")
>
> Signed-off-by: David Marchand
> <david.marchand@redhat.com>
> ---
> app/test-pmd/cmd_flex_item.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/app/test-pmd/cmd_flex_item.c
> b/app/test-pmd/cmd_flex_item.c
> index 45103e45a8..337dcdd565 100644
> --- a/app/test-pmd/cmd_flex_item.c
> +++ b/app/test-pmd/cmd_flex_item.c
> @@ -415,6 +415,8 @@
> port_flex_item_flush(portid_t port_id)
> uint16_t i;
>
> for (i = 0; i < FLEX_MAX_PARSERS_NUM;
> i++) {
> + if (flex_items[port_id][i] == NULL)
> + continue;
> flex_item_destroy(port_id, i);
> flex_items[port_id][i] = NULL;
> }
> --
> 2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: remove warning on flex flow flush
2021-11-02 19:39 ` Gregory Etelson
@ 2021-11-02 19:44 ` David Marchand
0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2021-11-02 19:44 UTC (permalink / raw)
To: Gregory Etelson
Cc: dev, ferruh.yigit, NBU-Contact-Thomas Monjalon, Xiaoyun Li,
Slava Ovsiienko
On Tue, Nov 2, 2021 at 8:40 PM Gregory Etelson <getelson@nvidia.com> wrote:
> I posted a patch for that issue in
> https://patchwork.dpdk.org/project/dpdk/patch/20211026152000.11665-1-getelson@nvidia.com/
Ok cool, withdrawing my patch.
--
David Marchand
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-11-02 19:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-02 18:38 [dpdk-dev] [PATCH] app/testpmd: remove warning on flex flow flush David Marchand
2021-11-02 19:39 ` Gregory Etelson
2021-11-02 19:44 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).