From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE37CA04DD; Tue, 26 Nov 2019 17:28:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1BF242B96; Tue, 26 Nov 2019 17:28:01 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 7985FA3 for ; Tue, 26 Nov 2019 17:27:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574785678; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=w3UEIK1QD79dJ3BriUFVrvtzQ2Mdedt2gwFtwXJOmlc=; b=How1GeBqJoGoRd1NgoTMKu+NxKQZQI7AEBSqK+j1E/nD5EUI/oK/gv6CSMzS+EEaV5N+Bn SW7cEwSVRE9e4K5OsJu8fcTREK7yS39Har4uW2WAtLC5HEvNxTTsNrB4p/UH5bPk+KNvVg zD/8pp+tTvDu4RpuKA9J4qbBQeiATYY= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-241--oQN1hvCP0q__fX2P17R5Q-1; Tue, 26 Nov 2019 11:27:54 -0500 Received: by mail-ua1-f71.google.com with SMTP id t2so3364410uap.6 for ; Tue, 26 Nov 2019 08:27:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D6OZzKNnGtZ7liZPR2PJhyNMBVHIsk3BUDzPJM5nEjA=; b=LAP8l7qOR62TTbo+R+R9dXmv8V3lFK67hqHaoa/uocvzXk2upkVhlFM75BqzZ7Q3h+ ovWZNBQDYbyjOzQcOHqOOhVelG4Lk1JbSqIxCxpGApDX5u42mubjF3CSVw9wHkxxyFdW IxUFLxYzrlpFm/Klw/ouvRdQT1rJmF2f3IanU5vrfuBAK+UBUwZq75NjGe7kWi8AbYFm tGQ7PEQYbS+hSd4LgjNSYLJyRY/O+NoHh+yKSqXvknQy1aNQ4iNgkjkbRdifmFaQWNG9 6awLGn4QoV1Rpcfcz0/QDsVGRxuNzVpzh+KRLqSzlC0bfOBSYNEnhjGMZH8fzvBF8bWi Ljpw== X-Gm-Message-State: APjAAAWezwkmMiWOEHrAQ2bvLjgsvX3nUZ32Ulc7CPq2joPa/B9rJjO9 dNeK44SL6i0bsZgjPF+/yifKGMtzaRK64seTrAruBZl+7UHiri0XY3YiwGeFPBreh9PK2ErpI3Y kP53rX3jG9t3nVfi3xdI= X-Received: by 2002:ab0:48ab:: with SMTP id x40mr22514917uac.126.1574785673792; Tue, 26 Nov 2019 08:27:53 -0800 (PST) X-Google-Smtp-Source: APXvYqy3XSc4kbckcVwl6oBlD70HqQPCZuyxmetKNJPWCyeaOg8FhmhUkYQu23mdKtEpPFVBuI3SUFCv6oOgEir5XYk= X-Received: by 2002:ab0:48ab:: with SMTP id x40mr22514889uac.126.1574785673321; Tue, 26 Nov 2019 08:27:53 -0800 (PST) MIME-Version: 1.0 References: <20191125152303.68461-1-bruce.richardson@intel.com> <20191125162316.GA1615@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20191125162316.GA1615@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Tue, 26 Nov 2019 17:27:42 +0100 Message-ID: To: Bruce Richardson Cc: dev X-MC-Unique: -oQN1hvCP0q__fX2P17R5Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] examples/ioat: handle failure case for ioat dequeue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 25, 2019 at 5:23 PM Bruce Richardson wrote: > > On Mon, Nov 25, 2019 at 03:23:03PM +0000, Bruce Richardson wrote: > > On a failure with the ioat dequeue, -1 is returned, which was not prope= rly > > handled. This could lead to out-of-bounds reads on a later loop which > > assumed a positive return value. Fix this by treating an error as thoug= h a > > dequeue of 0 had been encountered. > > > > Coverity issue: 350342 > FYI: also should fix issue: 350349 > > > Fixes: 2328542ed84e ("examples/ioat: add rawdev copy mode") > > > > Signed-off-by: Bruce Richardson Applied, thanks. -- David Marchand