From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7500A0C45; Wed, 20 Oct 2021 09:53:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B274B40150; Wed, 20 Oct 2021 09:53:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2C0BA40142 for ; Wed, 20 Oct 2021 09:53:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634716432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ro6h3T/lQOjPHEpMG4zrngV+yFbI3CW+h4zqE2wIUUc=; b=MnEdn9UrXUity+miVrKG5GEjds5mxDel44F40DhSuIDWHMN4a4qAUk7JxS3IgyxTO2Jaba nttKDIMLd+1Q2FrH/nJozjI1TPjvR1GFc6U5NxRoTA/pYikLPITPHaEvwP9IuvN5Zim4r7 PnFB7E8jzABasQgSzVKMkKxuA6D8/AA= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-BbbWB566NxiFTHmNZwwKXA-1; Wed, 20 Oct 2021 03:53:49 -0400 X-MC-Unique: BbbWB566NxiFTHmNZwwKXA-1 Received: by mail-lf1-f70.google.com with SMTP id br42-20020a056512402a00b003fd94a74905so2783504lfb.7 for ; Wed, 20 Oct 2021 00:53:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ro6h3T/lQOjPHEpMG4zrngV+yFbI3CW+h4zqE2wIUUc=; b=nagMHQtEKcTaSo6QQX6dxyvLnBIiCVlqlZYMGbTOpu+jYnkTiMZh3SXghy/PSGoGru ZqRt10qehWRFJ5bQ/Lx3JFxhrNxZUq85CRLT1BrxT4pOZSNF+wvJr+X1jwI0q6kkXnti eD2OS2k39PhU2S1IGNJdsJh+L9Es0lp3H2XEVPx702CogxyPp6NI/Psw/7N5J4pjklLr fUzudvLUhML9Oc97Feii3t3LJyuCrHDTIAeI3igikr1bHE74eZumuAkP1l3jWZ+EEaUH 7gMnQ3MtAxpkmhcU53Wu0gFcH0g6NM+AtS+N0IHSIoqqtlKQNRuIkWFFw+6yXeY4E7Ip 7VMw== X-Gm-Message-State: AOAM531FucluN8q2lPtwIlHxWle/WTcnNtplSrkG4s2bnR4zDmpMWW9D DZTVKE9VsaXR/CSXOfJGHbS1O+txlmSkiBixEE97HFFJWj65lokOAMNMCkacjhH7MIzCoiGO7as mW4QNtjSzLlsy0bKUqnw= X-Received: by 2002:a05:6512:a8e:: with SMTP id m14mr10644584lfu.575.1634716427526; Wed, 20 Oct 2021 00:53:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyONa4oVxQcnPFrRYZMHqrsD2V2d3VsLmBYXVOFKd5QJ+J8xWCGQhUWEWQEuiTBteHsk0XNacy1j7qncoRvPto= X-Received: by 2002:a05:6512:a8e:: with SMTP id m14mr10644574lfu.575.1634716427373; Wed, 20 Oct 2021 00:53:47 -0700 (PDT) MIME-Version: 1.0 References: <20211018082635.2054-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Wed, 20 Oct 2021 09:53:36 +0200 Message-ID: To: Olivier Matz , Andrew Rybchenko Cc: dev , Dmitry Kozlyuk , Ray Kinsella , Stephen Hemminger Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] mempool: accept user flags only X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 18, 2021 at 10:36 AM Olivier Matz wrote: > > On Mon, Oct 18, 2021 at 10:26:35AM +0200, David Marchand wrote: > > As reported by Dmitry, MEMPOOL_F_POOL_CREATED is a flag only manipulated > > internally. > > This flag is not supposed to be requested from an application and would > > probably result in an incorrect behavior if an application did pass it. > > > > Other internal flags may be introduced later. > > > > Rework the check and export a mask of valid user flags for use in the > > unit test. > > > > Fixes: b240af8b10f9 ("mempool: enforce valid flags at creation") > > > > Reported-by: Dmitry Kozlyuk > > Signed-off-by: David Marchand > Acked-by: Olivier Matz Acked-by: Andrew Rybchenko Rebased on top of mempool cleanup series, and applied. Thanks. -- David Marchand