From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 404E845B51; Wed, 16 Oct 2024 10:40:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3079640273; Wed, 16 Oct 2024 10:40:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 33E4040144 for ; Wed, 16 Oct 2024 10:40:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729068002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DpnXEqmhIkwzDf8a1gHTFidXDD1QnBBIdU0pBSVkl3s=; b=N5lSqV+uPqHn6AvTYLOMtmb/RVhYtM/KOZaE4vN/Gast8LMbecervWSd40aw37gwkQrmVj 4m+yNsvQgSWrxLw78uIad0uuQ8locfei8O8c6VsRkFdU/itEfKPuSthQ8VkX5MYmr8m+/g Z8Wo1u4qj3j9A8b8e8xbIzBNvzjk2wQ= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-yXPCDGMoP2SFyc0opPqnEg-1; Wed, 16 Oct 2024 04:40:01 -0400 X-MC-Unique: yXPCDGMoP2SFyc0opPqnEg-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-539e4b7c8f4so4378385e87.1 for ; Wed, 16 Oct 2024 01:40:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729068000; x=1729672800; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DpnXEqmhIkwzDf8a1gHTFidXDD1QnBBIdU0pBSVkl3s=; b=Cxjch/aHh9bpLeththlerpAhH1TULhrpIpKC5foBT1D/xh2OkNur9V9TGDJrQCz1wX CXDwkKV877SMpPkWNcxCPPzXBJc66Micxp9uW9ZwCv6kEMv5pqDqproB+HDPsGAE/EaP z/ModZ93BqYQG1H42WxuXtU31JRvrZ0idz8inDl33Aecbfn7Ge8rryzUyMqMDguQWBfy 14G5vKNmysR7x71ymqqK+XPNIRsovf3O9hl/Gq09YYJq5wzmaK+sQuF8qxkQEBcSh4f2 CkwoKs3S/sTVnGm81b22AY2r7vAcw/jiEOp8Lcssp1VkyAAn75vatmIVlbo5nZVr6rT3 IcVQ== X-Forwarded-Encrypted: i=1; AJvYcCUAHzRsZuFqQHQhZtrp3al1sgyGCDOfAoJlP/4J9lcRKTAjYV57R1XxpeMbu1juXss+1Fo=@dpdk.org X-Gm-Message-State: AOJu0YxgX/6jaIsTBFW3mZ1GCrLrBPw9iwgokKk2rkCyqIlLWHc4mZUH B9oxKtrG9scjmI/ooV3ypeZN5lJC537+l0OdcFeMjKHvY1uVxaNUKHmv+fR8LLHDkMzDVDNLBWY ThyfnO6m0FhVGFSiHiY6AkH+tUFsmM6IJtppbB8NzTVaLlZu1zs9TCxlqT31IfaRC/UyTN+k9k1 l9FKNUAiJ28I6vg1w= X-Received: by 2002:a05:6512:3b96:b0:539:e6bf:caa2 with SMTP id 2adb3069b0e04-53a03f04536mr2078798e87.12.1729068000067; Wed, 16 Oct 2024 01:40:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE6CcUyyxRlfxzCOpjxUZ3S4Qws83hMAcwnI4KuglKozlJ6WOAltB/hdbdY9VrZEyUnseBRxnLZijMtlJb+yrc= X-Received: by 2002:a05:6512:3b96:b0:539:e6bf:caa2 with SMTP id 2adb3069b0e04-53a03f04536mr2078777e87.12.1729067999601; Wed, 16 Oct 2024 01:39:59 -0700 (PDT) MIME-Version: 1.0 References: <20241014161036.12225-1-pbhagavatula@marvell.com> <20241015054241.2447-1-pbhagavatula@marvell.com> <20241015054241.2447-4-pbhagavatula@marvell.com> In-Reply-To: <20241015054241.2447-4-pbhagavatula@marvell.com> From: David Marchand Date: Wed, 16 Oct 2024 10:39:48 +0200 Message-ID: Subject: Re: [PATCH v7 3/3] node: add xstats for ip4 nodes To: pbhagavatula@marvell.com Cc: jerinj@marvell.com, ndabilpuram@marvell.com, kirankumark@marvell.com, zhirun.yan@intel.com, rjarry@redhat.com, Wathsala Vithanage , Bruce Richardson , Konstantin Ananyev , dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 15, 2024 at 7:43=E2=80=AFAM wrote: @@ -88,4 +90,10 @@ node_mbuf_priv2(struct rte_mbuf *m) > return (struct node_mbuf_priv2 *)rte_mbuf_to_priv(m); > } > > +#define NODE_INCREMENT_XSTAT_ID(node, id, cond, cnt) = \ > + { = \ > + if (unlikely(rte_graph_has_stats_feature() && (cond))) = \ > + ((uint64_t *)RTE_PTR_ADD(node, node->xstat_off))[= id] +=3D (cnt); \ > + } > + > #endif /* __NODE_PRIVATE_H__ */ Why introduce rte_node_xstat_increment() in patch 1, but not use it here? I'll merge this as is, but recoding such helper as a macro in node code is going in a wrong direction. --=20 David Marchand