DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Tianli Lai <laitianli@tom.com>
Cc: dev <dev@dpdk.org>, Harman Kalra <hkalra@marvell.com>
Subject: Re: [PATCH] interrupts: add uio type to support multiple interrupt vector
Date: Thu, 28 Apr 2022 14:18:36 +0200	[thread overview]
Message-ID: <CAJFAV8yvriUJRdf7nL4FzbwB1x10g0XxAOgnoemME_KKk8L-6Q@mail.gmail.com> (raw)
In-Reply-To: <20220407144411.5520-1-laitianli@tom.com>

On Thu, Apr 7, 2022 at 8:45 AM Tianli Lai <laitianli@tom.com> wrote:
>
> vmxnet3 device use MSI-X interrupt type.
> vmxnet3 driver configure the hardware to generate MSI-X interrupts
> would fail when call rte_intr_cap_multiple function return zero.

Iiuc, the issue is that you are using vmxnet3 devices bound to igb_uio.
Out of curiosity, why not use vfio-pci?


>
> Signed-off-by: Tianli Lai <laitianli@tom.com>
> ---
>  lib/eal/linux/eal_interrupts.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c
> index d52ec8eb4c..4b4dffa20c 100644
> --- a/lib/eal/linux/eal_interrupts.c
> +++ b/lib/eal/linux/eal_interrupts.c
> @@ -1596,6 +1596,9 @@ rte_intr_cap_multiple(struct rte_intr_handle *intr_handle)
>         if (rte_intr_type_get(intr_handle) == RTE_INTR_HANDLE_VDEV)
>                 return 1;
>
> +       if (rte_intr_type_get(intr_handle) == RTE_INTR_HANDLE_UIO)
> +               return 1;
> +

Doing this will let drivers think there are multiple fds, ok.

Though (I am not entirely sure) with this patch only, are not all
vectors pointing to a single fd.
For example, did you test Rx interrupts? with more than 1 rxq?


-- 
David Marchand


      reply	other threads:[~2022-04-28 12:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-07 14:44 Tianli Lai
2022-04-28 12:18 ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8yvriUJRdf7nL4FzbwB1x10g0XxAOgnoemME_KKk8L-6Q@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=laitianli@tom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).