From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A80E6A0C4C; Mon, 4 Oct 2021 10:29:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B40F412DD; Mon, 4 Oct 2021 10:29:54 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id B1863412DA for ; Mon, 4 Oct 2021 10:29:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633336191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+WjkO+vJ9uEto/q6KpZMA2t9Bd6tIL/bZc1ELQdnE/0=; b=dKsIMZnSyOXSpM+0tCWG1XCaT+Xz1xLK4fC8ADhVa0d4vXTgK8VZ1ofnvVZiewlyNFOg4p 820L1ea16BFiLeB7yhCJBjvzGKiqsSGQpPsNtOsUm7UU4iOQleOKwDfks7TeTdftQLggkr 63T706rm+en0ERDItXKYSdeS0f8j384= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-319-M2WUX4V3P26dBnaFcBjbIQ-1; Mon, 04 Oct 2021 04:29:49 -0400 X-MC-Unique: M2WUX4V3P26dBnaFcBjbIQ-1 Received: by mail-lf1-f72.google.com with SMTP id k7-20020ac257c7000000b003fd3ab38ddeso440821lfo.0 for ; Mon, 04 Oct 2021 01:29:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+WjkO+vJ9uEto/q6KpZMA2t9Bd6tIL/bZc1ELQdnE/0=; b=6nsB3BVjQ2xiXgpouO4k5jVqxdTWXejAAycHdbcHGkwoQT04+KKZl5bgMN4kOGA4If /o0yEzxM7gyPd+a6zWaZCO+WyIkllAxnbGXlsASzpeyzgImTF5szlfkOIor9SoCL9tLz T0C3mVWYI39BiyNMtkDT6+O3DNHo9kLNPyaOdaUACuOWSTdiKp3EjCO5GBUebo4CpEIj /gnPjQ5o1b9AHHbv4N4kuHgjLbzLBFZU0zsOL77Vq46PhvujX22XhiZtZ1PVNKQi5FkR +moM1LV+t1tfdEFoAmFl5qJHPHdHqPcmn0dLzwhtpzIf0Ni/6DRY74JGvfkRTfDx2PnF LGwA== X-Gm-Message-State: AOAM532XODN7phQgWR85+dFOhyKuwegpWT2j5Q32OlcB9vzhxCiKoGR0 EVeDfZ6MqZEJJyuGea1BrNRgGHSi7khUy5k/rwRlIY8+dhoF7DEjCeAeISNaAtOguyUdVHC3lTf tUl8c5KOwfJCGhFG8cfk= X-Received: by 2002:a2e:2f02:: with SMTP id v2mr14233267ljv.46.1633336188077; Mon, 04 Oct 2021 01:29:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0w2DA+1/4AD87fL0h8Otxa/9lIOyZ8lSVaCjySWHYWtGkYWe3mAbJfGEiXyMhsIUEcgHvf9UCrKlLGLaG/u4= X-Received: by 2002:a2e:2f02:: with SMTP id v2mr14233248ljv.46.1633336187871; Mon, 04 Oct 2021 01:29:47 -0700 (PDT) MIME-Version: 1.0 References: <20210929214817.18082-1-olivier.matz@6wind.com> <20210929214817.18082-2-olivier.matz@6wind.com> In-Reply-To: <20210929214817.18082-2-olivier.matz@6wind.com> From: David Marchand Date: Mon, 4 Oct 2021 10:29:36 +0200 Message-ID: To: Olivier Matz Cc: dev , Andrew Rybchenko , "Yigit, Ferruh" , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf: remove deprecated offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 29, 2021 at 11:50 PM Olivier Matz wrote: > > The flags PKT_TX_VLAN_PKT, PKT_TX_QINQ_PKT, PKT_RX_EIP_CKSUM_BAD are > marked as deprecated since commit 380a7aab1ae2 ("mbuf: rename deprecated > VLAN flags") (2017). Remove their definitions from rte_mbuf_core.h, > and replace their usages. The patch lgtm except the removal of some "bad checksum" flags, see below. [snip] > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 05fc2fdee7..549e9416c4 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -159,11 +159,6 @@ Deprecation Notices > will be limited to maximum 256 queues. > Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed. > > -* ethdev: The offload flag ``PKT_RX_EIP_CKSUM_BAD`` will be removed and > - replaced by the new flag ``PKT_RX_OUTER_IP_CKSUM_BAD``. The new name is more > - consistent with existing outer header checksum status flag naming, which > - should help in reducing confusion about its usage. > - > * i40e: As there are both i40evf and iavf pmd, the functions of them are > duplicated. And now more and more advanced features are developed on iavf. > To keep consistent with kernel driver's name Those 3 flags are easy to replace, but some projects are still using them. $ git grep-all -El '\<(PKT_TX_VLAN_PKT|PKT_TX_QINQ_PKT|PKT_RX_EIP_CKSUM_BAD)\>' |grep -v \\.patch$ DPVS/src/netif.c DPVS/src/vlan.c FD.io-VPP/src/plugins/dpdk/device/format.c gatekeeper/bpf/bpf_mbuf.h lagopus/src/dataplane/dpdk/worker.c packet-journey/app/main.c Trex/src/pal/common/common_mbuf.h Trex/src/pal/linux/mbuf.h Please update the release notes to announce this API update. [snip] > diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h > index 9d8e3ddc86..93db9292c0 100644 > --- a/lib/mbuf/rte_mbuf_core.h > +++ b/lib/mbuf/rte_mbuf_core.h > @@ -55,37 +55,12 @@ extern "C" { > /** RX packet with FDIR match indicate. */ > #define PKT_RX_FDIR (1ULL << 2) > > -/** > - * Deprecated. > - * Checking this flag alone is deprecated: check the 2 bits of > - * PKT_RX_L4_CKSUM_MASK. > - * This flag was set when the L4 checksum of a packet was detected as > - * wrong by the hardware. > - */ > -#define PKT_RX_L4_CKSUM_BAD (1ULL << 3) > - > -/** > - * Deprecated. > - * Checking this flag alone is deprecated: check the 2 bits of > - * PKT_RX_IP_CKSUM_MASK. > - * This flag was set when the IP checksum of a packet was detected as > - * wrong by the hardware. > - */ > -#define PKT_RX_IP_CKSUM_BAD (1ULL << 4) > - You did not mention PKT_RX_IP_CKSUM_BAD and PKT_RX_L4_CKSUM_BAD in the commitlog. There was no deprecation notice, and those flags were not marked RTE_DEPRECATED (there are still many projects referencing them). Is this removal intended? -- David Marchand