From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34F61A0471 for ; Mon, 12 Aug 2019 11:50:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC930326D; Mon, 12 Aug 2019 11:50:02 +0200 (CEST) Received: from mail-vs1-f65.google.com (mail-vs1-f65.google.com [209.85.217.65]) by dpdk.org (Postfix) with ESMTP id 8D106326C for ; Mon, 12 Aug 2019 11:50:01 +0200 (CEST) Received: by mail-vs1-f65.google.com with SMTP id i128so420936vsc.7 for ; Mon, 12 Aug 2019 02:50:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jcwaj7Mu0gVkCigQjpEfZuNYSmVvOvRJcXlfkqI3yZs=; b=NzUTkDJG7vM4gIhMgZJQJ+lbmURgBVCL3nw5kRjTtZPFA1Fsqi0DK2/eXCCjEe7rq1 hdHAFG8u+hQyLzStKS91LdID+o7oZcUm1+Z+sdn6wCZvIdD7CqiMt7UhvD4XdHflM5ZP l8oN9dT28wR6ES+gOpiPXVzXgnCDvcLJ2fYFBeL8K6smUFBmvOXqguIZQy4FUwIyXbcp z3C452zj63TP1atCuCMdoazndZsK5mVLuClWWzo3LhegsON78NRXBn+gc51xQxeLLINq sDo5RdKvWJ0cLJxLCQj7eClusQP/ThL8RkmCZcZPtFwhaamTPlcu01zB1uWEX6TX2xM7 4WYA== X-Gm-Message-State: APjAAAXKWH8VKVRR6M1GEjhVRSAiI61KzyrxtSfZ2XpDpcIts2UTt21T +9LK3QTegP3kyT4BcwbWwbujo6zCaCOdIpoGPZu3ng== X-Google-Smtp-Source: APXvYqzbJHEnVwDDoh4R0ENnMlYQbQRP3gsmbvkO+fMkPqsgVTdN6xHU5TNIleOGiBvPmDSJ8bBej8RaE5ZFFdllG6Y= X-Received: by 2002:a67:fb58:: with SMTP id e24mr7951169vsr.141.1565603400815; Mon, 12 Aug 2019 02:50:00 -0700 (PDT) MIME-Version: 1.0 References: <20190807101204.21614-1-g.singh@nxp.com> <52183700.OczlixnxyG@xps> <15982978.NnXy4IA2Yx@xps> <525631f9-c367-336e-7caf-dbb886193fc6@intel.com> In-Reply-To: <525631f9-c367-336e-7caf-dbb886193fc6@intel.com> From: David Marchand Date: Mon, 12 Aug 2019 11:49:49 +0200 Message-ID: To: "Burakov, Anatoly" Cc: Thomas Monjalon , Hemant Agrawal , Gagandeep Singh , dev , Olivier Matz , Andrew Rybchenko , Nipun Gupta , Honnappa Nagarahalli , Steve Capper , Jerin Jacob Kollanukkaran , Bruce Richardson , Gavin Hu , "Ananyev, Konstantin" , David Christensen Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 12, 2019 at 11:43 AM Burakov, Anatoly wrote: > On 08-Aug-19 8:31 AM, Thomas Monjalon wrote: > > I would suggest to restrict the change to Arm only with an ifdef, > > in order to limit the risk for this release. > > We can think about a dynamic hugepage scan in the next release. > > > > I don't see how this is necessary. The 3 is an arbitrary number here, > and the ABI isn't broken as this is an internal structure. We could > increase it to 16 for all i care, and it wouldn't make any difference to > the rest of the code - we never populate more than we can find anyway. I agree on the principle. But at the time this popped up, we were really close to the release. It seemed a way to mitigate any unforeseen issue by limiting to the platform that was affected. -- David Marchand