From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7BA7C43B0C; Tue, 13 Feb 2024 17:18:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B46540A4B; Tue, 13 Feb 2024 17:18:52 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7FAF7402D8 for ; Tue, 13 Feb 2024 17:18:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707841131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ycoIzdmtFME9rI5DFvaYf/RNaC5C8ABrR7Gho+q2yUo=; b=SQL3F24HxkK2Gs9NpgU7c5h+0aT9bTdB5jp+6ukCuoHO9FHVcODFg+UXnIiQ2Y26NocW4v MHvkfoJYOW2TlgzGuMv42Gg3yuLVqjzmEVwhjz2hzpb5cLbC1jaBlwZLhYgnO3ZgEIqrgS OHLF58ixJ9vL0NsnXz85iatElzaLxBc= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-X1uIkz6ZMn6QlZT2kxTcLQ-1; Tue, 13 Feb 2024 11:18:49 -0500 X-MC-Unique: X1uIkz6ZMn6QlZT2kxTcLQ-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-29608f00cbbso2841178a91.2 for ; Tue, 13 Feb 2024 08:18:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707841129; x=1708445929; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ycoIzdmtFME9rI5DFvaYf/RNaC5C8ABrR7Gho+q2yUo=; b=Ogb4vto3nPP8FlcA7DnhM2wdv2zcIpwzcBvYfei5t8R35O4Rs9LJmCdWnuga8skL2V NVpe33sPqYByodwMZNp9DB5+CildJRnMXeDyHRcd4YzcXlF5RFXpQMg1urUO4TNmkmF4 xS7SSyfycaPgZSBY5BOID0qNymtjzyifmLm7mKnyIvmjhId1k+eeJghqVXjWwv1FpjhD N0BmtJMppstrR5kG1Ltj0YhrcNUr6RtqJXTyyarU3EVwUjrvRXCfIkUyUE8b0x2if9Za pKRDuOnwnKA/BGrCf++zTqTk/WYMtIRSonHXlx3ac9MW9VCk2iutkyhLuv2tQYta6R5x p58g== X-Gm-Message-State: AOJu0YwfeBdMioKK4VrbZSbyO942czE4YJlUqCgSUiQ+VBBsZxTydT02 IUCejE3XpdeQfvQN5oGjM7ayKClqyB8nhU+Uw4kEIX0lnV+PhNp5Ul5vcdVOR8aRZYiloJ3hCBn BEEoZoDm5S4XuScQQNJnoYZKp7T2sFi3TM5AOazxBExsBrcrJu/pXNUawlMDxESVA6kmPnJDEJF lsJLmjctYvrcnDdbV0mRQvWEmn5Q== X-Received: by 2002:a17:90a:d605:b0:296:c97f:64a5 with SMTP id w5-20020a17090ad60500b00296c97f64a5mr6792299pju.1.1707841128860; Tue, 13 Feb 2024 08:18:48 -0800 (PST) X-Google-Smtp-Source: AGHT+IEDbvejxI1WPRG01ChVy6iFVfr6Duor/Ty9IDUjZu7Bhj4DeRyG3ON3asy3vOGhb7xvjdlFqqdJxzUxksKCDQA= X-Received: by 2002:a17:90a:d605:b0:296:c97f:64a5 with SMTP id w5-20020a17090ad60500b00296c97f64a5mr6792275pju.1.1707841128565; Tue, 13 Feb 2024 08:18:48 -0800 (PST) MIME-Version: 1.0 References: <20240213145218.1532323-1-cristian.dumitrescu@intel.com> In-Reply-To: <20240213145218.1532323-1-cristian.dumitrescu@intel.com> From: David Marchand Date: Tue, 13 Feb 2024 17:18:35 +0100 Message-ID: Subject: Re: [PATCH] examples/pipeline: fix include path for rte_log.h To: Cristian Dumitrescu Cc: dev@dpdk.org, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Feb 13, 2024 at 3:52=E2=80=AFPM Cristian Dumitrescu wrote: > > When rte_log.h was moved to a new directory, the include path was not > updated for the generated C code produced by the pipeline library, > which results in build failure for this code. > > Fixes: 09ce41310930 ("log: separate logging functions out of EAL") > Cc: stable@dpdk.org > > Signed-off-by: Cristian Dumitrescu > --- > examples/pipeline/cli.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c > index 2ae6cc579f..afb143c01f 100644 > --- a/examples/pipeline/cli.c > +++ b/examples/pipeline/cli.c > @@ -714,6 +714,7 @@ cmd_pipeline_libbuild(char **tokens, > "-I %s/lib/eal/include " > "-I %s/lib/eal/x86/include " > "-I %s/lib/eal/include/generic " > + "-I %s/lib/log " > "-I %s/lib/meter " > "-I %s/lib/port " > "-I %s/lib/table " > @@ -738,6 +739,7 @@ cmd_pipeline_libbuild(char **tokens, > install_dir, > install_dir, > install_dir, > + install_dir, > log_file, > obj_file, > lib_file, Wrt $Subject, copy/paste code in drivers/net/softnic is broken too. Some comments on this code: - putting compilation commands seems a rather strange idea in C code, but at least, why not invoke an external tool/script that makes use of existing build framework? - RTE_INSTALL_DIR is undocumented, - this implementation (passing -I /lib/eal/include) is broken with a system-installed dpdk, --=20 David Marchand