From: David Marchand <david.marchand@redhat.com>
To: Dodji Seketeli <dodji@redhat.com>
Cc: dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com,
ndabilpuram@marvell.com, yanzhirun_163@163.com,
Huichao Cai <chcchc88@163.com>
Subject: Re: [PATCH v6] graph: mcore: optimize graph search
Date: Tue, 17 Dec 2024 10:04:51 +0100 [thread overview]
Message-ID: <CAJFAV8ywLcCW-WwJXPcRkSLT3M0Fjm58gXR2dwUyEmEzD8EuVg@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8zFF17ce4sK4zBWE9dRTPFwQ-0v_JRG-g8XqfEuFVJOBw@mail.gmail.com>
On Mon, Dec 16, 2024 at 3:49 PM David Marchand
<david.marchand@redhat.com> wrote:
> $ abidiff --suppr
> /home/dmarchan/git/pub/dpdk.org/main/devtools/libabigail.abignore
> --no-added-syms --headers-dir1
> /home/dmarchan/abi/v24.11/build-gcc-shared/usr/local/include
> --headers-dir2 /home/dmarchan/builds/main/build-gcc-shared/install/usr/local/include
> /home/dmarchan/abi/v24.11/build-gcc-shared/usr/local/lib64/librte_graph.so.25.0
> /home/dmarchan/builds/main/build-gcc-shared/install/usr/local/lib64/librte_graph.so.25.1
> Functions changes summary: 0 Removed, 1 Changed (9 filtered out), 0
> Added functions
> Variables changes summary: 0 Removed, 0 Changed, 0 Added variable
>
> 1 function with some indirect sub-type change:
>
> [C] 'function bool
> __rte_graph_mcore_dispatch_sched_node_enqueue(rte_node*,
> rte_graph_rq_head*)' at rte_graph_model_mcore_dispatch.c:117:1 has
> some indirect sub-type changes:
> parameter 1 of type 'rte_node*' has sub-type changes:
> in pointed to type 'struct rte_node' at rte_graph_worker_common.h:92:1:
> type size hasn't changed
> 1 data member changes (2 filtered):
> anonymous data member at offset 1536 (in bits) changed from:
> union {struct {unsigned int lcore_id; uint64_t
> total_sched_objs; uint64_t total_sched_fail;} dispatch;}
> to:
> union {struct {unsigned int lcore_id; uint64_t
> total_sched_objs; uint64_t total_sched_fail; rte_graph* graph;}
> dispatch;}
>
>
> What would be the best way to suppress this warning?
> I tried the following which seems to work, but I prefer to ask for your advice.
>
> [suppress_type]
> name = rte_node
> has_data_member_at = offset_of(total_sched_fail)
Gah.. I meant has_data_member_inserted_at.
But then testing with has_data_member_inserted_at, the warning is not
suppressed either...
Any help appreciated.
--
David Marchand
next prev parent reply other threads:[~2024-12-17 9:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 8:04 [PATCH] graph: optimize graph search when scheduling nodes Huichao cai
2024-11-07 9:37 ` [EXTERNAL] " Jerin Jacob
2024-11-08 1:39 ` Huichao Cai
2024-11-08 12:22 ` Jerin Jacob
2024-11-08 13:38 ` David Marchand
2024-11-11 5:38 ` Jerin Jacob
2024-11-12 8:51 ` David Marchand
2024-11-12 9:35 ` Jerin Jacob
2024-11-12 12:57 ` Huichao Cai
2024-11-13 9:22 ` Huichao Cai
2024-11-14 7:09 ` Jerin Jacob
2024-11-11 4:03 ` [PATCH v2] graph: mcore: optimize graph search Huichao Cai
2024-11-11 5:46 ` [EXTERNAL] " Jerin Jacob
2024-11-13 9:19 ` Huichao Cai
2024-11-13 7:35 ` [PATCH v3 1/2] " Huichao Cai
2024-11-13 7:35 ` [PATCH v3 2/2] graph: add alignment to the member of rte_node Huichao Cai
2024-11-14 7:14 ` [EXTERNAL] " Jerin Jacob
2024-11-14 8:45 ` [PATCH v4 1/2] graph: mcore: optimize graph search Huichao Cai
2024-11-14 8:45 ` [PATCH v4 2/2] graph: add alignment to the member of rte_node Huichao Cai
2024-11-14 10:05 ` [EXTERNAL] " Jerin Jacob
2024-11-14 12:06 ` Huichao Cai
2024-11-14 13:04 ` Jerin Jacob
2024-11-15 1:55 ` [PATCH v5 1/1] graph: improve node layout Huichao Cai
2024-11-15 14:23 ` Thomas Monjalon
2024-11-15 15:57 ` [EXTERNAL] " Jerin Jacob
2024-11-19 10:31 ` Thomas Monjalon
2024-12-13 2:21 ` [PATCH v5] graph: mcore: optimize graph search Huichao Cai
2024-12-13 14:36 ` David Marchand
2024-12-16 1:43 ` [PATCH v6] " Huichao Cai
2024-12-16 14:49 ` David Marchand
2024-12-17 9:04 ` David Marchand [this message]
2024-12-20 2:05 ` Huichao Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8ywLcCW-WwJXPcRkSLT3M0Fjm58gXR2dwUyEmEzD8EuVg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=chcchc88@163.com \
--cc=dev@dpdk.org \
--cc=dodji@redhat.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=yanzhirun_163@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).