From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BC8845ECE; Tue, 17 Dec 2024 10:05:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 08C73402A9; Tue, 17 Dec 2024 10:05:08 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 81073402A3 for ; Tue, 17 Dec 2024 10:05:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734426306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UpWcpgaODWLj3+KAJQwqVmRkUhRX8/Sc1csmWdKyFoM=; b=PKdN98jNUCXZxG4M3+/cZ+YTnX2OAUxch23zPneC0B3YuEX2QZeM1uiuYmyNtV52cswWgU yMkJY49hzd3GIGHgKpxrmiDMiDl38gbEKGUDDY3rJgyAeZ1AIwpC/7SU8ymh4+l6KdjrOl gcpvEagSMPyHP0QanA35uMLuZigrd6I= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-18-_AHHsSd0Mpyv6vIa3lTapA-1; Tue, 17 Dec 2024 04:05:04 -0500 X-MC-Unique: _AHHsSd0Mpyv6vIa3lTapA-1 X-Mimecast-MFC-AGG-ID: _AHHsSd0Mpyv6vIa3lTapA Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-3021da9e8b4so32150751fa.1 for ; Tue, 17 Dec 2024 01:05:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734426303; x=1735031103; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UpWcpgaODWLj3+KAJQwqVmRkUhRX8/Sc1csmWdKyFoM=; b=WwvWSD5eLV1Lv8yEmpJrmS+IjQgnKOqLqSLgAhpNkNkVxxy9HwwwarfhQSMzmHPQlY 0pWwSOon3HmyqhvN/STTMk9/3lnJW2taxk7fAQSY7e8/pEIOvSQuG6T8aWy/54o/NnJ+ sEtbdcH30OpPMrGChN3UXi06xFbjwXyd8fvn6ra1bLT2WGXIx1niKN+Yb5jOR+iCFuqH 963U2ZDnYn0Iz8q5M49EbUGNJ9TwTsruZHAoSKn0zjxuRN79GMio4AuUAPUoqhtRdDrW GtQ/daCgiy5v7ealFBv8bbVs6Pb5Y50Uahi0UXoJzClepuXGWgamSYQPfQGJEypCes5s LJLg== X-Gm-Message-State: AOJu0Yz9UyfrKys7s79B5Hezofl37XlOg9WnHbK0XHr4KnJcsw0oA1pG 3If3ee5t5Cullv0DmiKOIhYva/RwpGbxeHv4U8bBDog/5AkWagu2R86aHkX2QP8H2cMZpaPksvi ySGSpak+/dZkxcfmTHQsZVp3721Wf+HZFG/IhAap3Y1y3c920duxWdZpCcakJc0Jt6F4KKepJLK ppCQHJfHOT/lfk/J8= X-Gm-Gg: ASbGncuCuLz22O7M+7ovHphpuZqiZsASbBpnTfUtPaHgQ3VYICQTEeXf+iCJSs5kIAu o/XHOVtxgFG+VVrnnuuoFdg5H+OaulX7hhASKyILo X-Received: by 2002:a05:651c:1a0b:b0:302:1e65:f2ab with SMTP id 38308e7fff4ca-302544ca738mr47918631fa.20.1734426303153; Tue, 17 Dec 2024 01:05:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IE1slnsvYdTZVAXQGQ0AO870iHsp2XC5C9i0O+zRbyjHBvKTkN93/pD45lkLqqWyNV9BEo0nCxQYvnrlXG2ShU= X-Received: by 2002:a05:651c:1a0b:b0:302:1e65:f2ab with SMTP id 38308e7fff4ca-302544ca738mr47918541fa.20.1734426302764; Tue, 17 Dec 2024 01:05:02 -0800 (PST) MIME-Version: 1.0 References: <20241213022158.2644-1-chcchc88@163.com> <20241216014353.2036-1-chcchc88@163.com> In-Reply-To: From: David Marchand Date: Tue, 17 Dec 2024 10:04:51 +0100 Message-ID: Subject: Re: [PATCH v6] graph: mcore: optimize graph search To: Dodji Seketeli Cc: dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com, ndabilpuram@marvell.com, yanzhirun_163@163.com, Huichao Cai X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dvn0TNfDb1GfEijjwRbLLI2QYZFcfHhYCyiG5S_QgEI_1734426303 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Dec 16, 2024 at 3:49=E2=80=AFPM David Marchand wrote: > $ abidiff --suppr > /home/dmarchan/git/pub/dpdk.org/main/devtools/libabigail.abignore > --no-added-syms --headers-dir1 > /home/dmarchan/abi/v24.11/build-gcc-shared/usr/local/include > --headers-dir2 /home/dmarchan/builds/main/build-gcc-shared/install/usr/lo= cal/include > /home/dmarchan/abi/v24.11/build-gcc-shared/usr/local/lib64/librte_graph.s= o.25.0 > /home/dmarchan/builds/main/build-gcc-shared/install/usr/local/lib64/librt= e_graph.so.25.1 > Functions changes summary: 0 Removed, 1 Changed (9 filtered out), 0 > Added functions > Variables changes summary: 0 Removed, 0 Changed, 0 Added variable > > 1 function with some indirect sub-type change: > > [C] 'function bool > __rte_graph_mcore_dispatch_sched_node_enqueue(rte_node*, > rte_graph_rq_head*)' at rte_graph_model_mcore_dispatch.c:117:1 has > some indirect sub-type changes: > parameter 1 of type 'rte_node*' has sub-type changes: > in pointed to type 'struct rte_node' at rte_graph_worker_common.h:9= 2:1: > type size hasn't changed > 1 data member changes (2 filtered): > anonymous data member at offset 1536 (in bits) changed from: > union {struct {unsigned int lcore_id; uint64_t > total_sched_objs; uint64_t total_sched_fail;} dispatch;} > to: > union {struct {unsigned int lcore_id; uint64_t > total_sched_objs; uint64_t total_sched_fail; rte_graph* graph;} > dispatch;} > > > What would be the best way to suppress this warning? > I tried the following which seems to work, but I prefer to ask for your a= dvice. > > [suppress_type] > name =3D rte_node > has_data_member_at =3D offset_of(total_sched_fail) Gah.. I meant has_data_member_inserted_at. But then testing with has_data_member_inserted_at, the warning is not suppressed either... Any help appreciated. --=20 David Marchand