From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC5FEA0032; Thu, 12 May 2022 09:06:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D5DC410EF; Thu, 12 May 2022 09:06:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 7867A40E64 for ; Thu, 12 May 2022 09:06:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652339198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YcafJlTEEBp2r49t6lFXsZ9bL/tuT0KjjFmQyFczZNk=; b=iSDhmsEHqDP43s3fXNFDxS+uAefPbxy3nL+7Ec3sKYaplyiwHjqFK9NqEhN8jJJnvxQTvS by/1Hj1JH48OIaf8yn0GiNGZPBUOW13G8oJVTHBm9ox/z/CJmp1cx4AtfmHV7tCkzrG7/M XL36tiFQgDDg3jglspiTLQj7jaqac9Q= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-178-t8yAzhRqORWLUKVOXfjjIQ-1; Thu, 12 May 2022 03:06:36 -0400 X-MC-Unique: t8yAzhRqORWLUKVOXfjjIQ-1 Received: by mail-lj1-f197.google.com with SMTP id j6-20020a2eb706000000b00250c3958dccso1291251ljo.21 for ; Thu, 12 May 2022 00:06:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YcafJlTEEBp2r49t6lFXsZ9bL/tuT0KjjFmQyFczZNk=; b=kbmwMqgMEsL6S7vmgnS1pfJXBci5+sBL1/gcv9LxF342xGe5joS5iN83Bwik2UY3sU 6oBT+ir75QrdLq/eMMHWAYnin2/WhylNmh39sWeWhcvDUsA1zwfpwUF8nP/WzBXEIl3N vFN0w2tB1OluzhcYYcBhotdzNnPSjdE7ZYiwMY9xmaU01L6Y3uXZ7E4CQCw+AMVs+5pX MtPddyZhnGTQL3Zadl3Dp+hIdNw2k6wrG6LPL6p/8zr4q7w5rW6rwqA2fHrLZ2dpZZUQ WWFSpGtPyNK0S6MY8hIZ8nKj7YTRBXnFTDxmB2i8AVs8Dk6pcUaP61IdI2mgoBiCcz23 u8hQ== X-Gm-Message-State: AOAM532wvCwFkW2f4jVSRtTqfywQPrPIdO6HcMvXFRlF8fPMRO1P7GZU YyutsL538guUMhSY0xwQSkVADzL6SU74vm9PkDySObOj0diQKiDpSQAivwK+1LE2ZunlM/wZoTP zsX5VPdnhHhSBKgHW3HE= X-Received: by 2002:a05:651c:2046:b0:250:cf36:eb77 with SMTP id t6-20020a05651c204600b00250cf36eb77mr10766234ljo.159.1652339195118; Thu, 12 May 2022 00:06:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTo5B3xXQHzV0lhl3Tpoall2XAJ0UzMtt+sxdryI9ClJNs6oeaAHjfrYjRA+k8V+Xi903oM7nQrCRfPQoD5+I= X-Received: by 2002:a05:651c:2046:b0:250:cf36:eb77 with SMTP id t6-20020a05651c204600b00250cf36eb77mr10766217ljo.159.1652339194885; Thu, 12 May 2022 00:06:34 -0700 (PDT) MIME-Version: 1.0 References: <20220414112756.26119-1-david.marchand@redhat.com> In-Reply-To: <20220414112756.26119-1-david.marchand@redhat.com> From: David Marchand Date: Thu, 12 May 2022 09:06:23 +0200 Message-ID: Subject: Re: [PATCH] devargs: fix leak on hotplug failure To: Xueming Li , Gaetan Rivet Cc: dpdk stable , dev , Ray Kinsella Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 14, 2022 at 1:28 PM David Marchand wrote: > > Caught by ASan, if a secondary process tried to attach a device with an > incorrect driver name, devargs was leaked. > > Fixes: 64051bb1f144 ("devargs: unify scratch buffer storage") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Review please? -- David Marchand