From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7BBAA04DB; Tue, 10 Nov 2020 16:51:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 378E92B9D; Tue, 10 Nov 2020 16:51:21 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 2B7CAF64 for ; Tue, 10 Nov 2020 16:51:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605023477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gATJ9sOyZeFUlVyXjs3VaY1LCth6yd5QYNDsfH6NZmI=; b=VGQfng7vG9bQ/Kez0fgd0VyvAR4xIDBnXMduLTagumadAwa5wRVrfEjc6gCTKk6xqxGBnD vo6m9pMWwGh42EV7NSrCqwyjgcjewyOf++EQDe+1RhZ81LizQ0rAR0RsGMCMcznXIZwdRu JVyfwI/DSgh6cVeuAqsKF8cOEpuXgoE= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-235-ayl3jK5QPFCziNOWPT9GQA-1; Tue, 10 Nov 2020 10:51:16 -0500 X-MC-Unique: ayl3jK5QPFCziNOWPT9GQA-1 Received: by mail-vs1-f70.google.com with SMTP id 7so4633693vsu.23 for ; Tue, 10 Nov 2020 07:51:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gATJ9sOyZeFUlVyXjs3VaY1LCth6yd5QYNDsfH6NZmI=; b=hYUzbRA/Nu/aJo3yftnveufuN3wP5WEDPjRYBuJDrJqy1lF7Igxhg3Gd6Oltog/ml1 I4xamVSQAto3vsluMkVAw+j0M4ccpmfk50cWAdB4rRrHOh4kTXFzGFEsya30kFkJ+erv 1aj9Vl829XvciJWr6wmVGxMbNsc5cQjXHds9L5sIwsfivwK6ZEOaPZBTJN9W6QB6niTQ VEOimC/ysD8D3KxjuIKW94+U+HJlcAwheHCo/Cxh8f/jQJ5YMbUw99r4RwZtkP64p0C2 TJ9oFVbOB3/NVecFU9tmSZsQt13oCljrn9qL6zvwD9rm+j3oppOhHtdv4e5KrIDE+LOO tZtA== X-Gm-Message-State: AOAM532Pdxaf6tO4BHnDHoHjcBR7R69l5zxox8+ReLaLkucyGMWJBdPQ F84WmcxXQQSVWoks253WtD2L+20kDqm+hYnPYuACJu5dqxKUaVFsjfoiA+7rkkuBpuvLNGW0XYG DzDhmjiGuVQRxxo5D09c= X-Received: by 2002:a1f:38d2:: with SMTP id f201mr10681819vka.17.1605023475519; Tue, 10 Nov 2020 07:51:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJxdgB90tUx4xFBweSamGJpNQwEm1UBrgvUNc1YsUyIYKWXv3RIwaGOu3Al3FfNXGFGAYezRwPIH3Gy6rfGClGQ= X-Received: by 2002:a1f:38d2:: with SMTP id f201mr10681788vka.17.1605023475194; Tue, 10 Nov 2020 07:51:15 -0800 (PST) MIME-Version: 1.0 References: <20200612212434.6852-2-timothy.mcdaniel@intel.com> <1604258796-19966-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: From: David Marchand Date: Tue, 10 Nov 2020 16:51:03 +0100 Message-ID: To: "McDaniel, Timothy" Cc: dev , "Carrillo, Erik G" , "Eads, Gage" , "Van Haaren, Harry" , Jerin Jacob Kollanukkaran , Thomas Monjalon , Gaetan Rivet Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v15 00/23] Add DLB PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 10, 2020 at 4:29 PM McDaniel, Timothy wrote: > > I'm not seeing where we can use librte_pci here. We are already using the dpdk low level rte_pci_read_config(..) APIs. > Am I missing something? dlb_pci_find_ext_capability is a copy of rte_pci_find_ext_capability from the pci bus. A lot of DLB_PCI_* defines have a librte_pci equivalent. Plus, if there are generic pci defines needed by DLB, they would rather belong to librte_pci than a driver. -- David Marchand