From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85ED145C79; Mon, 4 Nov 2024 18:59:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AFC340281; Mon, 4 Nov 2024 18:59:31 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id EFE324025F for ; Mon, 4 Nov 2024 18:59:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730743168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bSVwju561bAW9R50AdxPK/2DJT9E/Gs9C6L7RbUiJ0w=; b=ffB0OwI4pWz9fcHJk76h+ei812xPn5Oe8MGgPoGqSIzcu8o96x4bZBV1vIO+mPEor4JGo+ leKaoWTMuq+ar+RaVZWZjl65NrgHMZ3xqpMF32SeL9K/PFWWPZntWUElM6vGDBRgaZm19E JF47YaUYEq5HoEJ9Q0J+7js2tSv/R/c= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-34-mcfRal5dOGy5gNLg6SrOAg-1; Mon, 04 Nov 2024 12:59:27 -0500 X-MC-Unique: mcfRal5dOGy5gNLg6SrOAg-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-53a017bc09dso2663246e87.0 for ; Mon, 04 Nov 2024 09:59:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730743165; x=1731347965; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bSVwju561bAW9R50AdxPK/2DJT9E/Gs9C6L7RbUiJ0w=; b=WnroC5c5FqQfa2e5QjkPzWANYPb8/Gwb3Afi3oPK5zo0ib62AMB0aXysK4fLJ+8ZtF tPeB6ctMM08gamyEWyAE5zoFMBf8WRbZ5aZcxrwXHGVtLrXXV5hwioec/hVmHQUG96he wBMY6sGXCkFhoSqK2BYESEbCBxZzWeC314rO+d+fUkl5rFA44nqXJKocBOh7rDxuGT+i IOhcmfm51IovWVk2G548l4TubyxMNzr6qdE9WApwp+oJeHSEGTI/YOzSoFqdtlFLYW3m GNCSDLs1mnsPCkb3QpccpI+i2ws/N/Y1/5gvOSlskyC5bD+XSqZ+4k7k6qpyZiDaeJfk sxCA== X-Gm-Message-State: AOJu0Yz+QwaCX6kwMDUdjKgG60YCEoaIu87EkFH1KoMSq+QLy589X6xC fItatTXNwCdL6BAjDfKHF/FLp9L86XuT1dZINYjpspBVkuNN7bKWb6k3kNU/Qo6oxRjiopp/Uqb eKylxnP7D4pU+nlxPt3npxrBDXRUcd/4EP9C6ga+yqaQhPijCLMz/o1aeLQZpTj7scJAsR0b9Lc CBpv8r+TWHCur8DHE= X-Received: by 2002:a05:6512:1047:b0:53a:aea:a9e1 with SMTP id 2adb3069b0e04-53c79ea5d42mr7898799e87.54.1730743165415; Mon, 04 Nov 2024 09:59:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYzaWGpligy5r1F6yKP5oCLhrIJODOwVQrBTQ7Ci9fOkp0j/RS9Nntew+cUHdVbNYtjt4fqOk1/FyQJYl9fUY= X-Received: by 2002:a05:6512:1047:b0:53a:aea:a9e1 with SMTP id 2adb3069b0e04-53c79ea5d42mr7898786e87.54.1730743165002; Mon, 04 Nov 2024 09:59:25 -0800 (PST) MIME-Version: 1.0 References: <20241030190945.409721-1-luca.boccassi@gmail.com> <20241030203122.416198-1-luca.boccassi@gmail.com> <20241031134620.39aea352@hermes.local> In-Reply-To: From: David Marchand Date: Mon, 4 Nov 2024 18:59:13 +0100 Message-ID: Subject: Re: [PATCH v2] Revert "eal/unix: fix thread creation" To: Luca Boccassi Cc: dev@dpdk.org, roretzla@linux.microsoft.com, Stephen Hemminger X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Luca, On Sat, Nov 2, 2024 at 11:09=E2=80=AFAM David Marchand wrote: > > On Thu, Oct 31, 2024 at 9:46=E2=80=AFPM Stephen Hemminger > wrote: > > > > On Thu, 31 Oct 2024 14:05:16 +0000 > > Luca Boccassi wrote: > > > > > On Thu, 31 Oct 2024 at 13:04, David Marchand wrote: > > > > > > > > On Thu, Oct 31, 2024 at 1:58=E2=80=AFPM Luca Boccassi wrote: > > > > > > > > > > On Thu, 31 Oct 2024 at 12:52, David Marchand wrote: > > > > > > > > > > > > On Thu, Oct 31, 2024 at 1:47=E2=80=AFPM David Marchand > > > > > > wrote: > > > > > > > Could you share a backtrace when hitting this deadlock? > > > > > > > > > > > > If the backtrace is not possible, running with > > > > > > --log-level=3Dlib.eal:debug may help. > > > > > > > > > > I cannot get backtraces. This runs via "meson test", how can that > > > > > option be passed in? > > > > > > > > # meson test -C build-debian --suite fast-tests --verbose -t 5 > > > > --test-args=3D--log-level=3Dlib.eal:debug > > > > > > https://paste.debian.net/1334095/ > > > > Could not repro this on Raspberry Pi 5. Main branch builds and runs > > There is no deadlock at play, as far as I can see. > > The mentionned commit slowed down thread instantiation (a lot, from > what the timestamps seen in the paste link). > The exact reason is not entirely clear to me, but it forced the thread > creating children threads to wait for them to start running. > Reverting this commit enhances the situation, but reintroduce a double > free (if set affinity of the created thread fails, both the parent and > the created thread will free ctx). > > I sent a patch, reintroducing use of pthread_attr_setaffinity_np like > Tyler had first proposed. > Let's see what the CI think of this. The change has been merged and OBS is now all green. You can disable the debug logs in your OBS package. Thanks. --=20 David Marchand