DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Stanislaw Kardach <kda@semihalf.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
	dev <dev@dpdk.org>,  Frank Zhao <Frank.Zhao@starfivetech.com>,
	Sam Grove <sam.grove@sifive.com>,
	 Marcin Wojtas <mw@semihalf.com>,
	upstream@semihalf.com,
	 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Subject: Re: [PATCH v2 1/1] test/ring: remove excessive inlining
Date: Mon, 23 May 2022 15:31:21 +0200	[thread overview]
Message-ID: <CAJFAV8ywjvePvjYMpZURCEF_KH0KGe2qSys0=izTFzi3xd=C8Q@mail.gmail.com> (raw)
In-Reply-To: <Ynva2//mlspxEt6C@bricha3-MOBL.ger.corp.intel.com>

On Wed, May 11, 2022 at 5:49 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Wed, May 11, 2022 at 05:07:25PM +0200, Stanislaw Kardach wrote:
> > Forcing inlining in test_ring_enqueue and test_ring_dequeue can cause
> > the compiled code to grow extensively when compiled with no optimization
> > (-O0 or -Og). This is default in the meson's debug configuration. This
> > can collide with compiler bugs and cause issues during linking of unit
> > tests where the api_type or esize are non-const variables causing
> > inlining cascade. In perf tests this is not the case in perf-tests as
> > esize and api_type are const values.
> >
> > One such case was discovered when porting DPDK to RISC-V. GCC 11.2 (and
> > no fix still in 12.1) is generating a short relative jump instruction
> > (J <offset>) for goto and for loops. When loop body grows extensively in
> > ring test, the target offset goes beyond supported offfset of +/- 1MB
> > from PC. This is an obvious bug in the GCC as RISC-V has a
> > two-instruction construct to jump to any absolute address (AUIPC+JALR).
> >
> > However there is no reason to force inlining as the test code works
> > perfectly fine without it.
> >
> > GCC has a bug report for a similar case (with conditionals):
> > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93062
> >
> > Fixes: a9fe152363 test/ring: add custom element size functional tests

Fixes: a9fe152363e2 ("test/ring: add custom element size functional tests")

> >
> > Signed-off-by: Stanislaw Kardach <kda@semihalf.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>

Applied, thanks.


-- 
David Marchand


  reply	other threads:[~2022-05-23 13:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-10 11:57 [PATCH " Stanislaw Kardach
2022-05-10 23:23 ` Honnappa Nagarahalli
2022-05-11  9:14   ` Bruce Richardson
2022-05-11 14:39   ` Stanisław Kardach
2022-05-11 15:07 ` [PATCH v2 " Stanislaw Kardach
2022-05-11 15:48   ` Bruce Richardson
2022-05-23 13:31     ` David Marchand [this message]
2022-05-11 16:51   ` Honnappa Nagarahalli
2022-05-19 22:50   ` Konstantin Ananyev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8ywjvePvjYMpZURCEF_KH0KGe2qSys0=izTFzi3xd=C8Q@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=Frank.Zhao@starfivetech.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=kda@semihalf.com \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=mw@semihalf.com \
    --cc=sam.grove@sifive.com \
    --cc=upstream@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).