From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 157D045CF0; Tue, 12 Nov 2024 11:38:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDFBE42D92; Tue, 12 Nov 2024 11:38:00 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8EAD842D91 for ; Tue, 12 Nov 2024 11:37:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731407879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uFL3hzRMS5eYthfVdbWDdQmpg/TpeqyJm+po12OFAwk=; b=DV8MKJD7QTO0uFwtZOGYyrV0rt4u1yoQgzvM5CqZCQ3X1Jx1LoF35GfIL9O4w4heFb1S/f jxiR4UQdaQqpUdgkAtXRU1gQkbtLzWvHCeDYdUmUVH1oGxRwXZWtWD6XHqvkm+tAN4snZx RURNWM0q00oecqZlKicMGG6FCFDl1jU= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-GzjveeGRMn-5PmQ5mAWAFQ-1; Tue, 12 Nov 2024 05:37:58 -0500 X-MC-Unique: GzjveeGRMn-5PmQ5mAWAFQ-1 X-Mimecast-MFC-AGG-ID: GzjveeGRMn-5PmQ5mAWAFQ Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2fb6509b841so25419061fa.0 for ; Tue, 12 Nov 2024 02:37:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731407876; x=1732012676; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uFL3hzRMS5eYthfVdbWDdQmpg/TpeqyJm+po12OFAwk=; b=rDW/jL1lyEkwzfpf73gg0eIRDC2xGy3Yz2YMNk3CBOp/MRXXLrO50S1UefJZ4uR3uS z6L3REKNh+i3zZ0VS/j6pXBu/WBYpZ8xtd0vTwkRf7K8n7ST/d934JbCiWCCMD876MTn r7GL8g3ndNRtUyRANuc0wUMkAqpnNgxz+XKKocShpUGCfN84e/dYhchzNVlFjFRt79XU 9np6KXd0WnJNvT5lhzt7v4/w8rG3AuWaIVyjRaqwqCKEtmVWylOvUm/deP9JupXZs3yt w8kO1vjwLPt5j7gWLH52WkXgvSEbpvKDpSzRx/MXKMnCbrPnCyc2Vzn+xTS2xr2fDNy1 rpAw== X-Forwarded-Encrypted: i=1; AJvYcCUPiwhzEzoM+MES8O4EU2WkTP71AptgvLBCtF9GBZjWI7l6/VSMDxfHMWMCjYehuVpNZjM=@dpdk.org X-Gm-Message-State: AOJu0Yy8TcyW/iuQ3vGLL6zdfViKA05HuiwUag+rVTValW8GA5MZ2n0M WVIcsIJ8tMfpZGHnpGYROhPDq81HfyDZJwxlrzKsTS5Vhz7qKVeU2byJ9Syz5ujGoY4ePZ9AXkZ TWhl50YCWxjpbkqwtnclV1hARPj2GieJ3qREBXFjVQqRoCU4FtdqJwWuqoeNEmNARx/cRhfllII x/93AroCqDJ5ZQ/uM= X-Received: by 2002:a2e:9a16:0:b0:2f7:58a3:6892 with SMTP id 38308e7fff4ca-2ff1f0e885fmr52741951fa.0.1731407876384; Tue, 12 Nov 2024 02:37:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnBDRV+xfXq5UTmwM+TjwzQ0v9TD+oGvh5uef6v/Di9oqVlqGmj+rrieYLPMt+HPteoZlNjsHV5hsfcW4qx0g= X-Received: by 2002:a2e:9a16:0:b0:2f7:58a3:6892 with SMTP id 38308e7fff4ca-2ff1f0e885fmr52741841fa.0.1731407875966; Tue, 12 Nov 2024 02:37:55 -0800 (PST) MIME-Version: 1.0 References: <20241023051139.1066426-1-sivaprasad.tummala@amd.com> <20241028195556.450033-1-sivaprasad.tummala@amd.com> <5996777.Isy0gbHreE@thomas> In-Reply-To: From: David Marchand Date: Tue, 12 Nov 2024 11:37:44 +0100 Message-ID: Subject: Re: [PATCH v10 0/6] power: refactor power management library To: Sivaprasad Tummala , Thomas Monjalon Cc: david.hunt@intel.com, anatoly.burakov@intel.com, jerinj@marvell.com, radu.nicolau@intel.com, gakhil@marvell.com, cristian.dumitrescu@intel.com, lihuisong@huawei.com, ferruh.yigit@amd.com, konstantin.ananyev@huawei.com, dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: oLGoipvdwlOqfUumQIcyFBoD1dXDUy94C-bO65w4Bnc_1731407876 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 12, 2024 at 9:20=E2=80=AFAM David Marchand wrote: > > Hello Siva, Thomas, > > On Sun, Nov 10, 2024 at 7:36=E2=80=AFPM Thomas Monjalon wrote: > > > > 28/10/2024 20:55, Sivaprasad Tummala: > > > This patchset refactors the power management library, addressing both > > > core and uncore power management. The primary changes involve the > > > creation of dedicated directories for each driver within > > > 'drivers/power/core/*' and 'drivers/power/uncore/*'. > > > > > > This refactor significantly improves code organization, enhances > > > clarity, and boosts maintainability. It lays the foundation for more > > > focused development on individual drivers and facilitates seamless > > > integration of future enhancements, particularly the AMD uncore drive= r. > > > > > > Furthermore, this effort aims to streamline code maintenance by > > > consolidating common functions for cpufreq and cppc across various > > > core drivers, thus reducing code duplication. > > > > > > Sivaprasad Tummala (6): > > > power: refactor core power management library > > > power: refactor uncore power management library > > > test/power: removed function pointer validations > > > drivers/power: uncore support for AMD EPYC processors > > > maintainers: update for drivers/power > > > power: rename library sources for cpu frequency management > > > > I'm a bit sad there is not more reviews. > > > > I've moved the pointers check removal first, > > renamed intel_pstate files (not the functions), > > fixed few things like __cplusplus, include guards, > > sorting and maintainers file. > > > > Applied > > This series breaks compilation of the vm_power_manager example as the > "guest channel" API symbols are not provided by the power library > (itself) anymore. > > ninja: Entering directory `/home/dmarchan/builds/main/build-gcc-shared' > [3355/3373] Linking target examples/dpdk-guest_cli > FAILED: examples/dpdk-guest_cli > gcc -o examples/dpdk-guest_cli > examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_main.c.o > examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_parse.c.o > examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_vm_power_cli_guest.c= .o > -Wl,--as-needed -Wl,--no-undefined -Wl,--no-as-needed > -Wl,--undefined-version -pthread -Wl,--start-group -lm -ldl -lnuma > -lfdt '-Wl,-rpath,$ORIGIN/../lib' > -Wl,-rpath-link,/home/dmarchan/builds/main/build-gcc-shared/lib > lib/librte_eal.so.25.0 lib/librte_kvargs.so.25.0 > lib/librte_log.so.25.0 lib/librte_telemetry.so.25.0 > lib/librte_mempool.so.25.0 lib/librte_ring.so.25.0 > lib/librte_net.so.25.0 lib/librte_mbuf.so.25.0 > lib/librte_ethdev.so.25.0 lib/librte_meter.so.25.0 > lib/librte_cmdline.so.25.0 lib/librte_power.so.25.0 > lib/librte_timer.so.25.0 -lpcap -lvirt /usr/lib64/libbsd.so > /usr/lib64/libarchive.so -Wl,--end-group > /usr/bin/ld: examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_vm_powe= r_cli_guest.c.o: > in function `check_response_cmd': > /home/dmarchan/builds/main/build-gcc-shared/../../../git/pub/dpdk.org/mai= n/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:382: > undefined reference to `rte_power_guest_channel_receive_msg' > /usr/bin/ld: examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_vm_powe= r_cli_guest.c.o: > in function `query_data': > /home/dmarchan/builds/main/build-gcc-shared/../../../git/pub/dpdk.org/mai= n/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:147: > undefined reference to `rte_power_guest_channel_send_msg' > /usr/bin/ld: examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_vm_powe= r_cli_guest.c.o: > in function `receive_capabilities': > /home/dmarchan/builds/main/build-gcc-shared/../../../git/pub/dpdk.org/mai= n/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:271: > undefined reference to `rte_power_guest_channel_receive_msg' > /usr/bin/ld: examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_vm_powe= r_cli_guest.c.o: > in function `send_policy': > /home/dmarchan/builds/main/build-gcc-shared/../../../git/pub/dpdk.org/mai= n/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:476: > undefined reference to `rte_power_guest_channel_send_msg' > /usr/bin/ld: examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_vm_powe= r_cli_guest.c.o: > in function `query_data': > /home/dmarchan/builds/main/build-gcc-shared/../../../git/pub/dpdk.org/mai= n/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:147: > undefined reference to `rte_power_guest_channel_send_msg' > /usr/bin/ld: examples/dpdk-guest_cli.p/vm_power_manager_guest_cli_vm_powe= r_cli_guest.c.o: > in function `receive_freq_list': > /home/dmarchan/builds/main/build-gcc-shared/../../../git/pub/dpdk.org/mai= n/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c:161: > undefined reference to `rte_power_guest_channel_receive_msg' > collect2: error: ld returned 1 exit status > [3357/3373] Generating drivers/rte_common_cnxk.sym_chk with a custom > command (wrapped by meson to capture output) > ninja: build stopped: subcommand failed. > > Siva, please have a look quickly. > > Here is a quick fix written before first coffee of the day. I ended up sending this as a patch: https://patchwork.dpdk.org/project/dpdk/patch/20241112103454.1543861-1-davi= d.marchand@redhat.com/ --=20 David Marchand