From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E593DA00C2; Wed, 22 Apr 2020 10:43:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 54F261C240; Wed, 22 Apr 2020 10:43:09 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 75E311C220 for ; Wed, 22 Apr 2020 10:43:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587544987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xtqZ3K9OfU/yUO7NCcOraAQWOCh2ZXv08BKZ7CWpTuM=; b=iszfhr70LXWSpf8OPdQvHQAszu/idgTNKFs7ItSbm1/szjXS4htff51m921lbFj+eDCqUb SDk0XLpqwRikD0crJ+ekh/9fqUYFb7rxJQxnTVeQoLhn75Wul/8aSFuuwI68lCcp5RnIWd vDz5gZW112TmbNhORvRlWvad1ETfSB8= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-395-Zbob018pPL6KQrSzFPkHKg-1; Wed, 22 Apr 2020 04:43:04 -0400 X-MC-Unique: Zbob018pPL6KQrSzFPkHKg-1 Received: by mail-ua1-f69.google.com with SMTP id x6so581037uaj.13 for ; Wed, 22 Apr 2020 01:43:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UUpJBkcAd4wHNKpQ8ywLz18TCXgmdqjMx/BYnDRZg/8=; b=BhLZDU1l/yQ1SSRBI8KrAHqvCKbDsgj6kVCIlDYbwPUd+ZbqPeCT4yWhMpfzGzkHco pRUlHGSuxb0UThN5hDdp1erpjlTYrtIEn4+EjDhRyZoyLYkcq6yqC8DOy8bppd9RP+oR fxVygDMqa9nsnWz3LIGYhmBT0e4hubzAJURwodaoiJwYi3ShNE/vCvWrfg48O4Jschdl KeGLeUDSKsby5WB1Wp6c7BfnP71YWnjzn3mquvRkK5wddyiKKj8SFVkRYTkMhH2MCeqC J/B09r/d8pMJXvAFibyRJbX+5TBcvLAYCaOJagqy6zQCBF/2tRYunC7w5gCk1Unwlrrm O8Zw== X-Gm-Message-State: AGi0PuY6ljfPWs9oE7t47pgGuTwrlA93xBWahAy55xlfRUoLMV74d+dG 3vojI1+dI/NLYTGy5NcOWhMv/J3bVkhjwwOwnrq/waNyOfPtzrvju1QnfTVIyCpPu8L3JHvu4TG KIPzYjVRzVP1YQqbWErM= X-Received: by 2002:a1f:1255:: with SMTP id 82mr18639146vks.80.1587544983477; Wed, 22 Apr 2020 01:43:03 -0700 (PDT) X-Google-Smtp-Source: APiQypIfbeL23UseLCweTqZdiU7QE02vLl4slqffdJLxQT2UTa8JslysEQiMa1bwCJ2OStgrjndhs99B1eBcN17X77o= X-Received: by 2002:a1f:1255:: with SMTP id 82mr18639130vks.80.1587544983066; Wed, 22 Apr 2020 01:43:03 -0700 (PDT) MIME-Version: 1.0 References: <20191001062917.35578-1-honnappa.nagarahalli@arm.com> <20200422033006.1124-1-honnappa.nagarahalli@arm.com> <20200422033006.1124-2-honnappa.nagarahalli@arm.com> In-Reply-To: From: David Marchand Date: Wed, 22 Apr 2020 10:42:51 +0200 Message-ID: To: "Ananyev, Konstantin" Cc: Honnappa Nagarahalli , "stephen@networkplumber.org" , "Medvedkin, Vladimir" , "dev@dpdk.org" , "ruifeng.wang@arm.com" , "dharmik.thakkar@arm.com" , "nd@arm.com" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v5 1/4] lib/rcu: add resource reclamation APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 22, 2020 at 10:37 AM Ananyev, Konstantin wrote: > > > Add resource reclamation APIs to make it simple for applications > > and libraries to integrate rte_rcu library. > > > > Signed-off-by: Honnappa Nagarahalli > > Reviewed-by: Ola Liljedhal > > Reviewed-by: Ruifeng Wang > > Acked-by: Konstantin Ananyev > > --- > > lib/librte_rcu/Makefile | 2 +- > > lib/librte_rcu/meson.build | 7 + > > lib/librte_rcu/rcu_qsbr_pvt.h | 66 +++++++++ > > lib/librte_rcu/rte_rcu_qsbr.c | 227 ++++++++++++++++++++++++++++- > > lib/librte_rcu/rte_rcu_qsbr.h | 194 +++++++++++++++++++++++- > > lib/librte_rcu/rte_rcu_version.map | 4 + > > lib/meson.build | 6 +- > > 7 files changed, 501 insertions(+), 5 deletions(-) > > create mode 100644 lib/librte_rcu/rcu_qsbr_pvt.h > > > > diff --git a/lib/librte_rcu/Makefile b/lib/librte_rcu/Makefile > > index 728669975..553bca2ef 100644 > > --- a/lib/librte_rcu/Makefile > > +++ b/lib/librte_rcu/Makefile > > @@ -7,7 +7,7 @@ include $(RTE_SDK)/mk/rte.vars.mk > > LIB =3D librte_rcu.a > > > > CFLAGS +=3D $(WERROR_FLAGS) -I$(SRCDIR) -O3 > > -LDLIBS +=3D -lrte_eal > > +LDLIBS +=3D -lrte_eal -lrte_ring > > > > EXPORT_MAP :=3D rte_rcu_version.map > > > > diff --git a/lib/librte_rcu/meson.build b/lib/librte_rcu/meson.build > > index c009ae4b7..3eb2ace17 100644 > > --- a/lib/librte_rcu/meson.build > > +++ b/lib/librte_rcu/meson.build > > @@ -3,3 +3,10 @@ > > > > sources =3D files('rte_rcu_qsbr.c') > > headers =3D files('rte_rcu_qsbr.h') > > + > > +# for clang 32-bit compiles we need libatomic for 64-bit atomic ops > > +if cc.get_id() =3D=3D 'clang' and dpdk_conf.get('RTE_ARCH_64') =3D=3D = false > > + ext_deps +=3D cc.find_library('atomic') > > +endif > > + > > As a nit - as Pavan patch is already integrated into mainline, > this is not necessary any more, I think. I can handle this. > Also noticed that most of make builds failed due to dependency problem: > http://mails.dpdk.org/archives/test-report/2020-April/127765.html > I can't reproduce it locally, but my guess that we need to move rcu above > ring in this mk file: mk/rte.app.mk > Probably something like that: > diff --git a/mk/rte.app.mk b/mk/rte.app.mk > index da12b9eec..8e5d023de 100644 > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -91,13 +91,13 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMPOOL) +=3D -lrt= e_mempool > _LDLIBS-$(CONFIG_RTE_LIBRTE_STACK) +=3D -lrte_stack > _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) +=3D -lrte_mempool_ring > _LDLIBS-$(CONFIG_RTE_LIBRTE_OCTEONTX2_MEMPOOL) +=3D -lrte_mempool_octeon= tx2 > +_LDLIBS-$(CONFIG_RTE_LIBRTE_RCU) +=3D -lrte_rcu > _LDLIBS-$(CONFIG_RTE_LIBRTE_RING) +=3D -lrte_ring > _LDLIBS-$(CONFIG_RTE_LIBRTE_PCI) +=3D -lrte_pci > _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL) +=3D -lrte_eal > _LDLIBS-$(CONFIG_RTE_LIBRTE_CMDLINE) +=3D -lrte_cmdline > _LDLIBS-$(CONFIG_RTE_LIBRTE_REORDER) +=3D -lrte_reorder > _LDLIBS-$(CONFIG_RTE_LIBRTE_SCHED) +=3D -lrte_sched > -_LDLIBS-$(CONFIG_RTE_LIBRTE_RCU) +=3D -lrte_rcu No, just moving will not express a dependency. --=20 David Marchand