From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EC26A0C4B; Tue, 2 Nov 2021 19:43:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BF684069F; Tue, 2 Nov 2021 19:43:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 4AC8440689 for ; Tue, 2 Nov 2021 19:43:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635878614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V/H9P71bdSxa4pQvZnNHjVrAlAsEFjiASnVQRZiic1A=; b=NBMhL/zix9BPQNctvoJcoyRMUE+iwAsti4GnejJHklHPr3G3lwu1GrAgOj0PZ3CqrPz3Hz UbYNvMD+xBUFOIKrh+bGtkGLWEIjms18hq26yG1JaiXPvGp1kLv2tJSmdGPo+9OcisJYIO mSfMr3nvZXr5gFbGPhUu6pYpRWrYcXI= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-5gyWuAyhOZW_LHYam9oiyA-1; Tue, 02 Nov 2021 14:43:33 -0400 X-MC-Unique: 5gyWuAyhOZW_LHYam9oiyA-1 Received: by mail-lj1-f198.google.com with SMTP id f6-20020a2e9e86000000b00211349f9ce3so8002893ljk.3 for ; Tue, 02 Nov 2021 11:43:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V/H9P71bdSxa4pQvZnNHjVrAlAsEFjiASnVQRZiic1A=; b=Z9zPPPfMhxaaPGVsAQFm8QNlqlyuR+qgaa294T/K0KZ8AoTUO5RlTzYVzbMzhpdBG+ YexGAt9ICRbOiLkKvOByL8XkBHrpiqIq1W0xStPNLhB6P+B1mluVKzKVTPgbU8n+bnt6 I2i8HI6Yu6P/qay/HwRcWLXnIVGnzwgdApaxJ0y8/yUORfWN1SDtnSjzXQlBXejE32Sv +qp1X+s3uKpWYPE1bvm+hRnbioHMaKhgtX+QpgkJlg17ush9M7D2QZJ7smPKWPx/09+O lye7d8dvS9dWz8qtcJf6c6jD1icJz2kodXSc7LUNKSGXI+JJxoPP7wmbDY/aZrEOuejZ AcIA== X-Gm-Message-State: AOAM531MYkZYT3mSLxyKGzzGW3i9MEl4Fk7HDdYqv8mFHtK7uPhdkz5k M+UOJyqAzzmMtgMIUFcTDNQCU/OPLpiXkUcAsaYdyL2CLF994pB9vYEMeBXtSUJ3His3v7o6Omz WF/1O8WloZv00FcIcgS4= X-Received: by 2002:a2e:8e76:: with SMTP id t22mr5521024ljk.81.1635878611965; Tue, 02 Nov 2021 11:43:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFCE3XSYQi/McnyPn9h8AMFImziBZtWR6w58+m/RYHutlb7EBZROF0JiYmrBeWmrMOajLIbPwpZ0JCWVdeNgg= X-Received: by 2002:a2e:8e76:: with SMTP id t22mr5521004ljk.81.1635878611743; Tue, 02 Nov 2021 11:43:31 -0700 (PDT) MIME-Version: 1.0 References: <20211102184020.438-1-david.marchand@redhat.com> In-Reply-To: <20211102184020.438-1-david.marchand@redhat.com> From: David Marchand Date: Tue, 2 Nov 2021 19:43:20 +0100 Message-ID: To: dev Cc: Yu Jiang Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal/linux: fix uevent message parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 2, 2021 at 7:41 PM David Marchand wrote: > > Caught with ASan: > ==9727==ERROR: AddressSanitizer: stack-buffer-overflow on address > 0x7f0daa2fc0d0 at pc 0x7f0daeefacb2 bp 0x7f0daa2fadd0 sp 0x7f0daa2fa578 > READ of size 1 at 0x7f0daa2fc0d0 thread T1 > #0 0x7f0daeefacb1 (/lib64/libasan.so.5+0xbacb1) > #1 0x115eba1 in dev_uev_parse ../lib/eal/linux/eal_dev.c:167 > #2 0x115f281 in dev_uev_handler ../lib/eal/linux/eal_dev.c:248 > #3 0x1169b91 in eal_intr_process_interrupts > ../lib/eal/linux/eal_interrupts.c:1026 > #4 0x116a3a2 in eal_intr_handle_interrupts > ../lib/eal/linux/eal_interrupts.c:1100 > #5 0x116a7f0 in eal_intr_thread_main > ../lib/eal/linux/eal_interrupts.c:1172 > #6 0x112640a in ctrl_thread_init > ../lib/eal/common/eal_common_thread.c:202 > #7 0x7f0dade27159 in start_thread (/lib64/libpthread.so.0+0x8159) > #8 0x7f0dadb58f72 in clone (/lib64/libc.so.6+0xfcf72) > > Address 0x7f0daa2fc0d0 is located in stack of thread T1 at offset 4192 > in frame > #0 0x115f0c9 in dev_uev_handler ../lib/eal/linux/eal_dev.c:226 > > This frame has 2 object(s): > [32, 48) 'uevent' > [96, 4192) 'buf' <== Memory access at offset 4192 overflows this > variable > HINT: this may be a false positive if your program uses some custom > stack unwind mechanism or swapcontext > (longjmp and C++ exceptions *are* supported) > Thread T1 created by T0 here: > #0 0x7f0daee92ea3 in __interceptor_pthread_create > (/lib64/libasan.so.5+0x52ea3) > #1 0x1126542 in rte_ctrl_thread_create > ../lib/eal/common/eal_common_thread.c:228 > #2 0x116a8b5 in rte_eal_intr_init > ../lib/eal/linux/eal_interrupts.c:1200 > #3 0x1159dd1 in rte_eal_init ../lib/eal/linux/eal.c:1044 > #4 0x7a22f8 in main ../app/test-pmd/testpmd.c:4105 > #5 0x7f0dada7f802 in __libc_start_main (/lib64/libc.so.6+0x23802) I sent the wrong patch, fixes ref is missing: Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process") Cc: stable@dpdk.org > > Signed-off-by: David Marchand -- David Marchand