From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26E97A00BE; Wed, 29 Apr 2020 13:40:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F26341DA61; Wed, 29 Apr 2020 13:40:11 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 98E721DA57 for ; Wed, 29 Apr 2020 13:40:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588160409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zqnFfV0kqMsZ+OE7KdBoz8adYdfG7Tb0jEu8ofWUe2w=; b=NS+MjNXO+lxEojqZAcR0SW4vnqmDE1kmDnh+AO25yCyoneGP5B7N1UySKiIQl5CQvTv81q McDjU5R9prG9F5qMg7A4t/9wRr1bE2O8R0T2d4Jwo/O5ZLmW0AHvuwznwQIHj+ceeuUWmd eCBH465EBVvytu2UoiAxnrRG56vYRLg= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-ijqB1aRkOOGKYA8rYglydA-1; Wed, 29 Apr 2020 07:40:07 -0400 X-MC-Unique: ijqB1aRkOOGKYA8rYglydA-1 Received: by mail-ua1-f72.google.com with SMTP id r11so953065ual.5 for ; Wed, 29 Apr 2020 04:40:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1w4BNzGdCNfQn8zZ3g6xTX+9OFiqtVGsI8w+5MkL5OQ=; b=elQ6FMy705AXi2jLTDDCTaX/CuVuEUYEVWW3LeHlozAilMP+BLDn8BS3qtMLs3LEQk dhm3qT6yfh41iWVupjtmGlGnVpddhCAq+fu/od6m/R78f+e1t1e3kOO/nXIemZl88F0y BZPkSMONPDMygOZIUn5Sy4uOhvg/MlvJ2U7hl+5YUDdESP9Z5gICRVB5J3GH0+NY96N0 IX8wFVZpAqz3ZHeT5Uwrvn9+VmMr6uX55zvmdaBWKd8XmREygqncoSQSFB+ogCFNbKYL ULJfVSLOwLwz5Rl3zSuCXEF2Ptz+9pRpbrJBPOTmB3QqsT/V3cJO9nLxDO2tL4TpfVQY NudA== X-Gm-Message-State: AGi0PuYnecDUGB74jCKp4rJ89gvgDJz7ltUumxknUIGD7jhutzW2c6Jb CmDzKbJoTUBycGEvUNv8U27ifSzGntAbh4xILc6/NH1f3pePZhWZdev7Ko80WFd5yeN2kY/za7O R7H3bjXKjgzz15GQBJFU= X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr25722399vsp.198.1588160407087; Wed, 29 Apr 2020 04:40:07 -0700 (PDT) X-Google-Smtp-Source: APiQypKXEv5iPYN9wXh3LQHWwsDL6tIRE797zllxLFJNfaod7Bq43dACwY6osLKo57ZnNuCP/AeJrgzlfeVRJHNp0Z8= X-Received: by 2002:a05:6102:4d:: with SMTP id k13mr25722379vsp.198.1588160406797; Wed, 29 Apr 2020 04:40:06 -0700 (PDT) MIME-Version: 1.0 References: <20200416110040.42819-1-kevin.laatz@intel.com> <20200428124026.43783-1-kevin.laatz@intel.com> <0c78eb80-8a82-9892-b388-e72f9afe7cb6@ashroe.eu> In-Reply-To: <0c78eb80-8a82-9892-b388-e72f9afe7cb6@ashroe.eu> From: David Marchand Date: Wed, 29 Apr 2020 13:39:55 +0200 Message-ID: To: Ray Kinsella Cc: Kevin Laatz , dev , Bruce Richardson , Van Haaren Harry , Thomas Monjalon , "Kinsella, Ray" , Neil Horman X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v5] eal/cpuflags: add x86 based cpu flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 28, 2020 at 6:39 PM Ray Kinsella wrote: > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignor= e > > index a59df8f13..045f436fb 100644 > > --- a/devtools/libabigail.abignore > > +++ b/devtools/libabigail.abignore > > Kevin - you still have the surpession. > I am testing locally with 1.7.1, and it doesn't complain when I disable t= he supression. > Are you seeing something different? Using current master libabigail, without the rule Kevin included, I get the warning: 1 function with some indirect sub-type change: [C] 'function int rte_cpu_get_flag_enabled(rte_cpu_flag_t)' at rte_cpuflags.c:144:1 has some indirect sub-type changes: parameter 1 of type 'enum rte_cpu_flag_t' has sub-type changes: type size hasn't changed 17 enumerator insertions: 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512DQ' value '87' 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512IFMA' value '88' 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512CD' value '89' 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512BW' value '90' 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512VL' value '91' 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512VBMI' value '92' 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512VBMI2' value '93' 'rte_cpu_flag_t::RTE_CPUFLAG_GFNI' value '94' 'rte_cpu_flag_t::RTE_CPUFLAG_VAES' value '95' 'rte_cpu_flag_t::RTE_CPUFLAG_VPCLMULQDQ' value '96' 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512VNNI' value '97' 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512BITALG' value '98' 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512VPOPCNTDQ' value '99' 'rte_cpu_flag_t::RTE_CPUFLAG_CLDEMOTE' value '100' 'rte_cpu_flag_t::RTE_CPUFLAG_MOVDIRI' value '101' 'rte_cpu_flag_t::RTE_CPUFLAG_MOVDIR64B' value '102' 'rte_cpu_flag_t::RTE_CPUFLAG_AVX512VP2INTERSECT' value '103' 1 enumerator change: 'rte_cpu_flag_t::RTE_CPUFLAG_NUMFLAGS' from value '87' to '104' at rte_cpuflags.h:12:1 Ray, could you check that the reference and new dumps in your env contain this enum? $ grep RTE_CPUFLAG_NUMFLAGS $HOME/abi/v20.02/x86_64-native-linux-gcc+shared+debug+ASSERT+RTE_IBVERBS_LI= NK_DLOPEN/dump/librte_eal.dump $ grep RTE_CPUFLAG_NUMFLAGS $HOME/builds/x86_64-native-linux-gcc+shared+debug+ASSERT+RTE_IBVERBS_LINK_D= LOPEN/install/dump/librte_eal.dump If you are missing those, you might have built dpdk without debuginfo. --=20 David Marchand