From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 21C9942DD8; Wed, 5 Jul 2023 15:36:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC995406B5; Wed, 5 Jul 2023 15:36:38 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AFEA34021F for ; Wed, 5 Jul 2023 15:36:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688564197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vQBluy+2YDpRi6kt7dBsc3oaUPLXnIYaI87cNAxLOOE=; b=CY1FFdVBdyba7rferxtiFR+KilySKGia6+K95NX3xxWfBA/Mg3GeMuWVnIgDBkRsQW6wfW u38Rf6ImWPIya7BbKTjjt1Q2drpVPiKmjODeXwt5n17CZ9F0L97IJHE0w0To4lmIOtcMA1 GIvziIMGWbQHN3MpJwZ3wJewYMQd31o= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-ypNnsdv9NUO5dthg63YdEQ-1; Wed, 05 Jul 2023 09:36:35 -0400 X-MC-Unique: ypNnsdv9NUO5dthg63YdEQ-1 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-1b8a4e947a1so9614135ad.1 for ; Wed, 05 Jul 2023 06:36:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688564195; x=1691156195; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vQBluy+2YDpRi6kt7dBsc3oaUPLXnIYaI87cNAxLOOE=; b=JQohyFkWc5mqzZQZnMUt5Dz9ebWS/hlblrq4SASs9G+shTIfX4eFu+dStvBuWSOxes GyrWFwJxHExX4M4VbtUAcLdnlbebVlVhgRQIe6fz4ZqEZQlIEfeq0mA13WzNcgQuBv5A Ya9G525+Ko7F2ui3mw71/3usTOfaXq/EudDZw8U/2EMcWFyaslasO26E8RXzcAddIrhw FsyZ5zbJp21V2MuV5T3LNqckqiNME9WTS2CXJAD6dvpHFlTrrL7CsImd/RutHvmsxanI L8vYMRIMRxpnozsFyjbLBVwkID7DKhVT5C27prVdQacrjt4Rl51An0C2La9V/4g2hTzr Q8fw== X-Gm-Message-State: ABy/qLZpwujRLtWK3DYqRuNsnVvUEKTSdhZewoS+U0fZqoLMwbFixSCE PbpdXV79RzI1hvoCMg0iNTd3NME3T3QJxZY7hkpLBwpeoRwugTgkuDZm20XUGXWvtnfS3x+j9AD k6ZyuSm1OUF7pLVR5/QY= X-Received: by 2002:a17:902:ecc1:b0:1b6:a37a:65b7 with SMTP id a1-20020a170902ecc100b001b6a37a65b7mr3829793plh.23.1688564194882; Wed, 05 Jul 2023 06:36:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlFJx9eivl808wqOXhhRTLetWESKj+ZZzSquj2Zq996llghlh3pLuWVV+gVKPDjykLIcokPw7xmkVicDMpd0Ghw= X-Received: by 2002:a17:902:ecc1:b0:1b6:a37a:65b7 with SMTP id a1-20020a170902ecc100b001b6a37a65b7mr3829764plh.23.1688564194590; Wed, 05 Jul 2023 06:36:34 -0700 (PDT) MIME-Version: 1.0 References: <20230705132232.114266-1-maxime.coquelin@redhat.com> <20230705132232.114266-2-maxime.coquelin@redhat.com> In-Reply-To: <20230705132232.114266-2-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 5 Jul 2023 15:36:23 +0200 Message-ID: Subject: Re: [PATCH 1/2] vhost: fix vduse features negotiation To: Maxime Coquelin Cc: dev@dpdk.org, chenbo.xia@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jul 5, 2023 at 3:22=E2=80=AFPM Maxime Coquelin wrote: > @@ -950,9 +954,14 @@ rte_vhost_driver_register(const char *path, uint64_t= flags) > * two values. > */ > vsocket->use_builtin_virtio_net =3D true; > - vsocket->supported_features =3D VIRTIO_NET_SUPPORTED_FEATURES; > - vsocket->features =3D VIRTIO_NET_SUPPORTED_FEATURES; > - vsocket->protocol_features =3D VHOST_USER_PROTOCOL_FEATURES; > + if (vsocket->is_vduse) { > + vsocket->supported_features =3D VDUSE_NET_SUPPORTED_FEATU= RES; > + vsocket->features =3D VDUSE_NET_SUPPORTED_FEATU= RES; > + } else { > + vsocket->supported_features =3D VIRTIO_NET_SUPPORTED_FEAT= URES; > + vsocket->features =3D VIRTIO_NET_SUPPORTED_FEAT= URES; > + vsocket->protocol_features =3D VHOST_USER_PROTOCOL_FEATU= RES; > + } > Would it make sense to split those features in a set of features shared by vhost-user and vduse, and one dedicated set for each of them? For example, the VIRTIO_NET_F_GUEST/HOST_* features are not bound to vhost-user / vduse, are they? --=20 David Marchand