From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0199542D04; Tue, 20 Jun 2023 09:09:59 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 89E1E4068E; Tue, 20 Jun 2023 09:09:59 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3E815400D6 for ; Tue, 20 Jun 2023 09:09:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687244997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TbgXFwajt+G6leoUsB8jMM2zdxGKaRuwpsJYL1cd7eQ=; b=gyoUo8LpdGyC9F1ZeTDRvkLU7u7U+axlWacGJjI29p3ec+VTGccoYOkgaqRYOwhip10o35 J0bzQaG2KwoNMKFKAy6L118Vzq2B9fbmOrVYOzQxwuz12Y/P95Zx93DPStxCxdEaCtbm6H hZx5V2WWdCW1AdgmB5KYprDS5GQ9jX8= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-36-bPh2XfylMIKKjVF0-BDGFA-1; Tue, 20 Jun 2023 03:09:56 -0400 X-MC-Unique: bPh2XfylMIKKjVF0-BDGFA-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-25ea8fb138fso2603298a91.1 for ; Tue, 20 Jun 2023 00:09:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687244995; x=1689836995; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TbgXFwajt+G6leoUsB8jMM2zdxGKaRuwpsJYL1cd7eQ=; b=U4/IBefU1eHXplKS4q42O9mzv7kCTI9GVTkfdveY2R8/Mz6W/+t7YxABFWgnISuk16 4LAvHAYTV5XzesR8xjFFcfNcndcLVzx+SJ7veaQ53DETLxgfg9skkYhH9pvQt5QSXIsL GV4Fut7KtWFNNNNxFc2euF+ss5M2KfIDOG/f/h3wYW33l6RWale9HGzGOzzp6alFzZUD YucyRBrJboVHlWlyUQBbt4FU8zyB+RHA9s7XlG+8VhudQtj9vG/tFudrRHB94+6cvEvU 21S07eF5C7bGrcxaaNtiumYJ1dXGOiXk1B2OJvouAagxvJW/q2Ij6GJs5voNhIC6lowq iasA== X-Gm-Message-State: AC+VfDzYRuEN0csQ7anUItGludYoTjdBf0dBJHyzt0O0wIDzJHJWdnej FNeVHBivMzzLmdbTkXuiWQmhyGy5wm8NZkYcDKKieAJ0ZbLlG/+q6L7RHT1DMK5sRewrgo4QP1T oQzHwpjk6BaSGFaRMl/U= X-Received: by 2002:a17:90a:4145:b0:23f:9445:318e with SMTP id m5-20020a17090a414500b0023f9445318emr15132897pjg.3.1687244995268; Tue, 20 Jun 2023 00:09:55 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Jzstfssf/gLKJ6SQo2UA+OSiwA4sdjfS0PCadVnzWO+7a8izbs+aELG6sw/4bBkM7QYax5cwFmjKMVysUChE= X-Received: by 2002:a17:90a:4145:b0:23f:9445:318e with SMTP id m5-20020a17090a414500b0023f9445318emr15132888pjg.3.1687244994969; Tue, 20 Jun 2023 00:09:54 -0700 (PDT) MIME-Version: 1.0 References: <20230619204650.3348681-1-david.marchand@redhat.com> <20230619204650.3348681-2-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Tue, 20 Jun 2023 09:09:43 +0200 Message-ID: Subject: Re: [PATCH 2/2] lib: make graph optional To: Jerin Jacob Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jun 20, 2023 at 8:56=E2=80=AFAM Jerin Jacob = wrote: > > On Tue, Jun 20, 2023 at 2:17=E2=80=AFAM David Marchand > wrote: > > > > Allow disabling of the graph library in builds. > > Good to make graph as optional. > I did not check the build, will examples/l3fwd-graph/ skip automatically = ? Yes. Each example exposes its required dependencies. examples/meson.build will skip any example with unmet requirements unless the example was explicitly set in the -Dexamples=3D list of examples to build. See: https://git.dpdk.org/dpdk/tree/examples/meson.build#n105 https://git.dpdk.org/dpdk/tree/examples/meson.build#n79 https://git.dpdk.org/dpdk/tree/examples/meson.build#n117 > > > > > Signed-off-by: David Marchand > > --- > > +if dpdk_conf.has('RTE_LIB_GRAPH') > > Can devtools/test-meson-builds.sh updated to check build with > disabling all optional libs? I already tested this series with our script: we already have a "mini" targ= et. build build-mini cc skipABI $use_shared -Ddisable_libs=3D* \ -Denable_drivers=3Dnet/null ... Message: Skipping example "l2fwd-jobstats" Library rt found: YES Message: Missing dependency "graph" for example "l3fwd-graph" Message: Skipping example "l3fwd-graph" Message: Missing dependency "power" for example "l3fwd-power" Message: Skipping example "l3fwd-power" ... --=20 David Marchand