From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64BFC459D1; Thu, 19 Sep 2024 09:44:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 35D464068A; Thu, 19 Sep 2024 09:44:38 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 011CD402D4 for ; Thu, 19 Sep 2024 09:44:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726731876; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1lV05+GFod4mau63RksvPYQa5dVOaMEvfQnB2LsrHFY=; b=QuOpQVFFAIKopSgN8uQOBQPmmlOhqzEllxu58uP1AJUioBzgVWUoyjRtIIDG1UOfrELM0a 9f4ySuergOyh+PRPIp+AKKJHxZrrxwbKDW7nT9ehFrhl+RXxQqwjyTPho9KSaS4/R4ajKn gBf6x0HZtnm/3JtyuORH9xi87sn+dU0= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-176-f13cgzKtNFCMeo89R83tig-1; Thu, 19 Sep 2024 03:44:34 -0400 X-MC-Unique: f13cgzKtNFCMeo89R83tig-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2f761cfa667so3686731fa.3 for ; Thu, 19 Sep 2024 00:44:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726731873; x=1727336673; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1lV05+GFod4mau63RksvPYQa5dVOaMEvfQnB2LsrHFY=; b=VEE2evp5LkQoDdQYvfah6mtnv8dDWdSlZ3Spi5N0JB54zPUr2127j8k39m6OZOSNYH 4ETH/EYM0iiZt/qYVVMUJrGoHnjbIveEKKQhPGk8/HqxJL0K0sKANDCiM/x5/DRPzdLl Q7xvhyM2t1KZHUedRMZU4NGEYn/dTaE673kxEkuw7KpggMM5KtlHFgRjPuoR+VL6t9rl 1AmdJ0SHXnRPYQP6wgaf15TRpSaecsppYfu3UWgtc3l34c+8OnnZwAmESSW+tnS3qSIg MpMwR+jwubuL87FvpkXwLMu8VmJD5kPbsMo+G/ZElHmc2CjzreCKPze5UZpo23bKOG90 fdKw== X-Gm-Message-State: AOJu0YxcoslpX/vWTPjgaYX8ghNDJgZ6K6JUqyiVfpT9awQPc1j3jDQ8 sl97OAG1/l9Esuf24f5+Tke1d//5ZUbBUDTHol10XI2WB2MNpDhO0IgLXl2S6qxvI6mr43npE33 i4IE9Z7FUBVLFf9UQe0PnOUNZvVLCfKtWkxA9wB5N++3ZVyVAG1RdjSQ50pfvvbDBdwTX4CjIJx c7Z3sN96P3t2hocgM= X-Received: by 2002:a2e:702:0:b0:2f7:500c:2212 with SMTP id 38308e7fff4ca-2f787db9159mr98282551fa.10.1726731873255; Thu, 19 Sep 2024 00:44:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGECMIv2tu/sG4eIJ2C/55tpZq7Lr1sz/qVj9HEiiAHbKBTYjk7Yai67ZESPqObNZe/GxtWD6dPZHlmPpiWE1k= X-Received: by 2002:a2e:702:0:b0:2f7:500c:2212 with SMTP id 38308e7fff4ca-2f787db9159mr98282411fa.10.1726731872825; Thu, 19 Sep 2024 00:44:32 -0700 (PDT) MIME-Version: 1.0 References: <20240904135939.329324-1-bruce.richardson@intel.com> <20240906161244.1663967-1-bruce.richardson@intel.com> In-Reply-To: <20240906161244.1663967-1-bruce.richardson@intel.com> From: David Marchand Date: Thu, 19 Sep 2024 09:44:18 +0200 Message-ID: Subject: Re: [PATCH v2 0/4] simplify doing 32-bit DPDK builds To: Bruce Richardson Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 6, 2024 at 6:13=E2=80=AFPM Bruce Richardson wrote: > > To make it easier to build and test DPDK on 32-bit x86 add a set of > cross-compile ini files for a number of common linux distributions. > This avoids the user having to remember strange meson incantations > with '-m32' in various args values and with the PKG_CONFIG_LIBDIR > overridden in the environment. > > Bruce Richardson (4): > config: add 32-bit x86 debian cross-compilation file > config: add fedora 32-bit x86 cross-compile file > config: add arch 32-bit cross-compilation file > devtools/test-meson-builds: use cross files for 32bit build > > config/x86/cross-32bit-arch.ini | 22 ++++++++++++++++++++++ > config/x86/cross-32bit-debian.ini | 22 ++++++++++++++++++++++ > config/x86/cross-32bit-fedora.ini | 22 ++++++++++++++++++++++ > devtools/test-meson-builds.sh | 13 +++++-------- > 4 files changed, 71 insertions(+), 8 deletions(-) > create mode 100644 config/x86/cross-32bit-arch.ini > create mode 100644 config/x86/cross-32bit-debian.ini > create mode 100644 config/x86/cross-32bit-fedora.ini I tried to convert the GHA script to use the debian cross file introduced in the series: diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index 15ed51e4c1..cec8742ed1 100755 --- a/.ci/linux-build.sh +++ b/.ci/linux-build.sh @@ -54,6 +54,10 @@ if [ "$AARCH64" =3D "true" ]; then fi fi +if [ "$BUILD_32BIT" =3D "true" ]; then + cross_file=3Dconfig/x86/cross-32bit-debian.ini +fi + if [ "$MINGW" =3D "true" ]; then cross_file=3Dconfig/x86/cross-mingw fi @@ -76,12 +80,6 @@ if [ "$BUILD_DOCS" =3D "true" ]; then OPTS=3D"$OPTS -Denable_docs=3Dtrue" fi -if [ "$BUILD_32BIT" =3D "true" ]; then - OPTS=3D"$OPTS -Dc_args=3D-m32 -Dc_link_args=3D-m32" - OPTS=3D"$OPTS -Dcpp_args=3D-m32 -Dcpp_link_args=3D-m32" - export PKG_CONFIG_LIBDIR=3D"/usr/lib32/pkgconfig" -fi - if [ "$MINGW" =3D "true" ]; then OPTS=3D"$OPTS -Dexamples=3Dhelloworld" elif [ "$DEF_LIB" =3D "static" ]; then I was then surprised to read the result: ... 2024-09-19T07:22:12.6485260Z Checking for size of "void *" : 8 2024-09-19T07:22:12.6485592Z Checking for size of "void *" : 8 ... *scratch* *scratch* So I retested the series locally on my f39 (the series seemed ok so far) but I downgraded meson to 0.53.2 (which is the version forced in GHA) and now I observe the same issue. I suspect something changed in the cross file handling in more recent meson versions. Likely, the c_args=3D or [build-in options] part is not read. Am I doing something wrong? --=20 David Marchand