From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D3E8436CE; Tue, 12 Dec 2023 08:50:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0973342DCE; Tue, 12 Dec 2023 08:50:52 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B5FC042DC7 for ; Tue, 12 Dec 2023 08:50:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702367449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6rRrHn5Jtwd2BpFqYxzhvm+SYHWOIb0qcn+Rmpyie+Q=; b=ggcw4zleGo5/bDtZ1MC/YYzKSsVqHGoTHsVLu06Use7OqAKLqoXzUXXTRTYbfO/BenUqe+ YLDRiEdvwpFyIYLfhOV6vUqT2G7bPLbcxwzh6+V9vKATslc4Fv7g6KuwjCBNmj8oIzY2g+ OeOLG/JWASf4Qu0BHk6HL9ABQ2rR0Vk= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-44-mKn460qUMtW8emVcM_zlnw-1; Tue, 12 Dec 2023 02:50:48 -0500 X-MC-Unique: mKn460qUMtW8emVcM_zlnw-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ca328270b0so45832801fa.3 for ; Mon, 11 Dec 2023 23:50:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702367446; x=1702972246; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6rRrHn5Jtwd2BpFqYxzhvm+SYHWOIb0qcn+Rmpyie+Q=; b=B8yPq2zFb+AryGeXvp3Jo1vVEaYHOjbFVjvp1ZG8aDAewgA7+7pjeAswCHudxVCb6+ fC099CCWyXqECtezns3Yvrm0q+eekoB8TezYbqPdV9H0RhVAx+Aoibtxwey6wgPM1rBm 0qwfCsR9iVvNMHRRY9WI7iwUcNyU5j82UwQde114fb3xrvTccbnu5gecWhNJXTCJq8+r U1kaURD3K8gqj/S+uhmkFFhYEAlqMLgUlzP+orgZbQFiFbgbZy6jLTvJ+VsnZM1vOImh 9Ft//tXoQj7Vpbk3ZErJI0SbBHi9t64jY1DDTI4wbN3ZmDve96oOgPH/B3W+2knNuKQ8 WWMw== X-Gm-Message-State: AOJu0Yz6np/JzJX/nUH0hnI6H64Ybq3hZMh0OS/7mG/P+/YjY9oeqvON uJ1ed/h4/DHmrKdwPnv4DGP04SQQROtcE2CkdHoqbxA7h+3UzZwmh+Z98BN6PkPLQRchZBnU6r8 D/kKL6mGXz19PAaG6Bhk= X-Received: by 2002:a05:651c:198c:b0:2cc:1da8:2e4e with SMTP id bx12-20020a05651c198c00b002cc1da82e4emr1601832ljb.14.1702367446676; Mon, 11 Dec 2023 23:50:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IHo4nK+sEOHfLjQ1xLhyoEqLY7lNgcXVqxOh5W8L88TOTZDUzAJBaVQTIuikoBsL0ITS5XQtDlvsDBFE2GKu40= X-Received: by 2002:a05:651c:198c:b0:2cc:1da8:2e4e with SMTP id bx12-20020a05651c198c00b002cc1da82e4emr1601828ljb.14.1702367446404; Mon, 11 Dec 2023 23:50:46 -0800 (PST) MIME-Version: 1.0 References: <20231211201733.127771-1-stephen@networkplumber.org> In-Reply-To: <20231211201733.127771-1-stephen@networkplumber.org> From: David Marchand Date: Tue, 12 Dec 2023 08:50:34 +0100 Message-ID: Subject: Re: [PATCH] cryptodev: convert to dynamic logtype To: Stephen Hemminger , Akhil Goyal Cc: dev@dpdk.org, Fan Zhang X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Dec 11, 2023 at 9:18=E2=80=AFPM Stephen Hemminger wrote: > > The cryptodev logs are all referenced via rte_crytpodev.h crypto* > so make it dynamic there. > > Signed-off-by: Stephen Hemminger I would add a comment in the header that this exported logtype variable is for internal use. Otherwise it lgtm. Akhil, do you mind if I take this directly in main? --=20 David Marchand