From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5A3E4601D; Wed, 8 Jan 2025 13:01:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BC104014F; Wed, 8 Jan 2025 13:01:41 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id DF030400D6 for ; Wed, 8 Jan 2025 13:01:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736337698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pyrpC3GnEykZSvPnbI1nrUnwSO8dXDchQwS2Pv/G2EQ=; b=LyCwC7qLUqJrGtqTkafk/ghlY7/GCdVg2hwnsKWPyE6lbo3y7GGI/EU7rUeGKF8wtoKEP2 xLQ0m+9Tnp7tO3bpuYBaj+G7p8tGCjyu6tCEyAXcGNozca6q1yiLpeLMTOQBVWroko3avM LWiNEhEtINvWDTLU5nkxvh9Ty1D1jKw= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-153-Xa2nTXF4O_2w0BdzuoC3gg-1; Wed, 08 Jan 2025 07:01:37 -0500 X-MC-Unique: Xa2nTXF4O_2w0BdzuoC3gg-1 X-Mimecast-MFC-AGG-ID: Xa2nTXF4O_2w0BdzuoC3gg Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-53faf9e6195so353347e87.0 for ; Wed, 08 Jan 2025 04:01:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736337695; x=1736942495; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pyrpC3GnEykZSvPnbI1nrUnwSO8dXDchQwS2Pv/G2EQ=; b=pWVi+RNkpvds/lmBKLhp9jarOJqj+F6LkCk5IRXDRZehZ2IGUk/itCz0Cr0hjOHyDz E3yy3WuW2TlR2pHmZqsDkJzTd0p5B0hODlxHdp66tFiPSWyJTjL9tDClE8j3JFsT6r1J 6iaiNcoyVPq/Fud4H2c91liAOOeTPBNsFHifIIXaCDOuXjrH9MlOP7ifJNrIenIv+Y// wkZPXHIYjtI04JkANsMsPFyVq2g1gaz9PhtMnUv+IIXs49tLECO5StsC7Umy44L3kv4D flbNzLd/giQZhueQjuLkeCxD37Xk2RbFcQEUB3ROCqa8w2SGArk9My3XN6ySR8qenRfC yQaw== X-Forwarded-Encrypted: i=1; AJvYcCVyglFszTXpDqVrXXC3FCScTtKSYXtAjSXwpcmVnWDOkeJeYZhLhFpuv0NG/zsWiktEbww=@dpdk.org X-Gm-Message-State: AOJu0YyOkBAxlJdFrKz3G8uQpk0NvHkyWxWXx4OJMVfJ+zuMHUrv0OSf 6mZzvtObu0cB2KX2pKQmDmpM/TY1Txn/Y+SSaQpiZGqoQljFdCUWgBE9y5ghpy56UMC6l1B8bCg QKmIuUDS8hdUWTtfg65FuFHcIEpwc1MZjfAhHoEbosSPTl2va/TvHg+PIU9XGUipiETvE6TD6Pf 8gj6KEMrFQz8UTbOM= X-Gm-Gg: ASbGnctFiB30CV7uLUPwpPvULX5OmiEwyP94pdNBG8rLnIuI6aRlwtLRJ50v0q4Pslg jC4xJIPgIutbseCmaMFXp1bYjHXpBeRYj0USqqm7C X-Received: by 2002:a05:6512:1287:b0:540:2d60:d6ce with SMTP id 2adb3069b0e04-5427e9ca4f9mr2068865e87.24.1736337695390; Wed, 08 Jan 2025 04:01:35 -0800 (PST) X-Google-Smtp-Source: AGHT+IElW6jC1omyucEBhNsy+XWKCoxD3aVLXgGa0dT6FoLyIv/4AiqXKsUGruyh7DlTp5TrlHCiJ3ryba+PsAY+0Kg= X-Received: by 2002:a05:6512:1287:b0:540:2d60:d6ce with SMTP id 2adb3069b0e04-5427e9ca4f9mr2068856e87.24.1736337694988; Wed, 08 Jan 2025 04:01:34 -0800 (PST) MIME-Version: 1.0 References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1735670291-23224-1-git-send-email-andremue@linux.microsoft.com> <1735670291-23224-28-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1735670291-23224-28-git-send-email-andremue@linux.microsoft.com> From: David Marchand Date: Wed, 8 Jan 2025 13:01:23 +0100 X-Gm-Features: AbW1kvYfGFiKEjasx99Kx2-OyJQHqtaJzBZx6Lt0wihReNYYy4xGHPuQ2qgjVSY Message-ID: Subject: Re: [PATCH v8 27/29] lib/net: replace packed attributes To: Andre Muezerie Cc: roretzla@linux.microsoft.com, dev@dpdk.org, Thomas Monjalon , Robin Jarry X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bhzzUGwwtk1iijoK8zyTcUTFMeqp4CxIxYSRFwZUG5Q_1736337695 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 31, 2024 at 7:40=E2=80=AFPM Andre Muezerie wrote: > diff --git a/lib/net/rte_ip6.h b/lib/net/rte_ip6.h > index 992ab5ee1f..92558a124a 100644 > --- a/lib/net/rte_ip6.h > +++ b/lib/net/rte_ip6.h > @@ -358,7 +358,7 @@ enum rte_ipv6_mc_scope { > RTE_IPV6_MC_SCOPE_ORGLOCAL =3D 0x08, > /** Global multicast scope. */ > RTE_IPV6_MC_SCOPE_GLOBAL =3D 0x0e, > -} __rte_packed; > +}; > > /** > * Extract the IPv6 multicast scope value as defined in RFC 4291, sectio= n 2.7. Cc: Robin for info. This change affects the storage size of a variable of this type (at least with gcc). I think it is ok from an ABI pov: there is one (inline) helper using this type, and nothing else in DPDK takes a IPv6 multicast scope as input. However, it deserves a mention in the commitlog (maybe a separate commit to highlight it?). --=20 David Marchand