From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-f66.google.com (mail-ua1-f66.google.com [209.85.222.66]) by dpdk.org (Postfix) with ESMTP id 8C6532C2B for ; Wed, 8 May 2019 16:47:19 +0200 (CEST) Received: by mail-ua1-f66.google.com with SMTP id t15so7473257uao.5 for ; Wed, 08 May 2019 07:47:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ldXeKZZ1EUvcc+HxyLNz/jqMBo/Hp5QAKjppzfpv2KU=; b=GsWUKUoeEbOX3jJ6u+0Y+CqnM+97XSxkj2rOrN/f+tnqnL7pwRpI9pjxyk1i/63WD9 WZSpLtQTGIGqqoSnUH/hUdVpA2evM3kmWEvyZbeTBHRZpWJp5/dEuecTJL2/FwkAjpDQ baZqV5sSCJYnFJykYuw+guAsqO/I//FSv1RVPKM1P2j+i/vSGiXmLsC2JCJiTHoRK18v NBni7aMoR8IvjUM6reLXFk6ouxG9qfSIEKQqbvtwdt1+EpFoRej5U2nRs1OlGmb4YbTc 7zykSe43N/Xt0zQeGUBylhHEgk/2bxtJTDMnbLxwMmGMyT/RyUaVZhE8s5Vrop01llw/ 8ogg== X-Gm-Message-State: APjAAAUAChCWx9ex9S3DAfUGYHQaBAPh+zJhnlBF2Vm02tjLYnNlCJJG lPRo9yvv+nQGr3iBd1Nj+QLc7SBJwKvl+HKOqfXVAg== X-Google-Smtp-Source: APXvYqzxOfJBiDEXfdZGQx8vIB/ohfqn7qeUJ2uCrbX7SZDcSONZb/LtUJ/rW21X8UHWQ03yMH09ILTLO7h0ryx7tYs= X-Received: by 2002:ab0:70d3:: with SMTP id r19mr5101623ual.126.1557326838874; Wed, 08 May 2019 07:47:18 -0700 (PDT) MIME-Version: 1.0 References: <1524552123-31378-1-git-send-email-arnon@qwilt.com> <2691001.bJ2rVGK9ui@xps> In-Reply-To: <2691001.bJ2rVGK9ui@xps> From: David Marchand Date: Wed, 8 May 2019 16:47:07 +0200 Message-ID: To: Thomas Monjalon Cc: Arnon Warshavsky , dev , "Burakov, Anatoly" , Wenzhuo Lu , declan.doherty@intel.com, Jerin Jacob , Bruce Richardson , "Yigit, Ferruh" , ranjit.menon@intel.com, pallavi.kadam@intel.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 May 2019 14:47:19 -0000 On Wed, May 8, 2019 at 1:16 PM Thomas Monjalon wrote: > I did a status of rte_panic/rte_exit calls in libs. > > There are a lot of cleanups to do in EAL. > We may apply the same kind of solution for Linux, FreeBSD and Windows. > > Thanks for the list. Only checked at the mbuf part for now. librte_mbuf: > void rte_mbuf_sanity_check > rte_panic > This function does panic yes, but we have a non-panicking equivalent version of this function: rte_mbuf_check(). When RTE_LIBRTE_MBUF_DEBUG is set, a lot of internals in rte_mbuf call _rte_mbuf_sanity_check which calls rte_mbuf_sanity_check. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 97366A0096 for ; Wed, 8 May 2019 16:47:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4633134F0; Wed, 8 May 2019 16:47:21 +0200 (CEST) Received: from mail-ua1-f66.google.com (mail-ua1-f66.google.com [209.85.222.66]) by dpdk.org (Postfix) with ESMTP id 8C6532C2B for ; Wed, 8 May 2019 16:47:19 +0200 (CEST) Received: by mail-ua1-f66.google.com with SMTP id t15so7473257uao.5 for ; Wed, 08 May 2019 07:47:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ldXeKZZ1EUvcc+HxyLNz/jqMBo/Hp5QAKjppzfpv2KU=; b=GsWUKUoeEbOX3jJ6u+0Y+CqnM+97XSxkj2rOrN/f+tnqnL7pwRpI9pjxyk1i/63WD9 WZSpLtQTGIGqqoSnUH/hUdVpA2evM3kmWEvyZbeTBHRZpWJp5/dEuecTJL2/FwkAjpDQ baZqV5sSCJYnFJykYuw+guAsqO/I//FSv1RVPKM1P2j+i/vSGiXmLsC2JCJiTHoRK18v NBni7aMoR8IvjUM6reLXFk6ouxG9qfSIEKQqbvtwdt1+EpFoRej5U2nRs1OlGmb4YbTc 7zykSe43N/Xt0zQeGUBylhHEgk/2bxtJTDMnbLxwMmGMyT/RyUaVZhE8s5Vrop01llw/ 8ogg== X-Gm-Message-State: APjAAAUAChCWx9ex9S3DAfUGYHQaBAPh+zJhnlBF2Vm02tjLYnNlCJJG lPRo9yvv+nQGr3iBd1Nj+QLc7SBJwKvl+HKOqfXVAg== X-Google-Smtp-Source: APXvYqzxOfJBiDEXfdZGQx8vIB/ohfqn7qeUJ2uCrbX7SZDcSONZb/LtUJ/rW21X8UHWQ03yMH09ILTLO7h0ryx7tYs= X-Received: by 2002:ab0:70d3:: with SMTP id r19mr5101623ual.126.1557326838874; Wed, 08 May 2019 07:47:18 -0700 (PDT) MIME-Version: 1.0 References: <1524552123-31378-1-git-send-email-arnon@qwilt.com> <2691001.bJ2rVGK9ui@xps> In-Reply-To: <2691001.bJ2rVGK9ui@xps> From: David Marchand Date: Wed, 8 May 2019 16:47:07 +0200 Message-ID: To: Thomas Monjalon Cc: Arnon Warshavsky , dev , "Burakov, Anatoly" , Wenzhuo Lu , declan.doherty@intel.com, Jerin Jacob , Bruce Richardson , "Yigit, Ferruh" , ranjit.menon@intel.com, pallavi.kadam@intel.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190508144707.qUMcfFxssmLsfk_5YOO57YiFhPC4Ltxallm2EyZZU_A@z> On Wed, May 8, 2019 at 1:16 PM Thomas Monjalon wrote: > I did a status of rte_panic/rte_exit calls in libs. > > There are a lot of cleanups to do in EAL. > We may apply the same kind of solution for Linux, FreeBSD and Windows. > > Thanks for the list. Only checked at the mbuf part for now. librte_mbuf: > void rte_mbuf_sanity_check > rte_panic > This function does panic yes, but we have a non-panicking equivalent version of this function: rte_mbuf_check(). When RTE_LIBRTE_MBUF_DEBUG is set, a lot of internals in rte_mbuf call _rte_mbuf_sanity_check which calls rte_mbuf_sanity_check. -- David Marchand