From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E6E246148; Thu, 30 Jan 2025 09:52:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D37C040275; Thu, 30 Jan 2025 09:52:24 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7EFD640156 for ; Thu, 30 Jan 2025 09:52:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738227143; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VEfjVkE6I/W3fMwo1IyZM45PdYCZ/nc4HP47xURvoDU=; b=D+Dfi9LwP31GajjjImKbQa2QejMWbBFVtwzAE03Tfp9OAuVgjw2Qia4Fex3BDQoAdw+Thw 2MoKqYx+pJUXqGuO1++7VYlKYHStA+0UX+uhRfBnKx7vWvSLSpVUrt9rgy4SpvL+fQCaPN Lr9kN2iejTq6DDH80NkH6MdIOHcBxu8= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-617-WiXvLbnPNE-u6fzodYxhXg-1; Thu, 30 Jan 2025 03:52:21 -0500 X-MC-Unique: WiXvLbnPNE-u6fzodYxhXg-1 X-Mimecast-MFC-AGG-ID: WiXvLbnPNE-u6fzodYxhXg Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-3003190ec72so3215031fa.2 for ; Thu, 30 Jan 2025 00:52:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738227140; x=1738831940; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VEfjVkE6I/W3fMwo1IyZM45PdYCZ/nc4HP47xURvoDU=; b=qwab724IcDqNp7NtuiyXHIRkd8YywVeVEi0bMSou2O586/4Q8r7+BdoEJyllGl4byk LPltJ93XV3KYUAcxjH8HXKCNUr7f4WatixdlxB9EjcIxjN7eUBIDiy/f++uytbSCSmOn G1D2I4Qbr5aDnm4b0MtpKoH40pZDu91rAHVHFDA1p2oswUbpkdHhQOm1Uk5+5RT3yIJk IXMBUrtTplykhnZnfGYjqWZeyD7ukXiJMe7ncAKOIlGasFdOg15sid6dJw3Z9HeKnTyS XBi0nqKwxpkCYcrSfmctW2/GM4ZiW7LxJV9zb9oPKYMBcx0bZf6jD/EmVZk6GWpGcrPM LCnQ== X-Gm-Message-State: AOJu0YwMG9XcBbesbdTmG2wK+O+dfBe3W5rtl88xvan9APiupQeYD4qX fIPJE/zcpTvrkRSyvkx7gTPs2zEr/wk7BHH8pVkTkBakpIf8k08OBrv8utyLtm28T0kxd89dR5t K//sQ/37Sfx2QHEGn0Tm7TANt3dxD9YFymwHebc+9HOK237DVH/J85bDNzB6pFnem2FG1ZxLbZM 3Hix88xLZU1bM8tLE= X-Gm-Gg: ASbGncuJgSz+wfDPVE+LsBQkk3Y4SmF+kI07xecpY3Kxv1E9yH2MkjPP7m17pCxB3zm stiPlz2kuqyjP8S87G2W2Z5F4oyv46rlTafY7QO7XiTpHfJiVECE0X3Fo9ovheE8o X-Received: by 2002:a05:651c:2229:b0:2ff:d7cf:a6cb with SMTP id 38308e7fff4ca-30796839b54mr27339991fa.11.1738227140030; Thu, 30 Jan 2025 00:52:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IFfNYeA4VZjNbXpNmP6SH4FG1anTdJz/ZpeGkAiY1Ex8QOsHrHXeiLQY1jmX5ruiFOf4/YQgFNHk9cHVs6dzp8= X-Received: by 2002:a05:651c:2229:b0:2ff:d7cf:a6cb with SMTP id 38308e7fff4ca-30796839b54mr27339711fa.11.1738227139558; Thu, 30 Jan 2025 00:52:19 -0800 (PST) MIME-Version: 1.0 References: <20250130083741.3258965-1-david.marchand@redhat.com> <98CBD80474FA8B44BF855DF32C47DC35E9FA08@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9FA08@smartserver.smartshare.dk> From: David Marchand Date: Thu, 30 Jan 2025 09:52:08 +0100 X-Gm-Features: AWEUYZkFdmqXq4_1iOkYQ4kX053-BuC26sUFXkZXAFSeVNIlCpeAT15q0tFIPpc Message-ID: Subject: Re: [PATCH] devtools: forbid use of compiler pragmas To: =?UTF-8?Q?Morten_Br=C3=B8rup?= Cc: dev@dpdk.org, bruce.richardson@intel.com, andremue@linux.microsoft.com, roretzla@linux.microsoft.com, Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: s4D1RoMH2SqVggzRdJ-KsI4U6T-FBZLRCbsyB_eIffA_1738227140 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 30, 2025 at 9:45=E2=80=AFAM Morten Br=C3=B8rup wrote: > > > From: David Marchand [mailto:david.marchand@redhat.com] > > Sent: Thursday, 30 January 2025 09.38 > > > > Using pragma must be prevented to avoid breaking builds with other > > compilers. > > Let EAL use them (like for abstraction macros). > > You are only allowing them in rte_common.h. > Do we need them elsewhere in EAL? > Not that I think so, but the patch description could be interpreted that = way. Ah yes, I forgot to update description afterwards. I can update when applying. > > > > > Signed-off-by: David Marchand > > --- > > Good idea! > > Acked-by: Morten Br=C3=B8rup --=20 David Marchand