DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
	 Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] flow_classify: remove library
Date: Tue, 1 Aug 2023 09:50:58 +0200	[thread overview]
Message-ID: <CAJFAV8z-mi=u4QvC5fUQUv3We69dM0LsMg_Yw4V_5pnQMBJ1NQ@mail.gmail.com> (raw)
In-Reply-To: <20230731204521.192243-1-stephen@networkplumber.org>

Hello,

On Mon, Jul 31, 2023 at 10:45 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The flow_classify library was marked for removal last year
> because there was no maintainer and the functionality is
> limited.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  MAINTAINERS                                   |   7 -
>  app/test/meson.build                          |   4 -
>  app/test/test_flow_classify.c                 | 895 ------------------

app/test/test_flow_classify.h can be removed too.

>  doc/api/doxy-api-index.md                     |   1 -
>  doc/api/doxy-api.conf.in                      |   1 -
>  doc/guides/freebsd_gsg/build_sample_apps.rst  |   2 +-
>  doc/guides/freebsd_gsg/install_from_ports.rst |   2 +-
>  doc/guides/prog_guide/flow_classify_lib.rst   | 424 ---------
>  doc/guides/prog_guide/index.rst               |   1 -
>  doc/guides/rel_notes/deprecation.rst          |   8 +-
>  doc/guides/rel_notes/release_23_11.rst        |   3 +
>  doc/guides/sample_app_ug/flow_classify.rst    | 242 -----
>  doc/guides/sample_app_ug/index.rst            |   1 -
>  examples/flow_classify/Makefile               |  51 -
>  examples/flow_classify/flow_classify.c        | 878 -----------------
>  examples/flow_classify/ipv4_rules_file.txt    |  14 -
>  examples/flow_classify/meson.build            |  13 -
>  examples/meson.build                          |   1 -
>  lib/flow_classify/meson.build                 |  12 -
>  lib/flow_classify/rte_flow_classify.c         | 670 -------------
>  lib/flow_classify/rte_flow_classify.h         | 284 ------
>  lib/flow_classify/rte_flow_classify_parse.c   | 532 -----------
>  lib/flow_classify/rte_flow_classify_parse.h   |  58 --
>  lib/flow_classify/version.map                 |  13 -
>  lib/meson.build                               |   3 -
>  meson_options.txt                             |   2 +-
>  26 files changed, 7 insertions(+), 4115 deletions(-)
>  delete mode 100644 app/test/test_flow_classify.c
>  delete mode 100644 doc/guides/prog_guide/flow_classify_lib.rst
>  delete mode 100644 doc/guides/sample_app_ug/flow_classify.rst
>  delete mode 100644 examples/flow_classify/Makefile
>  delete mode 100644 examples/flow_classify/flow_classify.c
>  delete mode 100644 examples/flow_classify/ipv4_rules_file.txt
>  delete mode 100644 examples/flow_classify/meson.build
>  delete mode 100644 lib/flow_classify/meson.build
>  delete mode 100644 lib/flow_classify/rte_flow_classify.c
>  delete mode 100644 lib/flow_classify/rte_flow_classify.h
>  delete mode 100644 lib/flow_classify/rte_flow_classify_parse.c
>  delete mode 100644 lib/flow_classify/rte_flow_classify_parse.h
>  delete mode 100644 lib/flow_classify/version.map
>

[snip]

> diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst
> index 6b4dd21fd0e1..f4c1e5ef4a7a 100644
> --- a/doc/guides/rel_notes/release_23_11.rst
> +++ b/doc/guides/rel_notes/release_23_11.rst
> @@ -68,6 +68,9 @@ Removed Items
>     Also, make sure to start the actual text at the margin.
>     =======================================================
>
> +* flow_classify: library has been removed as planned.
> +  The library was experimental there was no maintainer or user interest.
> +
>

Please use a consistent wording, like for kni.


>  API Changes
>  -----------

Thanks.


-- 
David Marchand


      reply	other threads:[~2023-08-01  7:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31 20:45 Stephen Hemminger
2023-08-01  7:50 ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8z-mi=u4QvC5fUQUv3We69dM0LsMg_Yw4V_5pnQMBJ1NQ@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).